]> Pileus Git - ~andy/gtk/log
~andy/gtk
11 years agotreeview: center expander allocated space
Cosimo Cecchi [Sat, 23 Feb 2013 00:53:03 +0000 (19:53 -0500)]
treeview: center expander allocated space

This patch centers the expander in the extra space allocated by the
horizontal-separator style property.

https://bugzilla.gnome.org/show_bug.cgi?id=650424

11 years agotreeview: properly calculate the treeview expander size
Cosimo Cecchi [Sat, 23 Feb 2013 00:51:54 +0000 (19:51 -0500)]
treeview: properly calculate the treeview expander size

It should be expander-size + horizontal-separator / 2. Rework code
calculating the render position of the arrow to account for the larger
size.

https://bugzilla.gnome.org/show_bug.cgi?id=650424

11 years agotreeview: remove extra padding handling
Cosimo Cecchi [Sat, 23 Feb 2013 00:26:40 +0000 (19:26 -0500)]
treeview: remove extra padding handling

We'll replace this with a proper calculation.

https://bugzilla.gnome.org/show_bug.cgi?id=650424

11 years agoFix gtkprintbackendcups crash
John Ralls [Fri, 1 Mar 2013 18:13:20 +0000 (10:13 -0800)]
Fix gtkprintbackendcups crash

From trying to call g_list_delete_link with a NULL node or
removed_printer_checklist.

11 years agobroadway: pointer targets differ in signedness
Benjamin Otte [Fri, 1 Mar 2013 13:21:19 +0000 (14:21 +0100)]
broadway: pointer targets differ in signedness

11 years agobroadway: variable 'broadway_display' set but not used
Benjamin Otte [Fri, 1 Mar 2013 13:20:57 +0000 (14:20 +0100)]
broadway: variable 'broadway_display' set but not used

11 years agoUpdated Traditional Chinese translation(Hong Kong and Taiwan)
Chao-Hsiung Liao [Fri, 1 Mar 2013 14:33:07 +0000 (22:33 +0800)]
Updated Traditional Chinese translation(Hong Kong and Taiwan)

11 years agoRe-fix opacity group handling
Alexander Larsson [Fri, 1 Mar 2013 13:56:30 +0000 (14:56 +0100)]
Re-fix opacity group handling

The last change fixed the windowed widget case but broke
opacity group handling for windowed child widgets. This fixes
up the code by making sure we norender_children in when there
is an opacity group.

This also cleans up the comments about how this works to something
that is hopefully more understandable.

11 years agogdkwindow: Update window debug dump code
Alexander Larsson [Fri, 1 Mar 2013 13:55:54 +0000 (14:55 +0100)]
gdkwindow: Update window debug dump code

This makes it build without warning and also dumps alpha

11 years agoTextView: Properly render background
Alexander Larsson [Fri, 1 Mar 2013 11:23:59 +0000 (12:23 +0100)]
TextView: Properly render background

We always need to render the background, as the window
background is not always set (i.e. during gtk_widget_draw()) or
when its partially visible.

https://bugzilla.gnome.org/show_bug.cgi?id=694925

11 years agoUpdated Serbian translation
Мирослав Николић [Fri, 1 Mar 2013 10:39:42 +0000 (11:39 +0100)]
Updated Serbian translation

11 years agoUpdated gujarati file
Sweta Kothari [Fri, 1 Mar 2013 07:19:00 +0000 (12:49 +0530)]
Updated gujarati file

11 years agoFix broken quartz build from df3e19b
John Ralls [Thu, 28 Feb 2013 20:34:33 +0000 (12:34 -0800)]
Fix broken quartz build from df3e19b

It's _gdk_display, not display

11 years agoUpdate Simplified Chinese translation
keyring [Thu, 28 Feb 2013 13:08:27 +0000 (21:08 +0800)]
Update Simplified Chinese translation

11 years agoFix DND with frame sync
Matthias Clasen [Thu, 28 Feb 2013 12:44:00 +0000 (07:44 -0500)]
Fix DND with frame sync

Mutter magically ignores override-redirect windows with geometry
-100-100+1+1, and this breaks the frame synchronization between
gtk+ and mutter. For now, we avoid the issue by simply giving
the window a different geometry.
https://bugzilla.gnome.org/show_bug.cgi?id=694217

11 years agoRemove GTK_SELECTION_MODE_EXTENDED from the docs
Matthias Clasen [Mon, 25 Feb 2013 20:07:59 +0000 (21:07 +0100)]
Remove GTK_SELECTION_MODE_EXTENDED from the docs

It does not exist anymore as an enum value.

11 years agorange: don't draw origin when the slider is invisible
Cosimo Cecchi [Wed, 27 Feb 2013 22:18:28 +0000 (17:18 -0500)]
range: don't draw origin when the slider is invisible

When the range of the GtkRange is zero (i.e. the upper and lower bounds
of the adjustment have the same value), don't use an origin to draw the
trough, as the slider will also be hidden, and the juncture between the
two sections of the trough will be visible.

11 years agoFix opacity group hack
Alexander Larsson [Wed, 27 Feb 2013 11:57:38 +0000 (12:57 +0100)]
Fix opacity group hack

We can't norender the main window for a windowed widget as we then
never get any expose events.

11 years ago[l10n] Updated Estonian translation
Priit Laes [Wed, 27 Feb 2013 08:25:42 +0000 (10:25 +0200)]
[l10n] Updated Estonian translation

11 years agoFix gtk3-demo Visual Studio projects
Chun-wei Fan [Wed, 27 Feb 2013 04:33:42 +0000 (12:33 +0800)]
Fix gtk3-demo Visual Studio projects

Since we are linking in the resource items by the source, we need to
disable WholeProgramOptimization so that the resource stuff does get linked
into the demo binaries, so that they can be loaded properly.

Also make sure that gtk3-demo-application is also built with the multibyte
character set, like the rest.

This should fix bug 694342, at least for Visual Studio builds.

11 years agoGdkScreen: get a long X property correctly
Geoff Reedy [Tue, 26 Feb 2013 23:58:21 +0000 (17:58 -0600)]
GdkScreen: get a long X property correctly

https://bugzilla.gnome.org/show_bug.cgi?id=691426
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
11 years agoUpdated Lithuanian UI translation
Aurimas Černius [Tue, 26 Feb 2013 21:00:46 +0000 (23:00 +0200)]
Updated Lithuanian UI translation

11 years agogdk: prevent NULL pointer access when debugging is enabled
Thomas Wood [Tue, 26 Feb 2013 11:06:45 +0000 (11:06 +0000)]
gdk: prevent NULL pointer access when debugging is enabled

If no updates, redraws, or repaints have been scheduled for this frame,
we will skip immediately to RESUME_EVENTS, and no GdkFrameTimings will
be created.

https://bugzilla.gnome.org/show_bug.cgi?id=694732

11 years agoa11y: Emit text-changed signals when the text-buffer changes
Benjamin Otte [Tue, 26 Feb 2013 15:17:33 +0000 (16:17 +0100)]
a11y: Emit text-changed signals when the text-buffer changes

11 years agogtk-demo: Create new textbuffers for new source/info texts
Benjamin Otte [Tue, 26 Feb 2013 14:55:29 +0000 (15:55 +0100)]
gtk-demo: Create new textbuffers for new source/info texts

This is so we can prepare these buffers without them being set on the
widgets yet and only gtk_text_view_set_buffer() them afterwards. And
this in turn gets rid of all the a11y events we were needlessly
emitting.

https://bugzilla.gnome.org/show_bug.cgi?id=694406

11 years agowin32: fix possible memleak if GlobalAlloc() fails
Aleksander Morgado [Tue, 26 Feb 2013 13:51:31 +0000 (14:51 +0100)]
win32: fix possible memleak if GlobalAlloc() fails

Also remove the unused 'buf' variable.

https://bugzilla.gnome.org/show_bug.cgi?id=694742

11 years agoUpdated Spanish translation
Daniel Mustieles [Tue, 26 Feb 2013 13:49:47 +0000 (14:49 +0100)]
Updated Spanish translation

11 years agoPunjabi: Translation updated (aalam)
A S Alam [Tue, 26 Feb 2013 01:22:45 +0000 (06:52 +0530)]
Punjabi: Translation updated (aalam)

11 years agoPunjabi: Translation updated (aalam)
A S Alam [Tue, 26 Feb 2013 01:22:38 +0000 (06:52 +0530)]
Punjabi: Translation updated (aalam)

11 years agoAPI: Export gtk_cell_renderer_class_set_accessible_type()
Benjamin Otte [Mon, 25 Feb 2013 20:41:30 +0000 (21:41 +0100)]
API: Export gtk_cell_renderer_class_set_accessible_type()

This function is necessary to implement cell renderer accessibility
support.

11 years agoUpdated Spanish translation
Daniel Mustieles [Mon, 25 Feb 2013 17:00:07 +0000 (18:00 +0100)]
Updated Spanish translation

11 years agoUpdated Greek translation
Dimitris Spingos [Mon, 25 Feb 2013 13:54:17 +0000 (15:54 +0200)]
Updated Greek translation

11 years agoSome more documentation fixes
Matthias Clasen [Mon, 25 Feb 2013 10:30:00 +0000 (11:30 +0100)]
Some more documentation fixes

Make frame-clock-related symbols show up in the gtk docs.

11 years agoFix a few more doc issues
Matthias Clasen [Mon, 25 Feb 2013 09:57:34 +0000 (10:57 +0100)]
Fix a few more doc issues

11 years agoAdd available marker to gdk_x11_window_set_utf8_property
Matthias Clasen [Mon, 25 Feb 2013 09:50:28 +0000 (10:50 +0100)]
Add available marker to gdk_x11_window_set_utf8_property

11 years agoAdd another forgotten symbol
Matthias Clasen [Mon, 25 Feb 2013 09:49:24 +0000 (10:49 +0100)]
Add another forgotten symbol

11 years agoAdd index for new api additions
Matthias Clasen [Mon, 25 Feb 2013 09:44:29 +0000 (10:44 +0100)]
Add index for new api additions

The index for 3.8 api additions was missing up to now.

11 years agoPedantic fixes
Matthias Clasen [Mon, 25 Feb 2013 09:42:42 +0000 (10:42 +0100)]
Pedantic fixes

Remove a C99 comment, and line up comment formatting.

11 years agoInclude GdkFrameClock in the docs
Matthias Clasen [Mon, 25 Feb 2013 09:38:28 +0000 (10:38 +0100)]
Include GdkFrameClock in the docs

Make GdkFrameClock and GdkFrameTimings show up in the docs.
A couple of minor doc fixes are also included.

11 years agoInclude public headers in gdk.h
Matthias Clasen [Mon, 25 Feb 2013 09:36:47 +0000 (10:36 +0100)]
Include public headers in gdk.h

gdkframeclock.h and gdkframetimings.h were not directly included
in gdk.h. They should.

11 years agoUpdated Greek translation po
Dimitris Spingos [Mon, 25 Feb 2013 09:06:59 +0000 (11:06 +0200)]
Updated Greek translation po

11 years agoUpdated Greek translation
Dimitris Spingos [Mon, 25 Feb 2013 08:56:48 +0000 (10:56 +0200)]
Updated Greek translation

11 years agoUpdated Slovenian translation
Matej Urbančič [Sun, 24 Feb 2013 20:22:16 +0000 (21:22 +0100)]
Updated Slovenian translation

11 years agoUpdated Greek translation
Dimitris Spingos [Sun, 24 Feb 2013 08:07:19 +0000 (10:07 +0200)]
Updated Greek translation

11 years agoRevert "box: Don't special-case RTL hbox child positions anymore"
Cosimo Cecchi [Fri, 22 Feb 2013 14:14:19 +0000 (09:14 -0500)]
Revert "box: Don't special-case RTL hbox child positions anymore"

This reverts commit 6f86e57c4fb2cd76549910302b3a7145e7fd0e8b.

https://bugzilla.gnome.org/show_bug.cgi?id=694451

11 years agoRevert "toolbar: Don't special-case RTL toolbar child positions anymore"
Cosimo Cecchi [Fri, 22 Feb 2013 14:14:10 +0000 (09:14 -0500)]
Revert "toolbar: Don't special-case RTL toolbar child positions anymore"

This reverts commit 821a675013e04598503d3c5ea23ab91607f98e70.

https://bugzilla.gnome.org/show_bug.cgi?id=694451

11 years agoRevert "combobox: Don't special-case RTL child positions anymore"
Cosimo Cecchi [Fri, 22 Feb 2013 14:14:04 +0000 (09:14 -0500)]
Revert "combobox: Don't special-case RTL child positions anymore"

This reverts commit cf712c462d766e32840da21a67708bbf2cbb25a6.

https://bugzilla.gnome.org/show_bug.cgi?id=694451

11 years agoUpdated Czech translation
Marek Černocký [Fri, 22 Feb 2013 21:06:03 +0000 (22:06 +0100)]
Updated Czech translation

11 years agoUpdated Czech translation
Marek Černocký [Fri, 22 Feb 2013 20:48:59 +0000 (21:48 +0100)]
Updated Czech translation

11 years agoPunjabi: Translation updated (aalam)
A S Alam [Fri, 22 Feb 2013 08:49:11 +0000 (08:49 +0000)]
Punjabi: Translation updated (aalam)

11 years agoPunjabi: Translation updated (aalam)
A S Alam [Fri, 22 Feb 2013 08:49:05 +0000 (08:49 +0000)]
Punjabi: Translation updated (aalam)

11 years agoRe-organize Visual Studio property sheets a bit
Chun-wei Fan [Fri, 22 Feb 2013 05:13:54 +0000 (13:13 +0800)]
Re-organize Visual Studio property sheets a bit

-Use ApiVersion instead of GtkApiVersion for consistency's sake across
 the board
-Add placeholder directives in the property sheets for building
 introspection files using .bat files directly from the Visual Studio IDE.

11 years agoAdd Visual Studio project for gtk3-demo-application
Chun-wei Fan [Fri, 22 Feb 2013 05:09:50 +0000 (13:09 +0800)]
Add Visual Studio project for gtk3-demo-application

This is used by the "Application Class" demo... so this should be built
as well especially as we are getting gspawn-win{32|64}-helper.exe fixed
on Visual Studio 2005 (and later) builds.

11 years agofilechooserbutton: Don't ever use gtk_file_chooser_get_files()
Federico Mena Quintero [Fri, 22 Feb 2013 00:44:38 +0000 (18:44 -0600)]
filechooserbutton: Don't ever use gtk_file_chooser_get_files()

The file chooser button only supports single-selection modes, so
switch the code to a simpler gtk_file_chooser_get_file() to avoid
dealing with GSLists of a single file.

Signed-off-by: Federico Mena Quintero <federico@gnome.org>
11 years agoGtkWidget::draw() - Document how to get the dirty region
Federico Mena Quintero [Thu, 21 Feb 2013 18:55:50 +0000 (12:55 -0600)]
GtkWidget::draw() - Document how to get the dirty region

Signed-off-by: Federico Mena Quintero <federico@gnome.org>
11 years agoMake sure icon cache has /-separated subdirs only (v2 - use g_build_path)
Руслан Ижбулатов [Thu, 21 Feb 2013 18:25:21 +0000 (22:25 +0400)]
Make sure icon cache has /-separated subdirs only (v2 - use g_build_path)

https://bugzilla.gnome.org/show_bug.cgi?id=692955

11 years agoConvert pixbuf animation demo (both copies) to GdkFrameClock
Owen W. Taylor [Wed, 20 Feb 2013 19:46:11 +0000 (14:46 -0500)]
Convert pixbuf animation demo (both copies) to GdkFrameClock

Use the frame clock instead of a 50ms timeout to animate the
spinning pixbufs.

https://bugzilla.gnome.org/show_bug.cgi?id=694302

11 years agoBroadway/Quartz/Win32: make event source prepare()/check() note paused status
Owen W. Taylor [Wed, 20 Feb 2013 17:27:07 +0000 (12:27 -0500)]
Broadway/Quartz/Win32: make event source prepare()/check() note paused status

When events are paused, we should not return TRUE from prepare() or check().
GTK+ handles this for events that are already in the GTK+ queue, but
we also need suppress checks for events that are in the system queue - if we
return TRUE indicating that there are events in the system queue, then we'll
call dispatch(), and do nothing. The event source will spin, and will never
run the other phases of the paint clock.

(Broadway doesn't have a window system queue separate from the GDK event queue,
but we write the function the same way for consistency.)

https://bugzilla.gnome.org/show_bug.cgi?id=694274

11 years agowayland: don't attempt to unqueue events when events are paused
Thomas Wood [Wed, 20 Feb 2013 13:53:59 +0000 (13:53 +0000)]
wayland: don't attempt to unqueue events when events are paused

When events are paused, we should not return TRUE from prepare() or check().
GTK+ handles this for events that are already in the GTK+ queue, but
we also need suppress checks for events that are in the system queue - if we
return TRUE indicating that there are events in the system queue, then we'll
call dispatch(), and do nothing. The event source will spin, and will never
run the other phases of the paint clock.

https://bugzilla.gnome.org/show_bug.cgi?id=694274

11 years agoUpdated Russian translation
Yuri Myasoedov [Thu, 21 Feb 2013 12:13:56 +0000 (16:13 +0400)]
Updated Russian translation

11 years agoRedo Completion of Visual Studio projects for gtka11y
Chun-wei Fan [Thu, 21 Feb 2013 07:48:04 +0000 (15:48 +0800)]
Redo Completion of Visual Studio projects for gtka11y

Update the Visual Studio projects for gtka11y and the completion of the
projects that go along with it.  This have been distcheck'ed on my Ubuntu
12.04 system.

11 years agoFix gtk-demo projects
Chun-wei Fan [Thu, 21 Feb 2013 07:30:41 +0000 (15:30 +0800)]
Fix gtk-demo projects

There isn't a custom CSS demo anymore, so remove that from the projects

11 years agoUpdate GDK Visual Studio projects
Chun-wei Fan [Thu, 21 Feb 2013 07:14:25 +0000 (15:14 +0800)]
Update GDK Visual Studio projects

Link to winmm.lib as well, as we are now using timeEndPeriod() and
timeBeginPeriod() since commit 5dbf814f (win32: Request higher
precision timers during animations).

11 years agofilechooserbutton: In tests, sleep after opening the dialog
Federico Mena Quintero [Thu, 21 Feb 2013 00:52:23 +0000 (18:52 -0600)]
filechooserbutton: In tests, sleep after opening the dialog

This may ensure that the dialog is actually done initializing.  We need to kill this
sleeping business and really use signals, sigh...

Signed-off-by: Federico Mena Quintero <federico@gnome.org>
11 years agofilechooserbutton: Don't emit file-set signal when the change is not the result of...
Federico Mena Quintero [Thu, 21 Feb 2013 00:30:30 +0000 (18:30 -0600)]
filechooserbutton: Don't emit file-set signal when the change is not the result of a user action

We only emit that signal when the user confirms the button's internal GtkFileChooserDialog,
or when he drags-and-drops stuff into the button.

Signed-off-by: Federico Mena Quintero <federico@gnome.org>
11 years agofilechooserbutton: In the tests, run through the dialog more than one time
Federico Mena Quintero [Thu, 21 Feb 2013 00:28:59 +0000 (18:28 -0600)]
filechooserbutton: In the tests, run through the dialog more than one time

This ensures that data maintained by the button while the dialog opens/closes remains consistent.

Signed-off-by: Federico Mena Quintero <federico@gnome.org>
11 years agofilechooserbutton: Add tests for cancelling the dialog via closing it (delete-event...
Federico Mena Quintero [Thu, 21 Feb 2013 00:14:15 +0000 (18:14 -0600)]
filechooserbutton: Add tests for cancelling the dialog via closing it (delete-event), instead of by simulating the Cancel button (response cancel)

Signed-off-by: Federico Mena Quintero <federico@gnome.org>
11 years agofilechooser: When stopping/clearing BROWSE model, really ensure that we end up in...
Federico Mena Quintero [Thu, 21 Feb 2013 00:02:24 +0000 (18:02 -0600)]
filechooser: When stopping/clearing BROWSE model, really ensure that we end up in LOAD_EMPTY state

Previously we could end up in a situation where browse_list_model==NULL, and yet load_state==LOAD_FINISHED.
This is not a valid state.  So, when we get rid of the list model, really ensure that we end up
in LOAD_EMPTY so nothing assumes that there is a valid list model around.

Signed-off-by: Federico Mena Quintero <federico@gnome.org>
11 years agofilechooser: Tighten up some assertions when actually selecting files in the treeview
Federico Mena Quintero [Wed, 20 Feb 2013 23:14:20 +0000 (17:14 -0600)]
filechooser: Tighten up some assertions when actually selecting files in the treeview

The model must be fully loaded, and it must be inserted in the treeview.

Signed-off-by: Federico Mena Quintero <federico@gnome.org>
11 years agoGtkUIManager Buildable implementation: Fixing leaked reference count
Tristan Van Berkom [Wed, 20 Feb 2013 09:17:14 +0000 (18:17 +0900)]
GtkUIManager Buildable implementation: Fixing leaked reference count

Committing this on behalf of Milan Crha, bug: 694162

11 years agoa11y: Only emit expandable/expanded for expander column
Benjamin Otte [Wed, 20 Feb 2013 01:42:50 +0000 (02:42 +0100)]
a11y: Only emit expandable/expanded for expander column

We don't want to emit state changes for all the cells in a row, just for
the cell in the expander column. It's the only one that reports EXPANDED
or EXPANDABLE states, after all.

Also, contains refactoring of the affected functions for all the special
cases.

https://bugzilla.gnome.org/show_bug.cgi?id=694059

11 years agoUpdated German translation
Benjamin Steinwender [Tue, 19 Feb 2013 23:12:17 +0000 (00:12 +0100)]
Updated German translation

11 years agoa11y: Fix copy-paste error in state flag notification
Benjamin Otte [Tue, 19 Feb 2013 22:22:48 +0000 (23:22 +0100)]
a11y: Fix copy-paste error in state flag notification

We weren't checking the removed flag but the added flag for removal
emissions, so what would happen for every state change notification was:
- on state-added, both an "added" and a "removed" event were emitted
- on state-removed, nothing

https://bugzilla.gnome.org/show_bug.cgi?id=694059

11 years agoAvoid loop in paint update cycle
Alexander Larsson [Tue, 19 Feb 2013 20:03:35 +0000 (21:03 +0100)]
Avoid loop in paint update cycle

Commit 1db87c897f930171646351c99af7df09dc7ec949 accidentally removed
a check for !in_paint_idle in maybe_start_idle which causes us
to create a paint loop whenever something requests a phase
inside the paint_idle.

11 years agox11: Handle case where xsettings are NULL
Benjamin Otte [Tue, 19 Feb 2013 18:55:02 +0000 (19:55 +0100)]
x11: Handle case where xsettings are NULL

11 years agox11: Fix introspection build
Benjamin Otte [Tue, 19 Feb 2013 14:37:26 +0000 (15:37 +0100)]
x11: Fix introspection build

File removal in bb4953f3e8e102264a82ea4938b7813b85320b22 wasn't checked
in here.

11 years agotests: #ifdef out unused functions
Benjamin Otte [Tue, 19 Feb 2013 13:44:49 +0000 (14:44 +0100)]
tests: #ifdef out unused functions

... that are only used in that ifdef.

11 years agox11: Get rid of XSettingsClient object
Benjamin Otte [Tue, 19 Feb 2013 13:31:03 +0000 (14:31 +0100)]
x11: Get rid of XSettingsClient object

Instead, store its variables in the GdkX11Screen.

11 years agotests: Add a test for loading images from file
Benjamin Otte [Tue, 19 Feb 2013 13:15:32 +0000 (14:15 +0100)]
tests: Add a test for loading images from file

Strictly, this belongs in gdk-pixbuf, but GtkImage should have this
working, too.

https://bugzilla.gnome.org/show_bug.cgi?id=694148

11 years agox11: Use _gdk_x11_get_xatom_for_display_printf()
Benjamin Otte [Mon, 18 Feb 2013 16:16:57 +0000 (17:16 +0100)]
x11: Use _gdk_x11_get_xatom_for_display_printf()

instead of keeping the atom around all the time

11 years agox11: Introduce _gdk_x11_get_xatom_for_display_printf()
Benjamin Otte [Mon, 18 Feb 2013 15:59:06 +0000 (16:59 +0100)]
x11: Introduce _gdk_x11_get_xatom_for_display_printf()

and use it instead of caching the atom in the GdkScreenX11.

11 years agox11: Don't keep an "in_init" variable
Benjamin Otte [Mon, 18 Feb 2013 14:09:49 +0000 (15:09 +0100)]
x11: Don't keep an "in_init" variable

Instead, track the init state with a boolean argument.

11 years agox11: Clean up xsettings header
Benjamin Otte [Sat, 16 Feb 2013 23:37:09 +0000 (00:37 +0100)]
x11: Clean up xsettings header

- Don't use defines for renames
- Move enum into only source file using it

11 years agox11: Get rid of XSettingsSetting
Benjamin Otte [Sat, 16 Feb 2013 23:30:06 +0000 (00:30 +0100)]
x11: Get rid of XSettingsSetting

Use GValue throughout instead.

11 years agox11: Remove extra variable
Benjamin Otte [Sat, 16 Feb 2013 22:59:07 +0000 (23:59 +0100)]
x11: Remove extra variable

Use a getter instead.

11 years agox11: Split xsettings event filter into 2 functions
Benjamin Otte [Sat, 16 Feb 2013 22:56:10 +0000 (23:56 +0100)]
x11: Split xsettings event filter into 2 functions

One for each type of window we watch.

11 years agox11: Make stored xsettings window a GdkWindow
Benjamin Otte [Sat, 16 Feb 2013 17:36:05 +0000 (18:36 +0100)]
x11: Make stored xsettings window a GdkWindow

11 years agox11: Split function into two
Benjamin Otte [Fri, 15 Feb 2013 21:32:28 +0000 (22:32 +0100)]
x11: Split function into two

Instead of a boolean is_start, have a start and an end function.

11 years agox11: Use gdk_display_flush()
Benjamin Otte [Fri, 15 Feb 2013 21:26:45 +0000 (22:26 +0100)]
x11: Use gdk_display_flush()

11 years agox11: Get selection atom useing GDK functions
Benjamin Otte [Fri, 15 Feb 2013 19:06:56 +0000 (20:06 +0100)]
x11: Get selection atom useing GDK functions

Don't call XInternAtoms ourselves.

11 years agox11: Warning improvements to xsettings code
Benjamin Otte [Fri, 15 Feb 2013 18:18:11 +0000 (19:18 +0100)]
x11: Warning improvements to xsettings code

... and using g_warning() instead of fprintf()

11 years agox11: Use usual Atom handling in xsettings code
Benjamin Otte [Fri, 15 Feb 2013 18:14:25 +0000 (19:14 +0100)]
x11: Use usual Atom handling in xsettings code

11 years agox11: Consolidate root window event setting in one place
Benjamin Otte [Fri, 15 Feb 2013 17:20:18 +0000 (18:20 +0100)]
x11: Consolidate root window event setting in one place

No need to duplicate things in xsettings code.

11 years agox11: Remove unused argument
Benjamin Otte [Fri, 15 Feb 2013 17:02:51 +0000 (18:02 +0100)]
x11: Remove unused argument

11 years agox11: Store GDK name in xsettings hash table
Benjamin Otte [Thu, 14 Feb 2013 16:20:26 +0000 (17:20 +0100)]
x11: Store GDK name in xsettings hash table

The X name is only used while reading the property, so no need to keep
it.

11 years agox11: Remove XSettingsAction type
Benjamin Otte [Thu, 14 Feb 2013 14:10:18 +0000 (15:10 +0100)]
x11: Remove XSettingsAction type

Use GdkSettingAction instead.

11 years agox11: Make xsettings callbacks code go away
Benjamin Otte [Thu, 14 Feb 2013 14:06:56 +0000 (15:06 +0100)]
x11: Make xsettings callbacks code go away

It's the same callbacks every time, so just move them into the source
file.

11 years agox11: Don't store name in XSettingsSetting anymore
Benjamin Otte [Tue, 12 Feb 2013 19:10:23 +0000 (20:10 +0100)]
x11: Don't store name in XSettingsSetting anymore

This is in preparation to switching XSettingsSetting to GValue

11 years agox11: Use boolean instead of enum for errors in xsettings code
Benjamin Otte [Tue, 12 Feb 2013 18:44:28 +0000 (19:44 +0100)]
x11: Use boolean instead of enum for errors in xsettings code

11 years agox11: Move error reporting to where the error happens
Benjamin Otte [Tue, 12 Feb 2013 18:35:46 +0000 (19:35 +0100)]
x11: Move error reporting to where the error happens

Also, use g_warning() instead of fprintf().