Remove selection for DeviceButtonRelease, we no longer need it now that

Mon Dec  9 18:50:31 2002  Owen Taylor  <otaylor@redhat.com>

        * gdk/x11/gdkinput-x11.c (_gdk_input_common_find_events):
        Remove selection for DeviceButtonRelease, we no longer need
        it now that gxi is gone. (#32617, reported by Garry
        Osgood)

diff --git a/ChangeLog b/ChangeLog
index 28ee442c8f702118c672805c43f17744ef4f3c82..e23c5a01ad7fc125e7a38294d1f09aabb5418592 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+Mon Dec  9 18:50:31 2002  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/x11/gdkinput-x11.c (_gdk_input_common_find_events):
+       Remove selection for DeviceButtonRelease, we no longer need
+       it now that gxi is gone. (#32617, reported by Garry
+       Osgood)
+
 Tue Dec 10 00:49:35 2002  Kristian Rietveld  <kris@gtk.org>
 
        * gdk/gdkpixmap.h (gdk_pixmap_new), (gdk_bitmap_create_from_data),
@@ -2978,7 +2985,7 @@ Fri Sep 27 16:15:11 2002  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtknotebook.c (gtk_notebook_get_event_window_position):
        Handle the case where the first page isn't visible.
-       (#90336, bug tracked down by Chema Celorio)
+       (#81600, bug tracked down by Chema Celorio)
 
 Fri Sep 27 15:57:15 2002  Owen Taylor  <otaylor@redhat.com>
 

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 28ee442c8f702118c672805c43f17744ef4f3c82..e23c5a01ad7fc125e7a38294d1f09aabb5418592 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,10 @@
+Mon Dec  9 18:50:31 2002  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/x11/gdkinput-x11.c (_gdk_input_common_find_events):
+       Remove selection for DeviceButtonRelease, we no longer need
+       it now that gxi is gone. (#32617, reported by Garry
+       Osgood)
+
 Tue Dec 10 00:49:35 2002  Kristian Rietveld  <kris@gtk.org>
 
        * gdk/gdkpixmap.h (gdk_pixmap_new), (gdk_bitmap_create_from_data),
@@ -2978,7 +2985,7 @@ Fri Sep 27 16:15:11 2002  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtknotebook.c (gtk_notebook_get_event_window_position):
        Handle the case where the first page isn't visible.
-       (#90336, bug tracked down by Chema Celorio)
+       (#81600, bug tracked down by Chema Celorio)
 
 Fri Sep 27 15:57:15 2002  Owen Taylor  <otaylor@redhat.com>
 

diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2
index 28ee442c8f702118c672805c43f17744ef4f3c82..e23c5a01ad7fc125e7a38294d1f09aabb5418592 100644 (file)
--- a/ChangeLog.pre-2-2
+++ b/ChangeLog.pre-2-2
@@ -1,3 +1,10 @@
+Mon Dec  9 18:50:31 2002  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/x11/gdkinput-x11.c (_gdk_input_common_find_events):
+       Remove selection for DeviceButtonRelease, we no longer need
+       it now that gxi is gone. (#32617, reported by Garry
+       Osgood)
+
 Tue Dec 10 00:49:35 2002  Kristian Rietveld  <kris@gtk.org>
 
        * gdk/gdkpixmap.h (gdk_pixmap_new), (gdk_bitmap_create_from_data),
@@ -2978,7 +2985,7 @@ Fri Sep 27 16:15:11 2002  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtknotebook.c (gtk_notebook_get_event_window_position):
        Handle the case where the first page isn't visible.
-       (#90336, bug tracked down by Chema Celorio)
+       (#81600, bug tracked down by Chema Celorio)
 
 Fri Sep 27 15:57:15 2002  Owen Taylor  <otaylor@redhat.com>
 

diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index 28ee442c8f702118c672805c43f17744ef4f3c82..e23c5a01ad7fc125e7a38294d1f09aabb5418592 100644 (file)
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -1,3 +1,10 @@
+Mon Dec  9 18:50:31 2002  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/x11/gdkinput-x11.c (_gdk_input_common_find_events):
+       Remove selection for DeviceButtonRelease, we no longer need
+       it now that gxi is gone. (#32617, reported by Garry
+       Osgood)
+
 Tue Dec 10 00:49:35 2002  Kristian Rietveld  <kris@gtk.org>
 
        * gdk/gdkpixmap.h (gdk_pixmap_new), (gdk_bitmap_create_from_data),
@@ -2978,7 +2985,7 @@ Fri Sep 27 16:15:11 2002  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtknotebook.c (gtk_notebook_get_event_window_position):
        Handle the case where the first page isn't visible.
-       (#90336, bug tracked down by Chema Celorio)
+       (#81600, bug tracked down by Chema Celorio)
 
 Fri Sep 27 15:57:15 2002  Owen Taylor  <otaylor@redhat.com>
 

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index 28ee442c8f702118c672805c43f17744ef4f3c82..e23c5a01ad7fc125e7a38294d1f09aabb5418592 100644 (file)
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,10 @@
+Mon Dec  9 18:50:31 2002  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/x11/gdkinput-x11.c (_gdk_input_common_find_events):
+       Remove selection for DeviceButtonRelease, we no longer need
+       it now that gxi is gone. (#32617, reported by Garry
+       Osgood)
+
 Tue Dec 10 00:49:35 2002  Kristian Rietveld  <kris@gtk.org>
 
        * gdk/gdkpixmap.h (gdk_pixmap_new), (gdk_bitmap_create_from_data),
@@ -2978,7 +2985,7 @@ Fri Sep 27 16:15:11 2002  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtknotebook.c (gtk_notebook_get_event_window_position):
        Handle the case where the first page isn't visible.
-       (#90336, bug tracked down by Chema Celorio)
+       (#81600, bug tracked down by Chema Celorio)
 
 Fri Sep 27 15:57:15 2002  Owen Taylor  <otaylor@redhat.com>
 

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index 28ee442c8f702118c672805c43f17744ef4f3c82..e23c5a01ad7fc125e7a38294d1f09aabb5418592 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,10 @@
+Mon Dec  9 18:50:31 2002  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/x11/gdkinput-x11.c (_gdk_input_common_find_events):
+       Remove selection for DeviceButtonRelease, we no longer need
+       it now that gxi is gone. (#32617, reported by Garry
+       Osgood)
+
 Tue Dec 10 00:49:35 2002  Kristian Rietveld  <kris@gtk.org>
 
        * gdk/gdkpixmap.h (gdk_pixmap_new), (gdk_bitmap_create_from_data),
@@ -2978,7 +2985,7 @@ Fri Sep 27 16:15:11 2002  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtknotebook.c (gtk_notebook_get_event_window_position):
        Handle the case where the first page isn't visible.
-       (#90336, bug tracked down by Chema Celorio)
+       (#81600, bug tracked down by Chema Celorio)
 
 Fri Sep 27 15:57:15 2002  Owen Taylor  <otaylor@redhat.com>
 

diff --git a/gdk/x11/gdkinput-x11.c b/gdk/x11/gdkinput-x11.c
index db716fa9f92d2d4368022b80def77469197e4cd9..b53e5cc7a8ce1a767edee296dc35150bc0f786b2 100644 (file)
--- a/gdk/x11/gdkinput-x11.c
+++ b/gdk/x11/gdkinput-x11.c
@@ -267,9 +267,6 @@ _gdk_input_common_find_events(GdkWindow *window,
   XEventClass class;
   
   i = 0;
-  /* We have to track press and release events in pairs to keep
-     track of button state correctly and implement grabbing for
-     the gxi support. FIXME - is this needed any more since gxi is gone? */
   if (mask & GDK_BUTTON_PRESS_MASK || mask & GDK_BUTTON_RELEASE_MASK)
     {
       DeviceButtonPress (gdkdev->xdevice, gdkdev->buttonpress_type,
@@ -279,10 +276,6 @@ _gdk_input_common_find_events(GdkWindow *window,
       DeviceButtonPressGrab (gdkdev->xdevice, 0, class);
       if (class != 0)
          classes[i++] = class;
-      DeviceButtonRelease (gdkdev->xdevice, gdkdev->buttonrelease_type,
-                          class);
-      if (class != 0)
-         classes[i++] = class;
     }
   if (mask & GDK_POINTER_MOTION_MASK)
     {