From b658a5d26c3b8bdc862ecbe1cc72acdd50a8c423 Mon Sep 17 00:00:00 2001 From: Owen Taylor Date: Mon, 9 Dec 2002 23:55:26 +0000 Subject: [PATCH] Remove selection for DeviceButtonRelease, we no longer need it now that Mon Dec 9 18:50:31 2002 Owen Taylor * gdk/x11/gdkinput-x11.c (_gdk_input_common_find_events): Remove selection for DeviceButtonRelease, we no longer need it now that gxi is gone. (#32617, reported by Garry Osgood) --- ChangeLog | 9 ++++++++- ChangeLog.pre-2-10 | 9 ++++++++- ChangeLog.pre-2-2 | 9 ++++++++- ChangeLog.pre-2-4 | 9 ++++++++- ChangeLog.pre-2-6 | 9 ++++++++- ChangeLog.pre-2-8 | 9 ++++++++- gdk/x11/gdkinput-x11.c | 7 ------- 7 files changed, 48 insertions(+), 13 deletions(-) diff --git a/ChangeLog b/ChangeLog index 28ee442c8..e23c5a01a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +Mon Dec 9 18:50:31 2002 Owen Taylor + + * gdk/x11/gdkinput-x11.c (_gdk_input_common_find_events): + Remove selection for DeviceButtonRelease, we no longer need + it now that gxi is gone. (#32617, reported by Garry + Osgood) + Tue Dec 10 00:49:35 2002 Kristian Rietveld * gdk/gdkpixmap.h (gdk_pixmap_new), (gdk_bitmap_create_from_data), @@ -2978,7 +2985,7 @@ Fri Sep 27 16:15:11 2002 Owen Taylor * gtk/gtknotebook.c (gtk_notebook_get_event_window_position): Handle the case where the first page isn't visible. - (#90336, bug tracked down by Chema Celorio) + (#81600, bug tracked down by Chema Celorio) Fri Sep 27 15:57:15 2002 Owen Taylor diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 28ee442c8..e23c5a01a 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,10 @@ +Mon Dec 9 18:50:31 2002 Owen Taylor + + * gdk/x11/gdkinput-x11.c (_gdk_input_common_find_events): + Remove selection for DeviceButtonRelease, we no longer need + it now that gxi is gone. (#32617, reported by Garry + Osgood) + Tue Dec 10 00:49:35 2002 Kristian Rietveld * gdk/gdkpixmap.h (gdk_pixmap_new), (gdk_bitmap_create_from_data), @@ -2978,7 +2985,7 @@ Fri Sep 27 16:15:11 2002 Owen Taylor * gtk/gtknotebook.c (gtk_notebook_get_event_window_position): Handle the case where the first page isn't visible. - (#90336, bug tracked down by Chema Celorio) + (#81600, bug tracked down by Chema Celorio) Fri Sep 27 15:57:15 2002 Owen Taylor diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2 index 28ee442c8..e23c5a01a 100644 --- a/ChangeLog.pre-2-2 +++ b/ChangeLog.pre-2-2 @@ -1,3 +1,10 @@ +Mon Dec 9 18:50:31 2002 Owen Taylor + + * gdk/x11/gdkinput-x11.c (_gdk_input_common_find_events): + Remove selection for DeviceButtonRelease, we no longer need + it now that gxi is gone. (#32617, reported by Garry + Osgood) + Tue Dec 10 00:49:35 2002 Kristian Rietveld * gdk/gdkpixmap.h (gdk_pixmap_new), (gdk_bitmap_create_from_data), @@ -2978,7 +2985,7 @@ Fri Sep 27 16:15:11 2002 Owen Taylor * gtk/gtknotebook.c (gtk_notebook_get_event_window_position): Handle the case where the first page isn't visible. - (#90336, bug tracked down by Chema Celorio) + (#81600, bug tracked down by Chema Celorio) Fri Sep 27 15:57:15 2002 Owen Taylor diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4 index 28ee442c8..e23c5a01a 100644 --- a/ChangeLog.pre-2-4 +++ b/ChangeLog.pre-2-4 @@ -1,3 +1,10 @@ +Mon Dec 9 18:50:31 2002 Owen Taylor + + * gdk/x11/gdkinput-x11.c (_gdk_input_common_find_events): + Remove selection for DeviceButtonRelease, we no longer need + it now that gxi is gone. (#32617, reported by Garry + Osgood) + Tue Dec 10 00:49:35 2002 Kristian Rietveld * gdk/gdkpixmap.h (gdk_pixmap_new), (gdk_bitmap_create_from_data), @@ -2978,7 +2985,7 @@ Fri Sep 27 16:15:11 2002 Owen Taylor * gtk/gtknotebook.c (gtk_notebook_get_event_window_position): Handle the case where the first page isn't visible. - (#90336, bug tracked down by Chema Celorio) + (#81600, bug tracked down by Chema Celorio) Fri Sep 27 15:57:15 2002 Owen Taylor diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6 index 28ee442c8..e23c5a01a 100644 --- a/ChangeLog.pre-2-6 +++ b/ChangeLog.pre-2-6 @@ -1,3 +1,10 @@ +Mon Dec 9 18:50:31 2002 Owen Taylor + + * gdk/x11/gdkinput-x11.c (_gdk_input_common_find_events): + Remove selection for DeviceButtonRelease, we no longer need + it now that gxi is gone. (#32617, reported by Garry + Osgood) + Tue Dec 10 00:49:35 2002 Kristian Rietveld * gdk/gdkpixmap.h (gdk_pixmap_new), (gdk_bitmap_create_from_data), @@ -2978,7 +2985,7 @@ Fri Sep 27 16:15:11 2002 Owen Taylor * gtk/gtknotebook.c (gtk_notebook_get_event_window_position): Handle the case where the first page isn't visible. - (#90336, bug tracked down by Chema Celorio) + (#81600, bug tracked down by Chema Celorio) Fri Sep 27 15:57:15 2002 Owen Taylor diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8 index 28ee442c8..e23c5a01a 100644 --- a/ChangeLog.pre-2-8 +++ b/ChangeLog.pre-2-8 @@ -1,3 +1,10 @@ +Mon Dec 9 18:50:31 2002 Owen Taylor + + * gdk/x11/gdkinput-x11.c (_gdk_input_common_find_events): + Remove selection for DeviceButtonRelease, we no longer need + it now that gxi is gone. (#32617, reported by Garry + Osgood) + Tue Dec 10 00:49:35 2002 Kristian Rietveld * gdk/gdkpixmap.h (gdk_pixmap_new), (gdk_bitmap_create_from_data), @@ -2978,7 +2985,7 @@ Fri Sep 27 16:15:11 2002 Owen Taylor * gtk/gtknotebook.c (gtk_notebook_get_event_window_position): Handle the case where the first page isn't visible. - (#90336, bug tracked down by Chema Celorio) + (#81600, bug tracked down by Chema Celorio) Fri Sep 27 15:57:15 2002 Owen Taylor diff --git a/gdk/x11/gdkinput-x11.c b/gdk/x11/gdkinput-x11.c index db716fa9f..b53e5cc7a 100644 --- a/gdk/x11/gdkinput-x11.c +++ b/gdk/x11/gdkinput-x11.c @@ -267,9 +267,6 @@ _gdk_input_common_find_events(GdkWindow *window, XEventClass class; i = 0; - /* We have to track press and release events in pairs to keep - track of button state correctly and implement grabbing for - the gxi support. FIXME - is this needed any more since gxi is gone? */ if (mask & GDK_BUTTON_PRESS_MASK || mask & GDK_BUTTON_RELEASE_MASK) { DeviceButtonPress (gdkdev->xdevice, gdkdev->buttonpress_type, @@ -279,10 +276,6 @@ _gdk_input_common_find_events(GdkWindow *window, DeviceButtonPressGrab (gdkdev->xdevice, 0, class); if (class != 0) classes[i++] = class; - DeviceButtonRelease (gdkdev->xdevice, gdkdev->buttonrelease_type, - class); - if (class != 0) - classes[i++] = class; } if (mask & GDK_POINTER_MOTION_MASK) { -- 2.43.2