Add connection timeout handling

[~andy/spades] / src / org / pileus / spades / Client.java

diff --git a/src/org/pileus/spades/Client.java b/src/org/pileus/spades/Client.java
index f1657840c02924a06864a4b85e9ba885f4b69e72..e02e664fe7bb64921bc3fff62631bb4a27646f4e 100644 (file)
--- a/src/org/pileus/spades/Client.java
+++ b/src/org/pileus/spades/Client.java
@@ -5,9 +5,18 @@ import java.net.*;
 
 public class Client
 {
+       /* Constnats */
+       enum State {
+               INIT,
+               SETUP,
+               READY,
+               ABORT,
+       };
+
        /* Preference data */
        public  String         server   = "irc.freenode.net";
        public  int            port     = 6667;
+       public  int            timeout  = 240;
        public  String         nickname = "SpadeGuest";
        public  String         channel  = "#rhnoise";
        public  boolean        usesasl  = false;
@@ -17,10 +26,11 @@ public class Client
        public  String         hostname = "localhost";
 
        /* Public data */
-       public  boolean        ready    = false;
+       public  State          state    = State.INIT;
        public  String         name     = "";
 
-               /* Connection data */
+       /* Connection data */
+       private boolean        pinging;
        private Socket         socket;
        private BufferedReader input;
        private PrintWriter    output;
@@ -59,7 +69,10 @@ public class Client
                Os.debug("Client: connect");
 
                try {
-                       this.socket = new Socket(this.server, this.port);
+                       this.state  = State.SETUP;
+                       this.socket = new Socket();
+                       this.socket.setSoTimeout(this.timeout/2 * 1000);
+                       this.socket.connect(new InetSocketAddress(this.server, this.port));
                        this.input  = new BufferedReader(new InputStreamReader(this.socket.getInputStream()));
                        this.output = new PrintWriter(this.socket.getOutputStream());
                } catch (Exception e) {
@@ -76,22 +89,25 @@ public class Client
                return true;
        }
 
-       public boolean abort()
+       public void abort()
        {
                Os.debug("Client: abort");
-               try {
-                       this.socket.close();
-                       this.ready = false;
-                       return true;
-               } catch (Exception e) {
-                       Os.debug("Client: error closing socket", e);
-                       return false;
-               }
+               this.state = State.ABORT;
+               this.validate();
+       }
+
+       public void reset()
+       {
+               Os.debug("Client: reset");
+               this.state = State.INIT;
        }
 
        public void raw(String line)
        {
                try {
+                       if (this.validate() != State.SETUP &&
+                           this.validate() != State.READY)
+                               return;
                        Os.debug("< " + line);
                        this.output.println(line);
                        this.output.flush();
@@ -102,7 +118,7 @@ public class Client
 
        public Message send(String txt)
        {
-               if (!this.ready)
+               if (this.validate() != State.READY)
                        return null;
                Message msg = new Message(this.channel, this.name, txt);
                if (msg.type == Message.Type.JOIN)
@@ -113,8 +129,11 @@ public class Client
 
        public Message recv()
        {
-               try {
-                       String line = input.readLine();
+               while (true) try {
+                       if (this.validate() != State.SETUP &&
+                           this.validate() != State.READY)
+                               return null;
+                       String line = this.input.readLine();
                        if (line == null)
                                return null;
                        Os.debug("> " + line);
@@ -123,23 +142,50 @@ public class Client
                        if (this.usesasl)
                                this.dosasl(msg);
                        return msg;
-               } catch (SocketException e) {
-                       this.ready = false;
+               }
+               catch (SocketTimeoutException e) {
+                       if (this.pinging) {
+                               this.abort();
+                               return null;
+                       } else {
+                               this.pinging = true;
+                               this.raw("PING :" + hostname);
+                               continue;
+                       }
+               }
+               catch (SocketException e) {
+                       this.state = State.INIT;
                        return null;
-               } catch (Exception e) {
-                       this.ready = false;
+               }
+               catch (Exception e) {
+                       this.state = State.INIT;
                        Os.debug("Client: error in recv", e);
                        return null;
                }
        }
 
        /* Private methods */
+       private State validate()
+       {
+               try {
+                       if (this.state == State.ABORT) {
+                               if (this.socket != null) {
+                                       this.socket.close();
+                                       this.state = State.INIT;
+                               }
+                       }
+               } catch (Exception e) {
+                       Os.debug("Client: error closing socket", e);
+               }
+               return this.state;
+       }
+
        private void process(Message msg)
        {
                if (msg.cmd.equals("001") && msg.msg.matches("Welcome.*")) {
                        this.raw("JOIN "  + this.channel);
                        this.raw("TOPIC " + this.channel);
-                       this.ready = true;
+                       this.state = State.READY;
                }
                if (msg.cmd.equals("433")) {
                        this.name   = this.nickname + this.mangle;
@@ -147,7 +193,10 @@ public class Client
                        this.raw("NICK "  + this.name);
                }
                if (msg.cmd.equals("PING")) {
-                       this.raw("PING " + msg.msg);
+                       this.raw("PONG " + msg.msg);
+               }
+               if (msg.cmd.equals("PONG")) {
+                       this.pinging = false;
                }
        }