]> Pileus Git - ~andy/linux/commitdiff
macvtap: fix uninitialized return value macvtap_ioctl_set_queue()
authorJason Wang <jasowang@redhat.com>
Thu, 13 Jun 2013 06:23:36 +0000 (14:23 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Jun 2013 08:23:11 +0000 (01:23 -0700)
Return -EINVAL on illegal flag instead of uninitialized value. This fixes the
kbuild test warning.

Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/macvtap.c

index edcbf1c0d6ed1f8fe9c3c1e70ff76e74036ed9b6..5a76f20776af7d67fb53851698db9d5eae8b7665 100644 (file)
@@ -969,6 +969,8 @@ static int macvtap_ioctl_set_queue(struct file *file, unsigned int flags)
                ret = macvtap_enable_queue(vlan->dev, file, q);
        else if (flags & IFF_DETACH_QUEUE)
                ret = macvtap_disable_queue(q);
+       else
+               ret = -EINVAL;
 
        macvtap_put_vlan(vlan);
        return ret;