]> Pileus Git - ~andy/linux/commitdiff
ASoC: ux500: Don't set unused struct snd_pcm_hardware fields
authorLars-Peter Clausen <lars@metafoo.de>
Mon, 6 Jan 2014 13:19:15 +0000 (14:19 +0100)
committerMark Brown <broonie@linaro.org>
Thu, 9 Jan 2014 14:30:27 +0000 (14:30 +0000)
The ASoC core assumes that the PCM component of the ASoC card transparently
moves data around and does not impose any restrictions on the memory layout or
the transfer speed. It ignores all fields from the snd_pcm_hardware struct for
the PCM driver that are related to this. Setting these fields in the PCM driver
might suggest otherwise though, so rather not set them.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/ux500/ux500_pcm.c

index 55a8634cc3daf60584e99fc7ebfbbcca31dd6536..51a66a87305ae0ad96b26206108f13bcec5a189f 100644 (file)
 #include "ux500_msp_i2s.h"
 #include "ux500_pcm.h"
 
-#define UX500_PLATFORM_MIN_RATE 8000
-#define UX500_PLATFORM_MAX_RATE 48000
-
-#define UX500_PLATFORM_MIN_CHANNELS 1
-#define UX500_PLATFORM_MAX_CHANNELS 8
-
 #define UX500_PLATFORM_PERIODS_BYTES_MIN       128
 #define UX500_PLATFORM_PERIODS_BYTES_MAX       (64 * PAGE_SIZE)
 #define UX500_PLATFORM_PERIODS_MIN             2
@@ -45,15 +39,6 @@ static const struct snd_pcm_hardware ux500_pcm_hw = {
                SNDRV_PCM_INFO_MMAP |
                SNDRV_PCM_INFO_RESUME |
                SNDRV_PCM_INFO_PAUSE,
-       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-               SNDRV_PCM_FMTBIT_U16_LE |
-               SNDRV_PCM_FMTBIT_S16_BE |
-               SNDRV_PCM_FMTBIT_U16_BE,
-       .rates = SNDRV_PCM_RATE_KNOT,
-       .rate_min = UX500_PLATFORM_MIN_RATE,
-       .rate_max = UX500_PLATFORM_MAX_RATE,
-       .channels_min = UX500_PLATFORM_MIN_CHANNELS,
-       .channels_max = UX500_PLATFORM_MAX_CHANNELS,
        .buffer_bytes_max = UX500_PLATFORM_BUFFER_BYTES_MAX,
        .period_bytes_min = UX500_PLATFORM_PERIODS_BYTES_MIN,
        .period_bytes_max = UX500_PLATFORM_PERIODS_BYTES_MAX,