mtip32xx: fix two smatch warnings

Dan reports:

New smatch warnings:
drivers/block/mtip32xx/mtip32xx.c:2728 show_device_status() warn: variable dereferenced before check 'dd' (see line 2727)
drivers/block/mtip32xx/mtip32xx.c:2758 show_device_status() warn: variable dereferenced before check 'dd' (see line 2757)

which are checking if dd == NULL, in a list_for_each_entry() type loop.
Get rid of the check, dd can never be NULL here.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 8517af8c0fcb63bf86c256710f26503d27e1b25c..32c678028e53c36ec8a52183799ad97642c666e8 100644 (file)
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -2725,7 +2725,7 @@ static ssize_t show_device_status(struct device_driver *drv, char *buf)
        spin_lock_irqsave(&dev_lock, flags);
        size += sprintf(&buf[size], "Devices Present:\n");
        list_for_each_entry_safe(dd, tmp, &online_list, online_list) {
-               if (dd && dd->pdev) {
+               if (dd->pdev) {
                        if (dd->port &&
                            dd->port->identify &&
                            dd->port->identify_valid) {
@@ -2755,7 +2755,7 @@ static ssize_t show_device_status(struct device_driver *drv, char *buf)
 
        size += sprintf(&buf[size], "Devices Being Removed:\n");
        list_for_each_entry_safe(dd, tmp, &removing_list, remove_list) {
-               if (dd && dd->pdev) {
+               if (dd->pdev) {
                        if (dd->port &&
                            dd->port->identify &&
                            dd->port->identify_valid) {