]> Pileus Git - ~andy/linux/commitdiff
netlink: Fix skb ref counting.
authorPravin B Shelar <pshelar@nicira.com>
Mon, 29 Apr 2013 20:52:01 +0000 (20:52 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 May 2013 18:57:03 +0000 (14:57 -0400)
Commit f9c2288837ba072b21dba955f04a4c97eaa77b1e (netlink:
implement memory mapped recvmsg) increamented skb->users
ref count twice for a dump op which does not look right.

Following patch fixes that.

CC: Patrick McHardy <kaber@trash.net>
Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlink/af_netlink.c

index d9c7869312c17b1896b4955682d78b640eabcb22..12ac6b47a35c45fe0abb5fce87ef07dfdf1ba1f7 100644 (file)
@@ -2504,7 +2504,6 @@ int __netlink_dump_start(struct sock *ssk, struct sk_buff *skb,
        cb->data = control->data;
        cb->module = control->module;
        cb->min_dump_alloc = control->min_dump_alloc;
-       atomic_inc(&skb->users);
        cb->skb = skb;
 
        sk = netlink_lookup(sock_net(ssk), ssk->sk_protocol, NETLINK_CB(skb).portid);