]> Pileus Git - ~andy/linux/commitdiff
tracing/uprobes: Pass 'is_return' to traceprobe_parse_probe_arg()
authorNamhyung Kim <namhyung.kim@lge.com>
Wed, 27 Nov 2013 02:36:47 +0000 (11:36 +0900)
committerSteven Rostedt <rostedt@goodmis.org>
Thu, 2 Jan 2014 21:17:43 +0000 (16:17 -0500)
Currently uprobes don't pass is_return to the argument parser so that
it cannot make use of "$retval" fetch method since it only works for
return probes.

Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
kernel/trace/trace_uprobe.c

index bebd2f5d9ea3d2d63fea802fd26ee47d6ce2f201..8bfd29a8d71321b2c9e1ff27fd65ee200cf16bb6 100644 (file)
@@ -514,7 +514,7 @@ static int create_trace_uprobe(int argc, char **argv)
 
                /* Parse fetch argument */
                ret = traceprobe_parse_probe_arg(arg, &tu->tp.size, parg,
-                                                false, false);
+                                                is_return, false);
                if (ret) {
                        pr_info("Parse error at argument[%d]. (%d)\n", i, ret);
                        goto error;