]> Pileus Git - ~andy/linux/commitdiff
[media] media/radio: use v4l2_ctrl_subscribe_event where possible
authorHans de Goede <hdegoede@redhat.com>
Sun, 8 Apr 2012 15:59:45 +0000 (12:59 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 7 May 2012 19:26:32 +0000 (16:26 -0300)
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/radio/radio-isa.c
drivers/media/radio/radio-keene.c

index c7450fb90d2be8298e604511afac28f1d5f2bb1f..3c0067de4324281537d951cf8e216eae140c04db 100644 (file)
@@ -150,14 +150,6 @@ static int radio_isa_log_status(struct file *file, void *priv)
        return 0;
 }
 
-static int radio_isa_subscribe_event(struct v4l2_fh *fh,
-                               struct v4l2_event_subscription *sub)
-{
-       if (sub->type == V4L2_EVENT_CTRL)
-               return v4l2_event_subscribe(fh, sub, 0);
-       return -EINVAL;
-}
-
 static const struct v4l2_ctrl_ops radio_isa_ctrl_ops = {
        .s_ctrl = radio_isa_s_ctrl,
 };
@@ -177,7 +169,7 @@ static const struct v4l2_ioctl_ops radio_isa_ioctl_ops = {
        .vidioc_g_frequency = radio_isa_g_frequency,
        .vidioc_s_frequency = radio_isa_s_frequency,
        .vidioc_log_status  = radio_isa_log_status,
-       .vidioc_subscribe_event   = radio_isa_subscribe_event,
+       .vidioc_subscribe_event   = v4l2_ctrl_subscribe_event,
        .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
 };
 
index 62d32c4946f71b7939ebb7e01ed2c31f038948f9..79adf3e654e5f57d678199539be2c153daf40265 100644 (file)
@@ -271,18 +271,6 @@ static int keene_s_ctrl(struct v4l2_ctrl *ctrl)
        return -EINVAL;
 }
 
-static int vidioc_subscribe_event(struct v4l2_fh *fh,
-                               struct v4l2_event_subscription *sub)
-{
-       switch (sub->type) {
-       case V4L2_EVENT_CTRL:
-               return v4l2_event_subscribe(fh, sub, 0);
-       default:
-               return -EINVAL;
-       }
-}
-
-
 /* File system interface */
 static const struct v4l2_file_operations usb_keene_fops = {
        .owner          = THIS_MODULE,
@@ -303,7 +291,7 @@ static const struct v4l2_ioctl_ops usb_keene_ioctl_ops = {
        .vidioc_g_frequency = vidioc_g_frequency,
        .vidioc_s_frequency = vidioc_s_frequency,
        .vidioc_log_status = v4l2_ctrl_log_status,
-       .vidioc_subscribe_event = vidioc_subscribe_event,
+       .vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
        .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
 };