]> Pileus Git - ~andy/linux/commitdiff
net: sock: fix TCP_SKB_MIN_TRUESIZE
authorEric Dumazet <edumazet@google.com>
Wed, 3 Jul 2013 12:02:22 +0000 (05:02 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 3 Jul 2013 23:52:10 +0000 (16:52 -0700)
commit eea86af6b1e18d ("net: sock: adapt SOCK_MIN_RCVBUF and
SOCK_MIN_SNDBUF") forgot the sk_buff alignment taken into account
in __alloc_skb() : skb->truesize = SKB_TRUESIZE(size);

While above commit fixed the sender issue, the receiver is still
dropping the second packet (on loopback device), because the receiver
socket can not really hold two skbs :
First packet truesize already is above sk_rcvbuf, so even TCP coalescing
cannot help.

On a typical 64bit build, each tcp skb truesize is 2304, instead of 2272

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Daniel Borkmann <dborkman@redhat.com>
Cc: Neal Cardwell <ncardwell@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Tested-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/sock.h

index ea6206ccc8967421b7156e04a30c5d293ba2bcce..95a5a2c6925ab0745b563f7f04663721465460e7 100644 (file)
@@ -2052,7 +2052,7 @@ static inline void sk_wake_async(struct sock *sk, int how, int band)
  * Note: for send buffers, TCP works better if we can build two skbs at
  * minimum.
  */
-#define TCP_SKB_MIN_TRUESIZE   (2048 + sizeof(struct sk_buff))
+#define TCP_SKB_MIN_TRUESIZE   (2048 + SKB_DATA_ALIGN(sizeof(struct sk_buff)))
 
 #define SOCK_MIN_SNDBUF                (TCP_SKB_MIN_TRUESIZE * 2)
 #define SOCK_MIN_RCVBUF                 TCP_SKB_MIN_TRUESIZE