]> Pileus Git - ~andy/linux/commitdiff
powerpc/cell/spufs: Fix status attribute permission
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Mon, 6 May 2013 02:02:05 +0000 (12:02 +1000)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Mon, 6 May 2013 02:02:05 +0000 (12:02 +1000)
We are registering the attribute with permission 0644 but it
doesn't have a store callback, which causes WARN_ON's during
boot. Fix the permission.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/platforms/cell/spu_base.c

index 8b1213993b10ac581905edfefc0cbebe4cc5f435..f85db3a69b4a0fdc73c882d6218b3e9bd45b7307 100644 (file)
@@ -715,7 +715,7 @@ static ssize_t spu_stat_show(struct device *dev,
                spu->stats.libassist);
 }
 
-static DEVICE_ATTR(stat, 0644, spu_stat_show, NULL);
+static DEVICE_ATTR(stat, 0444, spu_stat_show, NULL);
 
 #ifdef CONFIG_KEXEC