]> Pileus Git - ~andy/linux/commitdiff
Input: tca8418_keypad - increase severity of failures in probe()
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 14 Nov 2012 16:20:21 +0000 (08:20 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 29 Nov 2012 17:30:36 +0000 (09:30 -0800)
Failures to build a keymap, request an IRQ, or register input device are
fatal for the driver, therefore the messages should have "error" severity
instead of "debug".

Reviewed-by: Alban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/tca8418_keypad.c

index 9084327efb3ad07507c3dc28c265fe6fed0d997f..8fcce37b089becc3a298ea69d2f474bdbdfa0e0a 100644 (file)
@@ -348,7 +348,7 @@ static int tca8418_keypad_probe(struct i2c_client *client,
        error = matrix_keypad_build_keymap(keymap_data, NULL, rows, cols,
                                           keypad_data->keymap, input);
        if (error) {
-               dev_dbg(dev, "Failed to build keymap\n");
+               dev_err(dev, "Failed to build keymap\n");
                goto fail2;
        }
 
@@ -367,14 +367,14 @@ static int tca8418_keypad_probe(struct i2c_client *client,
                                     IRQF_ONESHOT,
                                     client->name, keypad_data);
        if (error) {
-               dev_dbg(dev, "Unable to claim irq %d; error %d\n",
+               dev_err(dev, "Unable to claim irq %d; error %d\n",
                        client->irq, error);
                goto fail2;
        }
 
        error = input_register_device(input);
        if (error) {
-               dev_dbg(dev, "Unable to register input device, error: %d\n",
+               dev_err(dev, "Unable to register input device, error: %d\n",
                        error);
                goto fail3;
        }