]> Pileus Git - ~andy/linux/commitdiff
timekeeping: Cast raw_interval to u64 to avoid shift overflow
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 9 Oct 2012 07:18:23 +0000 (10:18 +0300)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 9 Oct 2012 19:27:14 +0000 (21:27 +0200)
We fixed a bunch of integer overflows in timekeeping code during the 3.6
cycle.  I did an audit based on that and found this potential overflow.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: John Stultz <johnstul@us.ibm.com>
Link: http://lkml.kernel.org/r/20121009071823.GA19159@elgon.mountain
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
kernel/time/timekeeping.c

index 16280ff3cf82933015bebc248af1288ad8b53d10..3eb3fc7c1600abfb3c3778170b97a9ad9e70564d 100644 (file)
@@ -1045,7 +1045,7 @@ static cycle_t logarithmic_accumulation(struct timekeeper *tk, cycle_t offset,
        accumulate_nsecs_to_secs(tk);
 
        /* Accumulate raw time */
-       raw_nsecs = tk->raw_interval << shift;
+       raw_nsecs = (u64)tk->raw_interval << shift;
        raw_nsecs += tk->raw_time.tv_nsec;
        if (raw_nsecs >= NSEC_PER_SEC) {
                u64 raw_secs = raw_nsecs;