]> Pileus Git - ~andy/linux/commitdiff
Input: gpio_keys - switch to using gpio_request_one()
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 29 Nov 2012 17:00:19 +0000 (09:00 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 4 Dec 2012 05:25:06 +0000 (21:25 -0800)
This saves us a few lines of code.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/gpio_keys.c

index 79435de0caa85689d2cd14686aa81540667c5746..d327f5a2bb0eadb3884c9dc42ce518cd29be2ebd 100644 (file)
@@ -440,21 +440,13 @@ static int gpio_keys_setup_key(struct platform_device *pdev,
 
        if (gpio_is_valid(button->gpio)) {
 
-               error = gpio_request(button->gpio, desc);
+               error = gpio_request_one(button->gpio, GPIOF_IN, desc);
                if (error < 0) {
                        dev_err(dev, "Failed to request GPIO %d, error %d\n",
                                button->gpio, error);
                        return error;
                }
 
-               error = gpio_direction_input(button->gpio);
-               if (error < 0) {
-                       dev_err(dev,
-                               "Failed to configure direction for GPIO %d, error %d\n",
-                               button->gpio, error);
-                       goto fail;
-               }
-
                if (button->debounce_interval) {
                        error = gpio_set_debounce(button->gpio,
                                        button->debounce_interval * 1000);