]> Pileus Git - ~andy/linux/commitdiff
ASoC: mmp: Don't set unused struct snd_pcm_hardware fields
authorLars-Peter Clausen <lars@metafoo.de>
Fri, 20 Dec 2013 13:20:18 +0000 (14:20 +0100)
committerMark Brown <broonie@linaro.org>
Mon, 30 Dec 2013 13:58:53 +0000 (13:58 +0000)
The ASoC core assumes that the PCM component of the ASoC card transparently
moves data around and does not impose any restrictions on the memory layout or
the transfer speed. It ignores all fields from the snd_pcm_hardware struct for
the PCM driver that are related to this. Setting these fields in the PCM driver
might suggest otherwise though, so rather not set them.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/pxa/mmp-pcm.c

index 682ee52942bfa6532775a5021e172403a929f4c5..5e8d813301731f6b99a56228efafa81dfa78126e 100644 (file)
@@ -36,14 +36,9 @@ struct mmp_dma_data {
                SNDRV_PCM_INFO_PAUSE |          \
                SNDRV_PCM_INFO_RESUME)
 
-#define MMP_PCM_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | \
-                        SNDRV_PCM_FMTBIT_S24_LE | \
-                        SNDRV_PCM_FMTBIT_S32_LE)
-
 static struct snd_pcm_hardware mmp_pcm_hardware[] = {
        {
                .info                   = MMP_PCM_INFO,
-               .formats                = MMP_PCM_FORMATS,
                .period_bytes_min       = 1024,
                .period_bytes_max       = 2048,
                .periods_min            = 2,
@@ -53,7 +48,6 @@ static struct snd_pcm_hardware mmp_pcm_hardware[] = {
        },
        {
                .info                   = MMP_PCM_INFO,
-               .formats                = MMP_PCM_FORMATS,
                .period_bytes_min       = 1024,
                .period_bytes_max       = 2048,
                .periods_min            = 2,