]> Pileus Git - ~andy/linux/commitdiff
myri10ge: fix incorrect use of ntohs()
authorAndrew Gallatin <gallatin@myri.com>
Fri, 30 Nov 2012 12:31:26 +0000 (12:31 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 1 Dec 2012 16:36:37 +0000 (11:36 -0500)
1b4c44e6369dbbafd113f1e00b406f1eda5ab5b2 incorrectly used
ntohs() rather than htons() in myri10ge_vlan_rx().

Thanks to Fengguang Wu, Yuanhan Liu's kernel-build tester
for pointing out this bug.

Signed-off-by: Andrew Gallatin <gallatin@myri.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/myricom/myri10ge/myri10ge.c

index 2fc984a037715b4ebaececeda3b4c2e5df9dfdb6..a40234ea2fbb3274d95f6511f0b9547cf750e027 100644 (file)
@@ -1283,7 +1283,7 @@ myri10ge_vlan_rx(struct net_device *dev, void *addr, struct sk_buff *skb)
        va += MXGEFW_PAD;
        veh = (struct vlan_ethhdr *)va;
        if ((dev->features & NETIF_F_HW_VLAN_RX) == NETIF_F_HW_VLAN_RX &&
-           veh->h_vlan_proto == ntohs(ETH_P_8021Q)) {
+           veh->h_vlan_proto == htons(ETH_P_8021Q)) {
                /* fixup csum if needed */
                if (skb->ip_summed == CHECKSUM_COMPLETE) {
                        vsum = csum_partial(va + ETH_HLEN, VLAN_HLEN, 0);