]> Pileus Git - ~andy/linux/commitdiff
[media] drivers/media/usb/hdpvr/hdpvr-core.c: fix error return code
authorPeter Senna Tschudin <peter.senna@gmail.com>
Thu, 6 Sep 2012 14:23:48 +0000 (11:23 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 22 Nov 2012 16:22:31 +0000 (14:22 -0200)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/usb/hdpvr/hdpvr-core.c

index 304f43ef59eb16a8778d2adbc43baf4743187a9b..84dc26fe80eed741866e2aaece3aa77f60414986 100644 (file)
@@ -401,12 +401,14 @@ static int hdpvr_probe(struct usb_interface *interface,
        client = hdpvr_register_ir_rx_i2c(dev);
        if (!client) {
                v4l2_err(&dev->v4l2_dev, "i2c IR RX device register failed\n");
+               retval = -ENODEV;
                goto reg_fail;
        }
 
        client = hdpvr_register_ir_tx_i2c(dev);
        if (!client) {
                v4l2_err(&dev->v4l2_dev, "i2c IR TX device register failed\n");
+               retval = -ENODEV;
                goto reg_fail;
        }
 #endif