]> Pileus Git - ~andy/linux/commitdiff
audit: do not needlessly take a spinlock in copy_signal
authorEric Paris <eparis@redhat.com>
Tue, 30 Apr 2013 14:43:10 +0000 (10:43 -0400)
committerEric Paris <eparis@redhat.com>
Tue, 30 Apr 2013 19:31:28 +0000 (15:31 -0400)
current->signal->audit_* can only change from a netlink message from
current.  Obviously in this case we cannot be handling a netlink message
from current.  So there is no change these can change under us.  No need
to take a lock to read them.

Signed-off-by: Eric Paris <eparis@redhat.com>
drivers/tty/tty_audit.c

index 5f3868202183f8fd76870447cfc73f4039455b76..a03a75163f02efc650be4a7031c72543cb1c67c3 100644 (file)
@@ -134,12 +134,8 @@ void tty_audit_exit(void)
  */
 void tty_audit_fork(struct signal_struct *sig)
 {
-       unsigned long flags;
-
-       spin_lock_irqsave(&current->sighand->siglock, flags);
        sig->audit_tty = current->signal->audit_tty;
        sig->audit_tty_log_passwd = current->signal->audit_tty_log_passwd;
-       spin_unlock_irqrestore(&current->sighand->siglock, flags);
 }
 
 /**