]> Pileus Git - ~andy/linux/commitdiff
audit: reorder AUDIT_TTY_SET arguments
authorEric Paris <eparis@redhat.com>
Tue, 14 Jan 2014 02:16:59 +0000 (21:16 -0500)
committerEric Paris <eparis@redhat.com>
Tue, 14 Jan 2014 03:33:41 +0000 (22:33 -0500)
An admin is likely to want to see old and new values next to each other.
Putting all of the old values followed by all of the new values is just
hard to read as a human.

Signed-off-by: Eric Paris <eparis@redhat.com>
kernel/audit.c

index b1d24a035ec998c24f27ac192c5a448823fd65a3..9daf24361d5301f967391f3da82482da70a45726 100644 (file)
@@ -1010,13 +1010,10 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
                spin_unlock(&tsk->sighand->siglock);
 
                audit_log_common_recv_msg(&ab, AUDIT_CONFIG_CHANGE);
-               audit_log_format(ab, " op=tty_set"
-                                " old-enabled=%d old-log_passwd=%d"
-                                " new-enabled=%d new-log_passwd=%d"
-                                " res=%d",
-                                old.enabled, old.log_passwd,
-                                s.enabled, s.log_passwd,
-                                !err);
+               audit_log_format(ab, " op=tty_set old-enabled=%d new-enabled=%d"
+                                " old-log_passwd=%d new-log_passwd=%d res=%d",
+                                old.enabled, s.enabled, old.log_passwd,
+                                s.log_passwd, !err);
                audit_log_end(ab);
                break;
        }