]> Pileus Git - ~andy/linux/commitdiff
vmxnet3: fix building without CONFIG_PCI_MSI
authorArnd Bergmann <arnd@arndb.de>
Thu, 13 Mar 2014 09:44:34 +0000 (10:44 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Mar 2014 16:56:38 +0000 (12:56 -0400)
Since commit d25f06ea466e "vmxnet3: fix netpoll race condition",
the vmxnet3 driver fails to build when CONFIG_PCI_MSI is disabled,
because it unconditionally references the vmxnet3_msix_rx()
function.

To fix this, use the same #ifdef in the caller that exists around
the function definition.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Neil Horman <nhorman@tuxdriver.com>
Cc: Shreyas Bhatewara <sbhatewara@vmware.com>
Cc: "VMware, Inc." <pv-drivers@vmware.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: stable@vger.kernel.org
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vmxnet3/vmxnet3_drv.c

index b7daa02ff0263ac3ec46106732954726c45d6952..0fa3b44f7342dc0cf979cf69b6b1d6c3444411f3 100644 (file)
@@ -1761,13 +1761,16 @@ static void
 vmxnet3_netpoll(struct net_device *netdev)
 {
        struct vmxnet3_adapter *adapter = netdev_priv(netdev);
-       int i;
 
        switch (adapter->intr.type) {
-       case VMXNET3_IT_MSIX:
+#ifdef CONFIG_PCI_MSI
+       case VMXNET3_IT_MSIX: {
+               int i;
                for (i = 0; i < adapter->num_rx_queues; i++)
                        vmxnet3_msix_rx(0, &adapter->rx_queue[i]);
                break;
+       }
+#endif
        case VMXNET3_IT_MSI:
        default:
                vmxnet3_intr(0, adapter->netdev);