Bug 553241 – double freed pointer in lpr_write cause firefox3 crash

2008-09-25  Marek Kasik  <mkasik@redhat.com>

	Bug 553241 – double freed pointer in lpr_write cause firefox3 crash

	* modules/printbackends/lpr/gtkprintbackendlpr.c:
	The redundant freeing of memory was removed.

	Patch by Chris Wang

svn path=/trunk/; revision=21516

diff --git a/ChangeLog b/ChangeLog
index 76b9631e11040ec3682a713e9a28e2b3abe5dc51..d5822776618a1c636b88987ff0a85158850a16ae 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2008-09-25  Marek Kasik  <mkasik@redhat.com>
+
+       Bug 553241 – double freed pointer in lpr_write cause firefox3 crash
+
+       * modules/printbackends/lpr/gtkprintbackendlpr.c:
+       The redundant freeing of memory was removed.
+
+       Patch by Chris Wang
+
 2008-09-25  Michael Natterer  <mitch@imendio.com>
 
        * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_finalize):

diff --git a/modules/printbackends/lpr/gtkprintbackendlpr.c b/modules/printbackends/lpr/gtkprintbackendlpr.c
index fd5952d5d1fb2be4b4cac2d253551c92d91f7c19..b5826fdcf21d37652cacbc0d62c6944d2678c736 100644 (file)
--- a/modules/printbackends/lpr/gtkprintbackendlpr.c
+++ b/modules/printbackends/lpr/gtkprintbackendlpr.c
@@ -289,8 +289,6 @@ lpr_write (GIOChannel   *source,
       lpr_print_cb (GTK_PRINT_BACKEND_LPR (ps->backend), 
                    error, user_data);
 
-      if (error)
-       g_error_free (error);
 
       if (error != NULL)
         {