Add some docs to the row-deleted signal. (#349128, Benedikt Meurer)

2006-08-16  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtktreemodel.c (gtk_tree_model_base_init): Add some
	docs to the row-deleted signal.  (#349128, Benedikt Meurer)

diff --git a/ChangeLog b/ChangeLog
index 145304e74e4705d21c0cea0bcb0a62f5b1fcd8cd..fde6f3630d5f285faa0c4e9539b25d3f698ee530 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2006-08-16  Matthias Clasen  <mclasen@redhat.com>
 
+       * gtk/gtktreemodel.c (gtk_tree_model_base_init): Add some
+       docs to the row-deleted signal.  (#349128, Benedikt Meurer)
+
        * gtk/gtkiconview.c: Update background upon style-set and
        state-changed.  (#348634, Thomas Rydzynski)
 

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 145304e74e4705d21c0cea0bcb0a62f5b1fcd8cd..fde6f3630d5f285faa0c4e9539b25d3f698ee530 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,5 +1,8 @@
 2006-08-16  Matthias Clasen  <mclasen@redhat.com>
 
+       * gtk/gtktreemodel.c (gtk_tree_model_base_init): Add some
+       docs to the row-deleted signal.  (#349128, Benedikt Meurer)
+
        * gtk/gtkiconview.c: Update background upon style-set and
        state-changed.  (#348634, Thomas Rydzynski)
 

diff --git a/gtk/gtktreemodel.c b/gtk/gtktreemodel.c
index 15b547bf019c2162b59c6ae1a3749f903886ddd1..68ce31482bd687ea27ef37980f728c384e208eea 100644 (file)
--- a/gtk/gtktreemodel.c
+++ b/gtk/gtktreemodel.c
@@ -231,6 +231,13 @@ gtk_tree_model_base_init (gpointer g_class)
        *
        * Note that no iterator is passed to the signal handler,
        * since the row is already deleted.
+       *
+       * Implementations of GtkTreeModel must emit row-deleted 
+       * <emphasis>before</emphasis> removing the node from its
+       * internal data structures.  This is because models and 
+       * views which access and monitor this model might have
+       * references on the node which need to be released in the
+       * row-deleted handler.
        */
       closure = g_closure_new_simple (sizeof (GClosure), NULL);
       g_closure_set_marshal (closure, row_deleted_marshal);