selector: Remove a misleading error message

Duplicate selectors are indeed fine and shouldn't cause errors.
You want to use them to up specificity.

diff --git a/gtk/gtkcssselector.c b/gtk/gtkcssselector.c
index 71247c0cc368cbb586519bfef4c61285f63a2699..96f010adbf61e9ff84cdefc1fbdbc888098c0e59 100644 (file)
--- a/gtk/gtkcssselector.c
+++ b/gtk/gtkcssselector.c
@@ -187,14 +187,6 @@ parse_selector_pseudo_class (GtkCssParser   *parser,
     {
       if (g_ascii_strcasecmp (name, classes[i].name) == 0)
         {
-          if ((*region_to_modify & classes[i].region_flag) ||
-              (*state_to_modify & classes[i].state_flag))
-            {
-              if (classes == nth_child_classes)
-                _gtk_css_parser_error (parser, "Duplicate pseudo-class 'nth-child(%s)'", name);
-              else
-                _gtk_css_parser_error (parser, "Duplicate pseudo-class '%s'", name);
-            }
           *region_to_modify |= classes[i].region_flag;
           *state_to_modify |= classes[i].state_flag;
 

diff --git a/tests/css/parser/Makefile.am b/tests/css/parser/Makefile.am
index 44bf32ae183a8b510294f98e68391cb7911d8eb7..af82581a38faf1f746eeb3be8bf5176136d9b33b 100644 (file)
--- a/tests/css/parser/Makefile.am
+++ b/tests/css/parser/Makefile.am
@@ -296,7 +296,6 @@ EXTRA_DIST += \
        pseudo-classes-unknown.errors \
        pseudo-classes-unknown.ref.css \
        selector.css \
-       selector.errors \
        selector.ref.css \
        shorthand.css \
        shorthand.ref.css \

diff --git a/tests/css/parser/selector.errors b/tests/css/parser/selector.errors
deleted file mode 100644 (file)
index 42cc16e..0000000
--- a/tests/css/parser/selector.errors
+++ /dev/null
@@ -1 +0,0 @@
-selector.css:201: error: GTK_CSS_PROVIDER_ERROR_SYNTAX

diff --git a/tests/css/parser/selector.ref.css b/tests/css/parser/selector.ref.css
index 37ba16addbdd93fd41531b57e5d3fca1bc49eed6..e982145719d57d03b20b21b5e0d23487292769fe 100644 (file)
--- a/tests/css/parser/selector.ref.css
+++ b/tests/css/parser/selector.ref.css
@@ -86,10 +86,6 @@ a > b {
   int-property: 42;
 }
 
-:hover {
-  int-property: 42;
-}
-
 a.b {
   int-property: 42;
 }
@@ -166,6 +162,10 @@ a > :hover {
   int-property: 42;
 }
 
+:hover:hover {
+  int-property: 42;
+}
+
 :hover :hover {
   int-property: 42;
 }