]> Pileus Git - ~andy/gtk/commitdiff
Revert "gtkbox: Invalidate order on changes, even if the child is not visible"
authorCosimo Cecchi <cosimoc@gnome.org>
Fri, 1 Jul 2011 15:47:41 +0000 (11:47 -0400)
committerCosimo Cecchi <cosimoc@gnome.org>
Fri, 1 Jul 2011 15:47:41 +0000 (11:47 -0400)
This reverts commit 8cb0cc58e321641ebda699b9cbdc0067aeb56d3f.

gtk/gtkbox.c

index b711a52aa5a23a20e7ec7986a7e16d5116e5351f..f97a80d583e0597658c9797066343b95c4ba6596 100644 (file)
@@ -1612,12 +1612,10 @@ gtk_box_reorder_child (GtkBox    *box,
   priv->children = g_list_insert_before (priv->children, new_link, child_info);
 
   gtk_widget_child_notify (child, "position");
-
-  gtk_box_invalidate_order (box);
-
   if (gtk_widget_get_visible (child)
       && gtk_widget_get_visible (GTK_WIDGET (box)))
     {
+      gtk_box_invalidate_order (box);
       gtk_widget_queue_resize (child);
     }
 }
@@ -1801,13 +1799,12 @@ gtk_box_remove (GtkContainer *container,
          g_list_free (children);
          g_free (child);
 
-         gtk_box_invalidate_order (box);
-
          /* queue resize regardless of gtk_widget_get_visible (container),
           * since that's what is needed by toplevels.
           */
          if (was_visible)
             {
+              gtk_box_invalidate_order (box);
              gtk_widget_queue_resize (GTK_WIDGET (container));
             }