]> Pileus Git - ~andy/gtk/commitdiff
label: refactor code
authorBenjamin Otte <otte@redhat.com>
Tue, 12 Mar 2013 11:43:14 +0000 (12:43 +0100)
committerBenjamin Otte <otte@redhat.com>
Tue, 12 Mar 2013 11:46:37 +0000 (12:46 +0100)
If text didn't change, don't change it.

And if that sentence made no sense, that might explain why I refactored.

gtk/gtklabel.c

index bc17554a230aeeee329c64124acc5326400e12c4..0eac38ddaf6f4e625b161b30280279c9dda60f58 100644 (file)
@@ -1980,15 +1980,14 @@ gtk_label_set_text_internal (GtkLabel *label,
                              gchar    *str)
 {
   GtkLabelPrivate *priv = label->priv;
-  gboolean text_changed;
 
-  text_changed = g_strcmp0 (priv->text, str) != 0;
+  if (g_strcmp0 (priv->text, str) == 0)
+    return;
 
   g_free (priv->text);
   priv->text = str;
 
-  if (text_changed)
-    gtk_label_select_region_index (label, 0, 0);
+  gtk_label_select_region_index (label, 0, 0);
 }
 
 static void