gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap)

2005-08-12  Owen Taylor  <otaylor@redhat.com>

        * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap)
        * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap)
        * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap): Warn if
        gdk_drawable_get_colormap (pixmap) is NULL and return.

diff --git a/ChangeLog b/ChangeLog
index 5271b6ade826b8b1b19445091f09fc5a29ec5ae5..9ae69a9842ab3a40ab4b2584bae264abe2730faf 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2005-08-12  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap)
+       * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap) 
+       * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap): Warn if
+       gdk_drawable_get_colormap (pixmap) is NULL and return.
+
 2005-08-12  Matthias Clasen  <mclasen@redhat.com>
 
        * configure.in: Bump version to 2.8.0

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 5271b6ade826b8b1b19445091f09fc5a29ec5ae5..9ae69a9842ab3a40ab4b2584bae264abe2730faf 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,10 @@
+2005-08-12  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap)
+       * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap) 
+       * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap): Warn if
+       gdk_drawable_get_colormap (pixmap) is NULL and return.
+
 2005-08-12  Matthias Clasen  <mclasen@redhat.com>
 
        * configure.in: Bump version to 2.8.0

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index 5271b6ade826b8b1b19445091f09fc5a29ec5ae5..9ae69a9842ab3a40ab4b2584bae264abe2730faf 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,10 @@
+2005-08-12  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap)
+       * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap) 
+       * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap): Warn if
+       gdk_drawable_get_colormap (pixmap) is NULL and return.
+
 2005-08-12  Matthias Clasen  <mclasen@redhat.com>
 
        * configure.in: Bump version to 2.8.0

diff --git a/gdk/linux-fb/gdkwindow-fb.c b/gdk/linux-fb/gdkwindow-fb.c
index 8e278c2a8dfcf01d3be7b9b943726dc3899cbef2..98183131b8ccee9cf172b32bbaac73204b31785f 100644 (file)
--- a/gdk/linux-fb/gdkwindow-fb.c
+++ b/gdk/linux-fb/gdkwindow-fb.c
@@ -1473,6 +1473,12 @@ gdk_window_set_back_pixmap (GdkWindow *window,
   g_return_if_fail (pixmap == NULL || !parent_relative);
   g_return_if_fail (pixmap == NULL || gdk_drawable_get_depth (window) == gdk_drawable_get_depth (pixmap));
 
+  if (!gdk_drawable_get_colormap (pixmap))
+    {
+      g_warning ("gdk_window_set_back_pixmap(): pixmap must have a colormap");
+      return;
+    }
+  
   old_pixmap = private->bg_pixmap;
 
   if (parent_relative)

diff --git a/gdk/win32/gdkwindow-win32.c b/gdk/win32/gdkwindow-win32.c
index 6304096bb4d7b87339bdb18fe0af38c3645151a6..83513cf0f0394e97d66681831d94c458f9647d73 100644 (file)
--- a/gdk/win32/gdkwindow-win32.c
+++ b/gdk/win32/gdkwindow-win32.c
@@ -1849,6 +1849,12 @@ gdk_window_set_back_pixmap (GdkWindow *window,
   g_return_if_fail (pixmap == NULL || !parent_relative);
   g_return_if_fail (pixmap == NULL || gdk_drawable_get_depth (window) == gdk_drawable_get_depth (pixmap));
   
+  if (!gdk_drawable_get_colormap (pixmap))
+    {
+      g_warning ("gdk_window_set_back_pixmap(): pixmap must have a colormap");
+      return;
+    }
+  
   if (private->bg_pixmap &&
       private->bg_pixmap != GDK_PARENT_RELATIVE_BG &&
       private->bg_pixmap != GDK_NO_BG)

diff --git a/gdk/x11/gdkwindow-x11.c b/gdk/x11/gdkwindow-x11.c
index b2ced14ac6af528b1276d19aa90da0a6132d55b4..b02c86d114d15f68dc98ede796c59d2033c4da83 100644 (file)
--- a/gdk/x11/gdkwindow-x11.c
+++ b/gdk/x11/gdkwindow-x11.c
@@ -2912,6 +2912,12 @@ gdk_window_set_back_pixmap (GdkWindow *window,
   g_return_if_fail (GDK_IS_WINDOW (window));
   g_return_if_fail (pixmap == NULL || !parent_relative);
   g_return_if_fail (pixmap == NULL || gdk_drawable_get_depth (window) == gdk_drawable_get_depth (pixmap));
+
+  if (!gdk_drawable_get_colormap (pixmap))
+    {
+      g_warning ("gdk_window_set_back_pixmap(): pixmap must have a colormap");
+      return;
+    }
   
   if (private->bg_pixmap &&
       private->bg_pixmap != GDK_PARENT_RELATIVE_BG &&