Zero out some stack-allocated X structures, to avoid valgrind warnings

2006-08-15  Matthias Clasen  <mclasen@redhat.com>

        * gdk/x11/gdkdnd-x11.c (gdk_window_register_dnd):
        * gdk/x11/gdkwindow-x11.c (gdk_window_set_decorations):
        (gdk_window_set_functions): Zero out some stack-allocated
        X structures, to avoid valgrind warnings about uninitialized
        memory.  (#349382, David Baron)

diff --git a/ChangeLog b/ChangeLog
index eea2417b9612bcf679b3699a7bf6bc3a10da22d2..c1fd3dacaed8cc87ee743f07e142045351f325bf 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2006-08-15  Matthias Clasen  <mclasen@redhat.com>
+
+       * gdk/x11/gdkdnd-x11.c (gdk_window_register_dnd):
+       * gdk/x11/gdkwindow-x11.c (gdk_window_set_decorations):
+       (gdk_window_set_functions): Zero out some stack-allocated
+       X structures, to avoid valgrind warnings about uninitialized
+       memory.  (#349382, David Baron)
+
 2006-08-14  Emmanuele Bassi  <ebassi@gnome.org>
 
        * gtk/gtkrecentchooser.c:

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index eea2417b9612bcf679b3699a7bf6bc3a10da22d2..c1fd3dacaed8cc87ee743f07e142045351f325bf 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,11 @@
+2006-08-15  Matthias Clasen  <mclasen@redhat.com>
+
+       * gdk/x11/gdkdnd-x11.c (gdk_window_register_dnd):
+       * gdk/x11/gdkwindow-x11.c (gdk_window_set_decorations):
+       (gdk_window_set_functions): Zero out some stack-allocated
+       X structures, to avoid valgrind warnings about uninitialized
+       memory.  (#349382, David Baron)
+
 2006-08-14  Emmanuele Bassi  <ebassi@gnome.org>
 
        * gtk/gtkrecentchooser.c:

diff --git a/gdk/x11/gdkdnd-x11.c b/gdk/x11/gdkdnd-x11.c
index 7e0961c7711fe23ddc525004e4906dc688d20d0e..47178f2584964be02e34982091c1f1632a65c46b 100644 (file)
--- a/gdk/x11/gdkdnd-x11.c
+++ b/gdk/x11/gdkdnd-x11.c
@@ -3754,6 +3754,8 @@ gdk_window_register_dnd (GdkWindow      *window)
 
   motif_drag_receiver_info_atom = gdk_x11_get_xatom_by_name_for_display (display,
                                                                         "_MOTIF_DRAG_RECEIVER_INFO");
+  /* initialize to zero to avoid writing uninitialized data to socket */
+  memset(&info, 0, sizeof(info));
   info.byte_order = local_byte_order;
   info.protocol_version = 0;
   info.protocol_style = XmDRAG_DYNAMIC;

diff --git a/gdk/x11/gdkwindow-x11.c b/gdk/x11/gdkwindow-x11.c
index 80f5ff3842c77611923296376d5d3723ab31b0cf..2a71b22ada3f302c5e439679ed40f6c00268d2f8 100644 (file)
--- a/gdk/x11/gdkwindow-x11.c
+++ b/gdk/x11/gdkwindow-x11.c
@@ -5021,6 +5021,8 @@ gdk_window_set_decorations (GdkWindow      *window,
   
   g_return_if_fail (GDK_IS_WINDOW (window));
   
+  /* initialize to zero to avoid writing uninitialized data to socket */
+  memset(&hints, 0, sizeof(hints));
   hints.flags = MWM_HINTS_DECORATIONS;
   hints.decorations = decorations;
   
@@ -5089,6 +5091,8 @@ gdk_window_set_functions (GdkWindow    *window,
   
   g_return_if_fail (GDK_IS_WINDOW (window));
   
+  /* initialize to zero to avoid writing uninitialized data to socket */
+  memset(&hints, 0, sizeof(hints));
   hints.flags = MWM_HINTS_FUNCTIONS;
   hints.functions = functions;