Bug 538840 – [Win32] GTK menu theming could be improved

2009-03-21  Cody Russell  <bratsche@gnome.org>

        Bug 538840 – [Win32] GTK menu theming could be improved

        * modules/engines/ms-windows/xp_theme.c
        * modules/engines/ms-windows/msw_style.c: Use newer
        menu styling API.  This makes gtk+ look much better on
        Windows Vista.

svn path=/trunk/; revision=22577

diff --git a/ChangeLog b/ChangeLog
index c2e064c0acb94d4b07a89b4bab86eb7c2622584d..69a3b87dff7dd40acd3c3ca95c520b85ad8a1f3c 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2009-03-21  Cody Russell  <bratsche@gnome.org>
+
+       Bug 538840 – [Win32] GTK menu theming could be improved
+
+       * modules/engines/ms-windows/xp_theme.c
+       * modules/engines/ms-windows/msw_style.c: Use newer
+       menu styling API.  This makes gtk+ look much better on
+       Windows Vista.
+
 2009-03-19  Claudio Saavedra  <csaavedra@igalia.com>
 
        Bug 574283 – unused assignment and dead code in

diff --git a/modules/engines/ms-windows/msw_style.c b/modules/engines/ms-windows/msw_style.c
index 536e7b576ac8cdcb3f6ea0db93bf256b37426429..bc253e103a0334b8bc914a7ba370103f7351e433 100755 (executable)
--- a/modules/engines/ms-windows/msw_style.c
+++ b/modules/engines/ms-windows/msw_style.c
@@ -536,29 +536,42 @@ sys_font_to_pango_font (XpThemeClass klazz, XpThemeFont type, char *buf,
    for now */
 #define XP_THEME_CLASS_TEXT XP_THEME_CLASS_BUTTON
 
+#define WIN95_VERSION   0x400
+#define WIN2K_VERSION   0x500
+#define WINXP_VERSION   0x501
+#define WIN2K3_VERSION  0x502
+#define VISTA_VERSION   0x600
+
+static gint32
+get_windows_version ()
+{
+  static gint32 version = 0;
+  static gboolean have_version = FALSE;
+
+  if (!have_version)
+    {
+      have_version = TRUE;
+      OSVERSIONINFOEX osvi;
+
+      ZeroMemory (&osvi, sizeof (OSVERSIONINFOEX));
+      osvi.dwOSVersionInfoSize = sizeof (OSVERSIONINFOEX);
+
+      GetVersionEx((OSVERSIONINFO*) &osvi);
+
+      version = (osvi.dwMajorVersion & 0xff) << 8 | (osvi.dwMinorVersion & 0xff);
+    }
+
+  return version;
+}
+
 static void
 setup_menu_settings (GtkSettings *settings)
 {
   int menu_delay;
-  gboolean win95 = FALSE;
   OSVERSIONINFOEX osvi;
   GObjectClass *klazz = G_OBJECT_GET_CLASS (G_OBJECT (settings));
 
-  ZeroMemory (&osvi, sizeof (OSVERSIONINFOEX));
-  osvi.dwOSVersionInfoSize = sizeof (OSVERSIONINFOEX);
-
-  if (!GetVersionEx ((OSVERSIONINFO *) & osvi))
-    win95 = TRUE;              /* assume the worst */
-
-  if (osvi.dwPlatformId == VER_PLATFORM_WIN32_WINDOWS)
-    {
-      if (osvi.dwMajorVersion == 4 && osvi.dwMinorVersion == 0)
-       {
-         win95 = TRUE;
-       }
-    }
-
-  if (!win95)
+  if (get_windows_version () > WIN95_VERSION)
     {
       if (SystemParametersInfo (SPI_GETMENUSHOWDELAY, 0, &menu_delay, 0))
        {
@@ -685,7 +698,8 @@ setup_msw_rc_style (void)
   GdkColor text_prelight;
 
   /* Prelight */
-  sys_color_to_gtk_color (XP_THEME_CLASS_TEXT, COLOR_HIGHLIGHTTEXT,
+  sys_color_to_gtk_color (XP_THEME_CLASS_TEXT,
+                         get_windows_version () == VISTA_VERSION ? COLOR_MENUTEXT : COLOR_HIGHLIGHTTEXT,
                          &fg_prelight);
   sys_color_to_gtk_color (XP_THEME_CLASS_TEXT, COLOR_HIGHLIGHT, &bg_prelight);
   sys_color_to_gtk_color (XP_THEME_CLASS_TEXT, COLOR_HIGHLIGHT,
@@ -1810,6 +1824,12 @@ draw_menu_item (GdkWindow *window, GtkWidget *widget, GtkStyle *style,
   HDC dc;
   RECT rect;
 
+  if (xp_theme_is_active ())
+    {
+      return (xp_theme_draw (window, XP_THEME_ELEMENT_MENU_ITEM, style,
+                             x, y, width, height, state_type, area));
+    }
+
   if ((parent = gtk_widget_get_parent (widget))
       && GTK_IS_MENU_BAR (parent) && !xp_theme_is_active ())
     {
@@ -2964,7 +2984,7 @@ draw_shadow (GtkStyle *style,
 
   if (detail && !strcmp (detail, "frame"))
     {
- 
+
       HDC dc;
       RECT rect;
 
@@ -3079,7 +3099,7 @@ draw_shadow (GtkStyle *style,
            {
              pos = gtk_handle_box_get_handle_position (GTK_HANDLE_BOX (widget));
              /*
-                If the handle box is at left side, 
+                If the handle box is at left side,
                 we shouldn't draw its right border.
                 The same holds true for top, right, and bottom.
               */

diff --git a/modules/engines/ms-windows/xp_theme.c b/modules/engines/ms-windows/xp_theme.c
index e177ce59029ca9a6eeec31688ebfb12ead28b109..bfd8ab79f2ed6a67b4f8785f136f10a4473988cb 100755 (executable)
--- a/modules/engines/ms-windows/xp_theme.c
+++ b/modules/engines/ms-windows/xp_theme.c
@@ -79,6 +79,16 @@
 
 #define TRS_NORMAL        1
 
+#define MBI_NORMAL         1
+#define MBI_HOT            2
+#define MBI_PUSHED         3
+#define MBI_DISABLED       4
+#define MBI_DISABLEDHOT    5
+#define MBI_DISABLEDPUSHED 6
+
+#define MENU_POPUPITEM      14
+#define MENU_POPUPSEPARATOR 15
+
 static const LPCWSTR class_descriptors[] = {
   L"Scrollbar",                        /* XP_THEME_CLASS_SCROLLBAR */
   L"Button",                   /* XP_THEME_CLASS_BUTTON */
@@ -139,8 +149,8 @@ static const short element_part_map[XP_THEME_ELEMENT__SIZEOF] = {
   RP_GRIPPERVERT,
   RP_CHEVRON,
   TP_BUTTON,
-  MP_MENUITEM,
-  MP_SEPARATOR,
+  MENU_POPUPITEM, /*MP_MENUITEM,*/
+  MENU_POPUPSEPARATOR,  /*MP_SEPARATOR,*/
   SP_GRIPPER,
   SP_PANE,
   GP_LINEHORZ,
@@ -780,12 +790,16 @@ xp_theme_map_gtk_state (XpThemeElement element, GtkStateType state)
          ret = MS_SELECTED;
          break;
 
+       case GTK_STATE_PRELIGHT:
+         ret = MBI_HOT;
+         break;
+
        case GTK_STATE_INSENSITIVE:
-         ret = MS_DEMOTED;
+         ret = MBI_DISABLED;
          break;
 
        default:
-         ret = MS_NORMAL;
+         ret = MBI_NORMAL;
        }
       break;