Bug 554690 – mem leak in filechooser

svn path=/trunk/; revision=21567

diff --git a/ChangeLog b/ChangeLog
index 1026e9bbabc70c0f61bccbf6601f107c2be7f2c4..246eac78e8180aa5ca2645da2f3957ff772dd850 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2008-10-02  Christian Persch
+
+        Bug 554690 – mem leak in filechooser
+
+        * gtk/gtkfilechooserdefault.c: Plug a mem leak.
+
 2008-10-02  Michael Natterer  <mitch@imendio.com>
 
        Bug 553585 – Add orientation API to GtkRuler

diff --git a/gtk/gtkfilechooserdefault.c b/gtk/gtkfilechooserdefault.c
index 8881936dc2879d720840ea3b5c1d607ad6c3d8a9..1248e7b27f09115eb0d50c72a08310784482a27c 100644 (file)
--- a/gtk/gtkfilechooserdefault.c
+++ b/gtk/gtkfilechooserdefault.c
@@ -2074,10 +2074,17 @@ shortcuts_add_volumes (GtkFileChooserDefault *impl)
          if (_gtk_file_system_volume_is_mounted (volume))
            {
              GFile *base_file;
+              gboolean base_is_native = TRUE;
 
              base_file = _gtk_file_system_volume_get_root (volume);
-             if (base_file != NULL && !g_file_is_native (base_file))
-               continue;
+              if (base_file != NULL)
+                {
+                  base_is_native = g_file_is_native (base_file);
+                  g_object_unref (base_file);
+                }
+
+              if (!base_is_native)
+                continue;
            }
        }