Fix rather improbable reentrancy problem if a window is destroyed while

Thu Mar 14 17:09:52 2002  Owen Taylor  <otaylor@redhat.com>

        * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
        improbable reentrancy problem if a window is destroyed
        while updates are being processed on another window. (Noticed
        by Michael Meeks, #74708)

diff --git a/ChangeLog b/ChangeLog
index 974db102b9669c67f96237a8505976b6d53ba129..a8e2d36282bb20a5623922b25f90c539db7edc63 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+Thu Mar 14 17:09:52 2002  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
+       improbable reentrancy problem if a window is destroyed
+       while updates are being processed on another window. (Noticed
+       by Michael Meeks, #74708)
+
 2002-03-14 Vitaly Tishkov <tvv@sparc.spb.su>
 
         * gtk/gtktreemodelsort.c

diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0
index 974db102b9669c67f96237a8505976b6d53ba129..a8e2d36282bb20a5623922b25f90c539db7edc63 100644 (file)
--- a/ChangeLog.pre-2-0
+++ b/ChangeLog.pre-2-0
@@ -1,3 +1,10 @@
+Thu Mar 14 17:09:52 2002  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
+       improbable reentrancy problem if a window is destroyed
+       while updates are being processed on another window. (Noticed
+       by Michael Meeks, #74708)
+
 2002-03-14 Vitaly Tishkov <tvv@sparc.spb.su>
 
         * gtk/gtktreemodelsort.c

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 974db102b9669c67f96237a8505976b6d53ba129..a8e2d36282bb20a5623922b25f90c539db7edc63 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,10 @@
+Thu Mar 14 17:09:52 2002  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
+       improbable reentrancy problem if a window is destroyed
+       while updates are being processed on another window. (Noticed
+       by Michael Meeks, #74708)
+
 2002-03-14 Vitaly Tishkov <tvv@sparc.spb.su>
 
         * gtk/gtktreemodelsort.c

diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2
index 974db102b9669c67f96237a8505976b6d53ba129..a8e2d36282bb20a5623922b25f90c539db7edc63 100644 (file)
--- a/ChangeLog.pre-2-2
+++ b/ChangeLog.pre-2-2
@@ -1,3 +1,10 @@
+Thu Mar 14 17:09:52 2002  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
+       improbable reentrancy problem if a window is destroyed
+       while updates are being processed on another window. (Noticed
+       by Michael Meeks, #74708)
+
 2002-03-14 Vitaly Tishkov <tvv@sparc.spb.su>
 
         * gtk/gtktreemodelsort.c

diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index 974db102b9669c67f96237a8505976b6d53ba129..a8e2d36282bb20a5623922b25f90c539db7edc63 100644 (file)
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -1,3 +1,10 @@
+Thu Mar 14 17:09:52 2002  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
+       improbable reentrancy problem if a window is destroyed
+       while updates are being processed on another window. (Noticed
+       by Michael Meeks, #74708)
+
 2002-03-14 Vitaly Tishkov <tvv@sparc.spb.su>
 
         * gtk/gtktreemodelsort.c

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index 974db102b9669c67f96237a8505976b6d53ba129..a8e2d36282bb20a5623922b25f90c539db7edc63 100644 (file)
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,10 @@
+Thu Mar 14 17:09:52 2002  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
+       improbable reentrancy problem if a window is destroyed
+       while updates are being processed on another window. (Noticed
+       by Michael Meeks, #74708)
+
 2002-03-14 Vitaly Tishkov <tvv@sparc.spb.su>
 
         * gtk/gtktreemodelsort.c

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index 974db102b9669c67f96237a8505976b6d53ba129..a8e2d36282bb20a5623922b25f90c539db7edc63 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,10 @@
+Thu Mar 14 17:09:52 2002  Owen Taylor  <otaylor@redhat.com>
+
+       * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
+       improbable reentrancy problem if a window is destroyed
+       while updates are being processed on another window. (Noticed
+       by Michael Meeks, #74708)
+
 2002-03-14 Vitaly Tishkov <tvv@sparc.spb.su>
 
         * gtk/gtktreemodelsort.c

diff --git a/gdk/gdkwindow.c b/gdk/gdkwindow.c
index 8199e09bf63d750dfa8a9fd90fb156999d5d2ece..187c3a2891b1c19485e7d37b0fe9b8ae553ff072 100644 (file)
--- a/gdk/gdkwindow.c
+++ b/gdk/gdkwindow.c
@@ -2139,9 +2139,12 @@ gdk_window_process_all_updates (void)
   update_windows = NULL;
   update_idle = 0;
 
+  g_slist_foreach (old_update_windows, (GFunc)g_object_ref, NULL);
+  
   while (tmp_list)
     {
       gdk_window_process_updates_internal (tmp_list->data);
+      g_object_unref (tmp_list->data);
       tmp_list = tmp_list->next;
     }