]> Pileus Git - ~andy/gtk/commitdiff
modules: Don't use GDK_THREADS_ENTER/LEAVE macros internally
authorMatthias Clasen <mclasen@redhat.com>
Mon, 30 Jul 2012 08:37:32 +0000 (10:37 +0200)
committerMatthias Clasen <mclasen@redhat.com>
Mon, 30 Jul 2012 16:01:47 +0000 (18:01 +0200)
These are just wrappers for the functions, and we want to
deprecate them. Stopping to use them internally is a good
first step. Also define GTK_COMPILATION so we can keep using
gdk_threads_enter/leave without causing deprecation warnings.

modules/input/Makefile.am
modules/input/gtkimcontextmultipress.c
modules/printbackends/cups/Makefile.am
modules/printbackends/cups/gtkprintbackendcups.c
modules/printbackends/file/Makefile.am
modules/printbackends/file/gtkprintbackendfile.c

index 46e00fb43e0129e7389350bc671c3b2ef781013e..317f4e24f3643ae7096d3159e3ccf6875492ce44 100644 (file)
@@ -12,6 +12,7 @@ AM_CPPFLAGS = \
        $(GTK_DEBUG_FLAGS)              \
        $(GTK_XIM_FLAGS)                \
        $(GTK_DEP_CFLAGS)               \
+       -DGTK_COMPILATION               \
        $(INCLUDED_IMMODULE_DEFINE)
 
 DEPS = \
index 57406cf3556c0ae905beacb550b4c405b99b17e7..7fb484a07ceddf0aee42403c77b52449f68d94d8 100644 (file)
@@ -197,7 +197,7 @@ on_timeout (gpointer data)
 {
   GtkImContextMultipress *multipress_context;
 
-  GDK_THREADS_ENTER ();
+  gdk_threads_enter ();
 
   multipress_context = GTK_IM_CONTEXT_MULTIPRESS (data);
 
@@ -207,7 +207,7 @@ on_timeout (gpointer data)
 
   multipress_context->timeout_id = 0;
 
-  GDK_THREADS_LEAVE ();
+  gdk_threads_leave ();
 
   return G_SOURCE_REMOVE; /* don't call me again */
 }
index f90a28f73b736b24eaf15a730266a2243d4c02da..e9d4c2fdd193cae1cc035d53e14ee3bb50b623b9 100644 (file)
@@ -12,6 +12,7 @@ AM_CPPFLAGS = \
        -I$(top_builddir)/gdk                           \
        $(CUPS_CFLAGS)                                  \
        $(COLORD_CFLAGS)                                \
+       -DGTK_COMPILATION                               \
        -DGTK_PRINT_BACKEND_ENABLE_UNSUPPORTED          \
        $(GTK_DEP_CFLAGS)                               \
        $(GTK_DEBUG_FLAGS)
index cddb6b76c4f1abd95b512fbb406378baabbab461..d9110be158eae1393fc28067b2917ecdc93b385f 100644 (file)
@@ -469,7 +469,7 @@ cups_print_cb (GtkPrintBackendCups *print_backend,
   GError *error = NULL;
   CupsPrintStreamData *ps = user_data;
 
-  GDK_THREADS_ENTER ();
+  gdk_threads_enter ();
 
   GTK_NOTE (PRINTING,
             g_print ("CUPS Backend: %s\n", G_STRFUNC));
@@ -506,7 +506,7 @@ cups_print_cb (GtkPrintBackendCups *print_backend,
   if (error)
     g_error_free (error);
 
-  GDK_THREADS_LEAVE ();
+  gdk_threads_leave ();
 }
 
 typedef struct {
@@ -1494,7 +1494,7 @@ cups_request_job_info_cb (GtkPrintBackendCups *print_backend,
   int state;
   gboolean done;
 
-  GDK_THREADS_ENTER ();
+  gdk_threads_enter ();
 
   if (data->job == NULL)
     {
@@ -1566,7 +1566,7 @@ cups_request_job_info_cb (GtkPrintBackendCups *print_backend,
     cups_job_poll_data_free (data);
 
 done:
-  GDK_THREADS_LEAVE ();
+  gdk_threads_leave ();
 }
 
 static void
@@ -1953,7 +1953,7 @@ cups_request_printer_list_cb (GtkPrintBackendCups *cups_backend,
   GList *removed_printer_checklist;
   gchar *remote_default_printer = NULL;
 
-  GDK_THREADS_ENTER ();
+  gdk_threads_enter ();
 
   list_has_changed = FALSE;
 
@@ -2235,7 +2235,7 @@ done:
         }
     }
 
-  GDK_THREADS_LEAVE ();
+  gdk_threads_leave ();
 }
 
 static void
@@ -2368,7 +2368,7 @@ cups_request_ppd_cb (GtkPrintBackendCups *print_backend,
 {
   GtkPrinter *printer;
 
-  GDK_THREADS_ENTER ();
+  gdk_threads_enter ();
 
   GTK_NOTE (PRINTING,
             g_print ("CUPS Backend: %s\n", G_STRFUNC));
@@ -2404,7 +2404,7 @@ cups_request_ppd_cb (GtkPrintBackendCups *print_backend,
   g_signal_emit_by_name (printer, "details-acquired", TRUE);
 
 done:
-  GDK_THREADS_LEAVE ();
+  gdk_threads_leave ();
 }
 
 static gboolean
@@ -2750,7 +2750,7 @@ cups_request_default_printer_cb (GtkPrintBackendCups *print_backend,
   ipp_attribute_t *attr;
   GtkPrinter *printer;
 
-  GDK_THREADS_ENTER ();
+  gdk_threads_enter ();
 
   if (gtk_cups_result_is_error (result))
     {
@@ -2789,7 +2789,7 @@ cups_request_default_printer_cb (GtkPrintBackendCups *print_backend,
   if (print_backend->list_printers_poll != 0)
     cups_request_printer_list (print_backend);
 
-  GDK_THREADS_LEAVE ();
+  gdk_threads_leave ();
 }
 
 static gboolean
index 9b25bc974f7fbc4e4d8d6179401553d65c42e704..c0189f10a764f7366efa352a9457902ce44894c4 100644 (file)
@@ -17,6 +17,7 @@ libprintbackend_file_la_CPPFLAGS = \
        -I$(top_builddir)/gtk                           \
        -I$(top_srcdir)/gdk                             \
        -I$(top_builddir)/gdk                           \
+       -DGTK_COMPILATION                               \
        -DGTK_PRINT_BACKEND_ENABLE_UNSUPPORTED          \
        $(AM_CPPFLAGS)
 
index fdb36b6dbc75237c6ebf8d0d940493cd612ce0ef..e9b75feda9057d4f5b408326d4a5f57bf44b6b8e 100644 (file)
@@ -401,11 +401,11 @@ file_print_cb (GtkPrintBackendFile *print_backend,
                GError              *error,
                gpointer            user_data)
 {
-  GDK_THREADS_ENTER ();
+  gdk_threads_enter ();
 
   file_print_cb_locked (print_backend, error, user_data);
 
-  GDK_THREADS_LEAVE ();
+  gdk_threads_leave ();
 }
 
 static gboolean