Document that you need to unref the returned GdkPixbuf. (#484132,

2007-10-10  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentmanager.c (gtk_recent_info_get_icon): Document
	that you need to unref the returned GdkPixbuf. (#484132,
	Christian Persch)

	(build_recent_info): Use g_slist_prepend() when building
	the applications list.

svn path=/trunk/; revision=18904

diff --git a/ChangeLog b/ChangeLog
index af938db8af5811c9f25074ffd6bb7c2349c5eebf..0e58f86545ef9dc1fa99907b5227f09da6e4f45f 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2007-10-10  Emmanuele Bassi  <ebassi@gnome.org>
+
+       * gtk/gtkrecentmanager.c (gtk_recent_info_get_icon): Document
+       that you need to unref the returned GdkPixbuf. (#484132,
+       Christian Persch)
+
+       (build_recent_info): Use g_slist_prepend() when building
+       the applications list.
+
 2007-10-10  Emmanuele Bassi  <ebassi@gnome.org>
 
        * gtk/gtkfilechooserdefault.c (list_mtime_data_func): Convert

diff --git a/gtk/gtkrecentmanager.c b/gtk/gtkrecentmanager.c
index 4022b46c3c73ac20e32ef99d9bfb5880fcbca388..2e21d09c2ba8d44699eede2b7a0c072347990a27 100644 (file)
--- a/gtk/gtkrecentmanager.c
+++ b/gtk/gtkrecentmanager.c
@@ -1140,8 +1140,7 @@ build_recent_info (GBookmarkFile  *bookmarks,
       app_info->count = count;
       app_info->stamp = stamp;
       
-      info->applications = g_slist_append (info->applications,
-                                          app_info);
+      info->applications = g_slist_prepend (info->applications, app_info);
       g_hash_table_replace (info->apps_lookup, app_info->name, app_info);
     }
   
@@ -1936,7 +1935,8 @@ get_icon_fallback (const gchar *icon_name,
  *
  * Retrieves the icon of size @size associated to the resource MIME type.
  *
- * Return value: a #GdkPixbuf containing the icon, or %NULL.
+ * Return value: a #GdkPixbuf containing the icon, or %NULL. Use
+ *   g_object_unref() when finished using the icon.
  *
  * Since: 2.10
  */
@@ -2202,7 +2202,8 @@ gtk_recent_info_get_short_name (GtkRecentInfo *info)
  * is local, it returns a local path; if the resource is not local,
  * it returns the UTF-8 encoded content of gtk_recent_info_get_uri().
  *
- * Return value: a UTF-8 string containing the resource's URI or %NULL
+ * Return value: a newly allocated UTF-8 string containing the
+ *   resource's URI or %NULL. Use g_free() when done using it.
  *
  * Since: 2.10
  */