]> Pileus Git - ~andy/gtk/commitdiff
GtkIconTheme Don't leak pixbuf in symbolic icon cache
authorAlexander Larsson <alexl@redhat.com>
Thu, 14 Feb 2013 13:58:02 +0000 (14:58 +0100)
committerAlexander Larsson <alexl@redhat.com>
Thu, 14 Feb 2013 21:10:15 +0000 (22:10 +0100)
We need to unref the pixbuf we just put in the cache, because
symbolic_pixbuf_cache_new takes a ref.

https://bugzilla.gnome.org/show_bug.cgi?id=693802

gtk/gtkicontheme.c

index f2e9f6c1c0173485bbf9fdb8b3571438b83b1f96..de5c96c6b965da9dc4c1d267d4a2c2aaf4c51a8a 100644 (file)
@@ -3885,7 +3885,7 @@ _gtk_icon_info_load_symbolic_internal (GtkIconInfo  *icon_info,
       icon_info->symbolic_pixbuf_cache =
        symbolic_pixbuf_cache_new (pixbuf, fg, success_color, warning_color, error_color,
                                   icon_info->symbolic_pixbuf_cache);
-
+      g_object_unref (pixbuf);
       return symbolic_cache_get_proxy (icon_info->symbolic_pixbuf_cache, icon_info);
     }