]> Pileus Git - ~andy/gtk/commitdiff
Remove size_request from GtkToolbar
authorMatthias Clasen <mclasen@redhat.com>
Wed, 27 Oct 2010 13:41:37 +0000 (09:41 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Wed, 27 Oct 2010 13:41:37 +0000 (09:41 -0400)
This is just a bandaid fix, the toolbar should really return proper
min/natural sizes, so that we can handle the overflow properly.

gtk/gtktoolbar.c

index c6f520ccd11687df3d0cc8592c92041c7c4cf868..007d0394679e1fd742cae02ced4e2e9a829a2776 100644 (file)
@@ -186,8 +186,13 @@ static gint       gtk_toolbar_draw                 (GtkWidget           *widget,
                                                     cairo_t             *cr);
 static void       gtk_toolbar_realize              (GtkWidget           *widget);
 static void       gtk_toolbar_unrealize            (GtkWidget           *widget);
-static void       gtk_toolbar_size_request         (GtkWidget           *widget,
-                                                   GtkRequisition      *requisition);
+static void       gtk_toolbar_get_preferred_width  (GtkWidget           *widget,
+                                                    gint                *minimum,
+                                                    gint                *natural);
+static void       gtk_toolbar_get_preferred_height (GtkWidget           *widget,
+                                                    gint                *minimum,
+                                                    gint                *natural);
+
 static void       gtk_toolbar_size_allocate        (GtkWidget           *widget,
                                                    GtkAllocation       *allocation);
 static void       gtk_toolbar_style_set            (GtkWidget           *widget,
@@ -363,7 +368,8 @@ gtk_toolbar_class_init (GtkToolbarClass *klass)
   
   widget_class->button_press_event = gtk_toolbar_button_press;
   widget_class->draw = gtk_toolbar_draw;
-  widget_class->size_request = gtk_toolbar_size_request;
+  widget_class->get_preferred_width = gtk_toolbar_get_preferred_width;
+  widget_class->get_preferred_height = gtk_toolbar_get_preferred_height;
   widget_class->size_allocate = gtk_toolbar_size_allocate;
   widget_class->style_set = gtk_toolbar_style_set;
   widget_class->focus = gtk_toolbar_focus;
@@ -994,6 +1000,30 @@ gtk_toolbar_size_request (GtkWidget      *widget,
   priv->button_maxh = max_homogeneous_child_height;
 }
 
+static void
+gtk_toolbar_get_preferred_width (GtkWidget *widget,
+                                 gint      *minimum,
+                                 gint      *natural)
+{
+  GtkRequisition requisition;
+
+  gtk_toolbar_size_request (widget, &requisition);
+
+  *minimum = *natural = requisition.width;
+}
+
+static void
+gtk_toolbar_get_preferred_height (GtkWidget *widget,
+                                  gint      *minimum,
+                                  gint      *natural)
+{
+  GtkRequisition requisition;
+
+  gtk_toolbar_size_request (widget, &requisition);
+
+  *minimum = *natural = requisition.height;
+}
+
 static gint
 position (GtkToolbar *toolbar,
           gint        from,