update the refs from children to parents for all nodes, since they may all

2006-08-16  Kristian Rietveld  <kris@gtk.org>

	* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_fetch_child):
	update the refs from children to parents for all nodes, since
	they may all have been moved by the insert operation. (#346800,
	patch from Jonathan Matthew).

diff --git a/ChangeLog b/ChangeLog
index 4cbf0ab38bd517627946ec8a7cc7884b9d26890d..273edbf0981878471d91bddc6d2766443d4615d9 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2006-08-16  Kristian Rietveld  <kris@gtk.org>
+
+       * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_fetch_child):
+       update the refs from children to parents for all nodes, since
+       they may all have been moved by the insert operation. (#346800,
+       patch from Jonathan Matthew).
+
 2006-08-15  Matthias Clasen <mclasen@redhat.com>
 
        * gtk/gtkrecentfilter.c (gtk_recent_filter_filter):

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 4cbf0ab38bd517627946ec8a7cc7884b9d26890d..273edbf0981878471d91bddc6d2766443d4615d9 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,10 @@
+2006-08-16  Kristian Rietveld  <kris@gtk.org>
+
+       * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_fetch_child):
+       update the refs from children to parents for all nodes, since
+       they may all have been moved by the insert operation. (#346800,
+       patch from Jonathan Matthew).
+
 2006-08-15  Matthias Clasen <mclasen@redhat.com>
 
        * gtk/gtkrecentfilter.c (gtk_recent_filter_filter):

diff --git a/gtk/gtktreemodelfilter.c b/gtk/gtktreemodelfilter.c
index 4349004c50cc249a528c9d2507d4587143861fbc..6f0b16317d4c70bf62ecf736f7b9e5e3a07a5f2e 100644 (file)
--- a/gtk/gtktreemodelfilter.c
+++ b/gtk/gtktreemodelfilter.c
@@ -927,10 +927,7 @@ gtk_tree_model_filter_fetch_child (GtkTreeModelFilter *filter,
   g_array_insert_val (level->array, i, elt);
   *index = i;
 
-  if (i > 0)
-    i--;
-
-  for ( ; i < level->array->len; i++)
+  for (i = 0; i < level->array->len; i++)
     {
       FilterElt *e = &(g_array_index (level->array, FilterElt, i));
       if (e->children)