1 2004-09-03 Tor Lillqvist <tml@iki.fi>
3 * gtk-zip.sh.in: List the three theme gtkrc files separately, zip
4 doesn't do anything if one of the files on its command line
7 Handle changes of screen resolution on Win32. (#151581, reported by
10 * gdk/win32/gdkwindow-win32.c (_gdk_windowing_window_init,
11 _gdk_root_window_size_init): Factor out setting the root window's
12 size (as the size of the union of all monitors) to a new function.
14 * gdk/win32/gdkdisplay-win32.c (gdk_display_open,
15 _gdk_monitor_init): Factor out the monitor query to a new
18 * gdk/win32/gdkprivate-win32.h: Declare above new functions.
20 * gdk/win32/gdkevents-win32.c (gdk_event_translate,
21 handle_display_change): Handle WM_DISPLAYCHANGE by calling the
22 above two functions, and emitting the "size_changed" signal on our
25 2004-09-01 Matthias Clasen <mclasen@redhat.com>
27 * gtk/gtkcombobox.c (gtk_combo_box_get_popup_accessible):
28 Document the return value.
30 2004-09-01 Matthias Clasen <mclasen@redhat.com>
32 Make it possible to specify additional modules to load
33 via a setting. (#117236, Alex Graveley)
36 * gtk/gtkmodules.c: New files which contain the module
37 handling code which was previously in gtkmain.[hc].
38 Additionally, the code now looks for the gtk-modules
39 setting, which can specify additional modules to load.
42 * gtk/gtkmain.h: Remove all the module handling code.
44 * gtk/gtkdebug.h: Add a debug flag for modules.
46 * gtk/gtk.h: Include gtkmodules.h
48 * gtk/Makefile.am (gtk_public_h_sources): Add gtkmodules.h
49 (gtk_c_sources): Add gtkmodules.c
51 * gtk/gtksettings.c: Add the gtk-modules setting.
53 * gdk/x11/gdkevents-x11.c: Add the Gtk/Modules XSetting.
55 Wed Sep 1 19:11:44 2004 Søren Sandmann <sandmann@redhat.com>
57 * gtk/gtktoolbar.c (gtk_toolbar_size_allocate): Make sure
58 children of the toolbar are given positive dimensions. (149540,
61 2004-09-01 Matthias Clasen <mclasen@redhat.com>
63 * gtk/gtkfilesystemunix.c:
64 * gtk/gtkfilechooserbutton.c: Protect the unistd.h include
67 Wed Sep 1 02:38:48 2004 Matthias Clasen <maclas@gmx.de>
69 * gtk/gtkaccellabel.c (gtk_accel_label_expose_event): Make
70 accel labels ellipsize correctly. (#151559, Christian Persch)
72 Wed Sep 1 00:55:56 2004 Matthias Clasen <maclas@gmx.de>
74 * gtk/gtkimage.c (gtk_image_clear): Don't leak the iter
75 of a running animation. (#151542)
77 Tue Aug 31 23:40:29 2004 Matthias Clasen <maclas@gmx.de>
79 * gdk/win32/gdkproperty-win32.c (gdk_screen_get_setting): Make
80 "ms-windows" the default theme on Win32.
82 Tue Aug 31 23:24:49 2004 Matthias Clasen <maclas@gmx.de>
84 * gtk/gtkcalendar.c (gtk_calendar_main_button): Only start
85 a drag if the left button is pressed. (#151490, Frederic Croszat)
87 Tue Aug 31 23:20:58 2004 Matthias Clasen <maclas@gmx.de>
89 * gdk/x11/gdkdnd-x11.c (gdk_drop_finish): Remove debug spew.
91 Tue Aug 31 17:07:41 2004 Jonathan Blandford <jrb@redhat.com>
93 * gtk/gtktreeviewcolumn.c
94 (gtk_tree_view_column_cell_process_action): constrain cell area to
95 passed in cell_area, #147867
97 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_get_size): if
98 ellipsizing, get_size is only 3 chars wide.
100 * docs/tree-column-sizing.png: Add Matthias's excellent image.
102 2004-08-28 Robert Ögren <gtk@roboros.com>
104 On Win32, do not produce tablet motion or button events while a
105 window is being moved or resized. (#151090, reported by Shaneyfelt)
107 * gdk/win32/gdkprivate-win32.h
108 * gdk/win32/gdkglobals-win32.c
109 * gdk/win32/gdkevents-win32.c: Rename the variable resizing to
110 _sizemove_in_progress and make it extern.
112 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Ignore
113 motion and button events if _sizemove_in_progress is true.
115 2004-08-30 Tor Lillqvist <tml@iki.fi>
117 Make the ms-windows theme engine build with mingw.
119 * configure.in: Expand also modules/engines/ms-windows/Theme/
120 Makefile and .../Theme/gtk-2.0/Makefile.
122 * modules/engines/ms-windows/Makefile.am: Adapt for building
123 inside the GTK sources.
125 * modules/engines/ms-windows/*.c: Use "foo.h" style includes for
126 GTK and GDK headers. Use correct path for gdkwin32.h header.
128 * modules/engines/ms-windows/msw_style.c: Don't use deprecated GDK
131 * modules/engines/ms-windows/xp_theme_defs.h
132 * modules/engines/ms-windows/xp_theme.c: Move definitions of TMT_*
133 to xp_theme.c, as they are neither in mingw's nor Platform
136 * modules/engines/ms-windows/xp_theme.c: Define _WIN32_WINNT as
137 0x0501 to get the necesssary stuff from mingw's uxtheme.h.
139 2004-08-30 Matthias Clasen <mclasen@redhat.com>
141 Integrate the ms-windows theme engine (better known as Wimp)
142 into the autotools build. Wimp (http://gtk-wimp.sourceforge.net/)
143 was written by Raymond Penners and Dom Lachowicz. The Wimp 0.6.2
144 sources have been added to the GTK+ source tree in
145 modules/engines/ms-windows, and there is a ChangeLog detailing
146 the history of Wimp. (#109615, Havoc Pennington)
148 * configure.in: Generate modules/engines/Makefile and
149 modules/engines/ms-windows/Makefile.
151 * modules/Makefile.am (SUBDIRS): Add engines.
153 * modules/engines/Makefile.am: Compile ms-windows for win32.
155 2004-08-30 Matthias Clasen <mclasen@redhat.com>
157 * gtk/gtktextview.c (gtk_text_view_delete_surrounding_handler):
160 2004-08-27 Matthias Clasen <mclasen@redhat.com>
162 Fix #151112, Olexiy Avramchenko:
164 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout):
165 * gtk/gtkiconview.c (scroll_timeout, layout_callback)
166 (gtk_icon_view_item_accessible_idle_do_action):
167 * gtk/gtkcombobox.c (list_popup_resize_idle, popdown_idle)
168 (popup_idle): Protect idle callbacks and timeouts with
169 GDK_THREADS_ENTER/_LEAVE.
171 * gtk/gtkfilechooserbutton.c (update_dialog_idle): New function to
172 call update_dialog() from an idle with the necessary protection.
174 Mon Aug 30 01:34:42 2004 Matthias Clasen <maclas@gmx.de>
176 Changes to make sure input methods respect the editability
177 of entries and text views. #114173, Noah Levitt.
179 * gtk/gtkentry.c (popup_targets_received): Make the Input
180 Methods menuitem insensitive if we're not editable.
182 * gtk/gtkentry.c (gtk_entry_delete_surrounding_cb):
183 * gtk/gtkentry.c (gtk_entry_preedit_changed_cb):
184 * gtk/gtkentry.c (gtk_entry_commit_cb): Don't change anything
185 if we're not editable.
187 * gtk/gtkentry.c (gtk_entry_focus_out):
188 * gtk/gtkentry.c (gtk_entry_focus_in): Only send focus_in and
189 focus_out to the im context if we're editable.
191 * gtk/gtkentry.c (gtk_entry_set_property): Reset the im context
192 if the entry just became non-editable.
194 * gtk/gtktextview.c (gtk_text_view_delete_surrounding_handler):
195 Use gtk_text_buffer_delete_interactive() to not delete
196 non-editable portions of text.
198 2004-08-30 Tor Lillqvist <tml@iki.fi>
200 * modules/input/Makefile.am (im_ime_la_LIBADD): Link with -limm32.
202 * modules/input/gtkimcontextime.c: Use quotes in #includes, to
203 find headers when building inside GTK+ sources.
205 2004-08-27 Tor Lillqvist <tml@iki.fi>
207 * gdk/win32/gdkdnd-win32.c (GdkDragContextPrivateWin32): Add
208 drop_failed, like in the X11 backend. Nothing sets it, though.
209 (gdk_drag_drop_succeeded): Copy from X11 backend.
211 Thu Aug 26 23:58:11 2004 Matthias Clasen <maclas@gmx.de>
213 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't crash
214 if model is not set. Noted by Mariano Suarez-Alvarez.
216 Thu Aug 26 22:44:12 2004 Matthias Clasen <maclas@gmx.de>
218 Provide information about how an adjustment change in a range
219 widget happened. Add a "slider-moved" signal which reports how
220 a user is interacting with the range, whether they are clicking
221 on a stepper or the trough, or dragging the slider. (#133263,
224 * gtk/gtkmarshalers.list: Add signal type BOOLEAN:ENUM,DOUBLE.
225 * gtk/gtkrange.c (gtk_range_class_init): Add "change-value"
227 (gtk_range_internal_set_value): Rename to
228 gtk_range_real_change_value. Add GtkScrollType parameter. Emit
229 the change-value signal when the range's value changes.
230 (update_slider_position, gtk_range_scroll_event, step_back,
231 step_forward, page_back, page_forward, scroll_begin,
232 scroll_end): Change gtk_range_internal_set_value to
233 gtk_range_real_change_value.
234 * gtk/gtkrange.h (struct _GtkRangeClass): Declare change_value
237 2004-08-26 Matthias Clasen <mclasen@redhat.com>
239 * modules/input/Makefile.am: Build imime.la on Windows.
241 * modules/input/gtkimcontextime.h:
242 * modules/input/gtkimcontextime.c:
243 * modules/input/imime.c:
244 * modules/input/imm-extra.h: Add the IME input method for Win32
245 written by Takuro Ashie and Kazuko IWAMOTO. The code was previously
246 hosted at http://sourceforge.jp/projects/imime. (#135195)
248 2004-08-26 Bill Haneman <billh@gnome.org>
251 (gtk_tree_view_move_cursor_up_down):
252 If a multi-selection list contains only one item,
253 select it on cursor_up or cursor_down.
255 [patch from Padraig O'Briain]
257 2004-08-26 Matthias Clasen <mclasen@redhat.com>
259 Make gdk_window_process_[all]_updates() respect
260 update_freeze_counter (#144272, Soeren Sandmann)
262 * gdk/gdkwindow.c (gdk_window_schedule_update): New function to
263 install an idle for gdk_window_update_idle() if one isn't there
265 (gdk_window_process_all_updates):
266 (gdk_window_process_updates): Only process the updates if the
268 (gdk_window_invalidate_maybe_recurse): Schedule an update when
270 (gdk_window_thaw_updates): Use gdk_window_schedule_update() instead
271 of directly installing the idle.
273 2004-08-22 Robert Ögren <gtk@roboros.com>
275 On Win32, make graphical tablets work on multi-monitor systems.
276 (#145467, reported by buttknock1@ya...)
278 * gdk/win32/gdkinput-win32.c (gdk_input_translate_coordinates):
279 Use dimensions of _gdk_parent_root as screen size.
280 (gdk_input_get_root_relative_geometry): Get coordinates relative
281 to GDK root window instead of Win32 coordinates.
282 (_gdk_input_other_event): Updated accordingly.
284 Wed Aug 25 17:24:17 2004 Manish Singh <yosh@gimp.org>
286 * gdk/x11/gdkfont-x11.c: remove unused gdk_font_charset_for_locale()
289 * gdk/x11/gdkinput-x11.c (_gdk_input_common_init): remove unused
290 variables num_extensions and extensions.
292 * gtk/gtkhsv.c: remove unused gtk_hsv_get_focus_gc() function.
294 Wed Aug 25 17:14:58 2004 Manish Singh <yosh@gimp.org>
296 * gtk/gtktreeview.c (gtk_tree_view_search_activate): initialize
297 path so we don't potentially use an undefined pointer.
299 * gtk/gtkfilechooserdefault.c (shortcuts_list_create): add G_CALLBACK
300 cast for tree_view_keybinding_cb.
302 * gtk/gtkfilechooserdefault.c (location_entry_create): cast to
303 GTK_FILE_CHOOSER_ENTRY for _gtk_file_chooser_entry_set_file_part()
306 * gtk/gtkcellrenderercombo.c (gtk_cell_renderer_combo_start_editing):
307 cast to GTK_COMBO_BOX for gtk_combo_box_set_active_iter() call.
309 * gtk/gtkselection.c (selection_get_text_plain): make len a gsize,
310 since that's what g_convert_with_fallback() expects.
312 Wed Aug 25 16:14:34 2004 Jonathan Blandford <jrb@redhat.com>
314 * gtk/gtktreeview.c (gtk_tree_view_search_activate): activate the
315 typeahead entry on enter.
317 2004-08-25 Matthias Clasen <mclasen@redhat.com>
319 * gtk/gtkmenu.c (gtk_menu_attach_to_widget): Steal ATTACHED_MENUS
320 list so its tail isn't freed when we re-set it, noticed
321 by Hans Petter Jansson.
323 * gtk/gtksizegroup.c (gtk_size_group_add_widget): Fix
324 a typo, noticed by Tim Janik.
326 Wed Aug 25 15:15:56 2004 Jonathan Blandford <jrb@redhat.com>
328 * gtk/gtkpathbar.c (gtk_path_bar_size_allocate): Change the Down
329 button to be end-justified, so that clicking on it is a stable
332 Tue Aug 24 02:06:37 2004 Jonathan Blandford <jrb@gnome.org>
335 (gtk_tree_view_real_expand_collapse_cursor_row): Don't handle the
336 event if we have no children.
338 * gtk/gtkfilechooserdefault.c (trap_activate_cb):
339 (tree_view_keybinding_cb):Since GtkTreeView has a keybinding
340 attached to '/', we need to catch keypresses before the TreeView
342 (gtk_file_chooser_default_class_init): add '/' to be a keybinding
344 (location_entry_create): Clear the text to "" when loading a file.
345 This has a much better feel than putting the currently selected
349 2004-08-25 Matthias Clasen <mclasen@redhat.com>
351 * gtk/gtkfilechooserdefault.c (check_is_folder): Use get_file_info() rather
352 than trying get_folder() and checking for an error directly because older
353 versions of the gnome-vfs backend don't return an error
354 immediately. (#150852, Zack Cerza )
356 2004-08-25 Matthias Clasen <mclasen@redhat.com>
358 * configure.in: Post-release version bump.
360 * === Released 2.5.2 ===
363 * gtk/abicheck.sh: Make work during make distcheck.
365 * docs/RELEASE-HOWTO: Add hint about doing make check
366 before make distcheck.
368 * gtk/gtk.symbols: Add some missing symbols.
370 * gtk/gtkiconview.c: Add some missing statics.
372 2004-08-24 Matthias Clasen <mclasen@redhat.com>
374 * NEWS: Updates for 2.5.2
376 Wed Aug 25 00:22:48 2004 Søren Sandmann <sandmann@redhat.com>
378 * gtk/gtksequence.c: Remove debug spew
380 Wed Aug 25 00:09:07 2004 Søren Sandmann <sandmann@redhat.com>
382 * gtk/gtkliststore.c (gtk_list_store_move_after): Fix logical
383 errors in gtk_list_store_move_before/after(). (#150983, patch by
386 Tue Aug 24 21:46:42 2004 Søren Sandmann <sandmann@redhat.com>
388 * gtk/gtksequence.c (_gtk_sequence_move): Just return if the
389 parameters are identical. (#150159, Robert Ögren)
391 2004-08-24 Matthias Clasen <mclasen@redhat.com>
393 * gtk/gtkaction.c (connect_proxy, disconnect_proxy): Handle
394 action_group being NULL. (#150869, Tommi Komulainen)
396 2004-08-24 Matthias Clasen <mclasen@redhat.com>
398 * gdk/gdkimage.c (allocate_scratch_images): Use the correct
399 index variable. (#150941, Tommi Komulainen)
401 2004-08-24 Matthias Clasen <mclasen@redhat.com>
403 * gtk/gtktreeview.c (gtk_tree_view_node_queue_redraw): Take header
404 height and adjustment into account. (#136496, Pawek Salek)
406 Mon Aug 23 17:19:19 2004 Jonathan Blandford <jrb@redhat.com>
409 * docs/tools/Makefile.am (clean-local): add the doc shooter to the
410 docs dir as an uninstalled helper tool.
412 2004-08-23 Matthias Clasen <mclasen@redhat.com>
414 * gdk/x11/gdkwindow-x11.c (show_window_internal): Make it compile.
416 * gdk/x11/gdkwindow-x11.h (struct _GdkToplevelX11): Add a
419 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Update
421 (show_window_internal): Update the user time when re-mapping a
422 toplevel window. (#150502, Elijah Newren)
424 2004-08-23 Matthias Clasen <mclasen@redhat.com>
426 Fix #150822, reported by Christian Persch
428 * gtk/gtklabel.c (gtk_label_ensure_layout): Set the layout width
429 appropriately when ellipsized.
430 (gtk_label_size_allocate): Only set the layout width if there
433 2004-08-23 Matthias Clasen <mclasen@redhat.com>
435 * gdk/x11/gdkwindow-x11.c (gdk_window_focus): Support the latest
436 EWMH additions to the _NET_ACTIVE_WINDOW client message
437 format. (#150668, Elijah Newren)
439 Mon Aug 23 01:17:59 2004 Matthias Clasen <maclas@gmx.de>
441 * gdk/gdkrgb.c (gdk_rgb_xpixel_from_rgb_internal): Set unused
442 bits in pixel to 1s in case they are used as alpha; copying
443 code from gdk_colormap_alloc_colors(). (#150466, Rich Wareham)
445 2004-08-22 Philip Langdale <plangdale@vmware.com>
447 * gtk/gtkaction.c (gtk_action_disconnect_proxy): Two signals
448 (gtk_action_sync_property and gtk_action_sync_sensitive) were
449 not being correctly disconnected, leading to actions continuing
450 to affect disconnected proxies. (#150607)
452 2004-08-22 Tor Lillqvist <tml@iki.fi>
454 * gdk/win32/gdkwindow-win32.c (gdk_window_new_internal,
455 gdk_window_new, gdk_window_set_skip_taskbar_hint): Don't show TEMP
456 windows in the Task Manager. Implement by calling
457 gdk_window_set_skip_taskbar_hint(TRUE) on them. (#145481, Tim
460 * gdk/win32/gdkdisplay-win32.c (enum_monitor, gdk_display_open):
461 Report whole of (primary) monitor, including any taskbars.
462 Excluding the taskbar area from the "root window" reported to GDK
463 doesn't seem to be that useful although gdk/win32 had been doing it
464 for a very long time. (#149013, see also #145467 and #148526)
466 Sun Aug 22 16:55:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
469 * gtk/gtkalignment.c:
471 Make enums match property names. Found by a script by Tommi
474 * gtk/gtkpaned.c (gtk_paned_class_init): fix min/max mixup.
476 Sun Aug 22 16:09:49 2004 Soeren Sandmann <sandmann@daimi.au.dk>
478 * gtk/gtkliststore.h (struct _GtkListStore):
479 * gtk/gtkliststore.c (gtk_list_store_init):
480 * gtk/gtkliststore.c (gtk_list_store_insert):
481 * gtk/gtkliststore.c (gtk_list_store_remove):
482 Restore length field; PyGTK and maybe others use it directly.
484 Sun Aug 22 15:46:56 2004 Soeren Sandmann <sandmann@daimi.au.dk>
486 * gtk/gtkpaned.c (gtk_paned_class_init):
487 s/CYCLE_HANDLE_FOCUS/CYCLE_CHILD_FOCUS/
489 * gtk/gtkfontbutton.c (gtk_font_button_class_init):
490 s/PROP_SHOW_SIZE/PROP_SHOW_STYLE/
492 Both pointed out by Tommi Komulainen.
494 Sun Aug 22 13:44:53 2004 Soeren Sandmann <sandmann@daimi.au.dk>
496 * gtk/gtkpaned.c (gtk_paned_class_init): Use PROP_MAX_POSITION,
497 not PROP_MIN_POSITION for the max_position property. Fix pointed
498 out by Tommi Komulainen.
500 Sun Aug 22 13:32:33 2004 Soeren Sandmann <sandmann@daimi.au.dk>
502 * gtk/gtkliststore.c (gtk_list_store_insert): Normalize the
503 position so we don't create paths with off-list
506 Sun Aug 22 12:04:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
508 * gtk/gtkliststore.c (gtk_list_store_sort_iter_changed): Use the
509 correct tree path (#150289, Morten Welinder).
511 Sun Aug 22 00:08:44 2004 Matthias Clasen <maclas@gmx.de>
513 Fix #150406, reported by Fernando San Martín Woerner, patch
516 * gtk/gtkentrycompletion.c
517 (gtk_entry_completion_default_completion_func): Check that
518 column is of type G_TYPE_STRING before proceeding.
520 Sat Aug 21 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
522 * gtk/gtktreestore.c (gtk_tree_store_swap): Don't use an
523 uninitialized tree iter. (#150414, Torsten Schoenfeld)
525 Sat Aug 21 23:29:54 2004 Matthias Clasen <maclas@gmx.de>
527 Fix #150738, Tomislav Jonjic.
529 * gtk/gtktoolitem.h (GTK_IS_TOOL_ITEM_CLASS):
530 * gtk/gtktoolbutton.h (GTK_IS_TOOL_BUTTON_CLASS):
531 * gtk/gtktoggleaction.h (GTK_IS_TOGGLE_ACTION_CLASS):
532 * gtk/gtkseparatortoolitem.h (GTK_IS_SEPARATOR_TOOL_ITEM_CLASS):
533 * gtk/gtkradiotoolbutton.h (GTK_IS_RADIO_TOOL_BUTTON_CLASS):
534 * gtk/gtkradioaction.h (GTK_IS_RADIO_ACTION_CLASS):
535 * gtk/gtkuimanager.h (GTK_IS_UI_MANAGER_CLASS):
536 * gtk/gtkaction.h (GTK_IS_ACTION_CLASS): Fix macro definitions.
538 Wed Aug 18 17:25:26 2004 Manish Singh <yosh@gimp.org>
540 * demos/testpixbuf-save.c
541 * demos/gtk-demo/hypertext.c: Get rid of some unnecessary casts.
543 * demos/gtk-demo/appwindow.c: Make activate_email and activate_url
544 match the arguments for GtkAboutDialogActivateLinkFunc.
546 Wed Aug 18 16:18:00 2004 Manish Singh <yosh@gimp.org>
548 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): Initialize height
549 from fixed_height before we do anything, so it always has a valid
552 * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Fix call
553 to gtk_tree_model_get (missing "," in param list).
555 2004-08-18 Federico Mena Quintero <federico@ximian.com>
561 * gtk/gtkfilechooserdefault.c: Renamed SHORTCUTS_COL_PATH to
562 SHORTCUTS_COL_DATA. Add SHORTCUTS_COL_IS_VOLUME, to determine
563 easily whether the SHORTCUTS_COL_DATA points to a GtkFilePath or a
565 (shortcuts_model_create): Create a boolean column for
566 SHORTCUTS_COL_IS_VOLUME.
567 (shortcuts_reload_icons): Simplify with the use of the
568 SHORTCUTS_COL_IS_VOLUME column. Don't leak the pixbuf.
569 (shortcuts_insert_path): Add the SHORTCUTS_COL_IS_VOLUME data.
570 (shortcuts_free_row_data): New helper function; frees the data
572 (shortcuts_remove_rows): Don't take a callback for freeing the
573 data; free everything here instead. Use
574 shortcuts_free_row_data().
575 (volume_remove_cb): Removed.
576 (remove_bookmark_cb): Removed.
577 (remove_row_cb): Make this a single generic function to delete
579 (shortcuts_add_volumes): Use remove_row_cb().
580 (shortcuts_add_bookmarks): Likewise.
581 (struct _GtkFileChooserDefault): Removed the
582 shortcuts_current_folder_is_volume field.
583 (shortcuts_add_current_folder): Oops, don't free the volume.
584 (remove_current_folder_cb): Removed.
585 (shortcut_find_position): Simplify through the use of the
586 SHORTCUTS_COL_IS_VOLUME column.
587 (remove_selected_bookmarks): Assert that we don't get a volume.
588 (shortcuts_reorder): Likewise; also, plug a leak.
589 (gtk_file_chooser_default_remove_shortcut_folder): Simplify
590 through the use of shortcuts_remove_rows().
591 (gtk_file_chooser_default_list_shortcut_folders): Assert that we
593 (shortcuts_activate_iter): Simplify.
594 (home_folder_handler): Simplify by using
595 shortcuts_activate_iter().
596 (shortcuts_free): New function; frees all the data columns.
597 (gtk_file_chooser_default_finalize): Unref the
598 shortcuts_filter_model and the shortcuts model data first.
600 Wed Aug 18 08:31:17 2004 Manish Singh <yosh@gimp.org>
602 * gtk/gtkiconview.c: Applied patch from Olivier Andrieu to fix
605 * gtk/gtkicontheme.c (gtk_icon_theme_init): xdg_data_dirs should
606 match constness attributes of g_get_system_data_dirs ().
608 2004-08-17 Matthias Clasen <mclasen@redhat.com>
610 * gtk/gtkicontheme.c (gtk_icon_theme_init): Look up icon themes in the
611 directories specified in the icon theme spec: $HOME/.icons,
612 $XDG_DATA_DIRS/icons, /usr/share/pixmaps. Note that GTK+ used to also look
613 in $GTK_DATA_DIR/icons, $GTK_DATA_DIR/pixmaps and /usr/share/icons. (#148694)
616 * gtk/gtkframe.c (gtk_frame_paint): Take widget->state into account when
617 painting the shadows. (#150351, Tim Janik)
619 2004-08-17 Matthias Clasen <mclasen@redhat.com>
621 * gtk/abicheck.sh: No need for INCLUDE_INTERNAL_SYMBOLS anymore.
623 * gdk/gdk.symbols: Don't use #if defined().
625 * gdk/Makefile.am (gdkalias.h):
626 * gtk/Makefile.am (gtkalias.h): Don't use cpp to filter gtk.symbols.
628 * gdk/makegdkalias.pl:
629 * gtk/makegtkalias.pl: Move the #ifdef processing into the perl script, and
630 keep the #ifdefs which differentiate between platforms.
632 * gtk/Makefile.am (gtk_private_h_sources): Remove gtkinternals.h, it is no
635 2004-08-17 Matthias Clasen <mclasen@redhat.com>
637 * tests/testfilechooserbutton.c: Use g_message() throughout, add RTL envar for
640 * gtk/gtkfilechooserbutton.c: Get rid of HAVE_CONFIG_H.
641 (gtk_file_chooser_button_init): Use gtk_drag_dest_add_text_targets().
642 (gtk_file_chooser_button_drag_data_received): Use gtk_selection_data_get_text().
643 (gtk_file_chooser_button_set_dialog): _gtk_file_chooser_entry_set_base_folder()
644 seems to expect a path, not an uri.
645 (update_dialog): Handle g_filename_from_uri() returning NULL, don't free
648 * gtk/gtkfilechooserbutton.h: Minor stylistic changes.
650 2004-08-17 Matthias Clasen <mclasen@redhat.com>
652 * gtk/gtkfilechooserbutton.[hc]: New widget to go along with
653 GtkFontButton and GtkColorButton for use in preference dialogs.
654 Replaces GnomeFileEntry. (#148108, James M. Cape)
656 * gtk/gtk.h: Include gtkfilechooserbutton.h
658 * gtk/Makefile.am (gtk_public_h_sources): Add gtkfilechooserbutton.h
659 (gtk_c_sources): Add gtkfilechooserbutton.c
661 * gtk/gtk.symbols: Add the GtkFileChooserButton symbols.
663 * gtk/gtkfilechooserutils.[hc]: Make the delegate quark available.
665 * gtk/gtkfilechooserentry.[hc] (_gtk_file_chooser_entry_new): Allow
666 to suppress tab-eating using the new eat_tabs argument. Adjust all
669 * tests/testfilechooserbutton.c: Test for GtkFileChooserButton.
671 * tests/Makefile.am (noinst_PROGRAMS): Add testfilechooserbutton
673 2004-08-16 Matthias Clasen <mclasen@redhat.com>
675 * gtk/gtkwidget.c (gtk_widget_render_icon): Doc update.
677 * gtk/gtkiconfactory.c (render_icon_name_pixbuf): When the size is -1,
678 use the available size closest to 48. (#150147)
680 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): Actually return
681 a pointer to the beginning of the sizes array, not the end.
683 2004-08-16 Morten Welinder <terra@gnome.org>
685 * tests/testtreemodel.c (test_run): Comment out mallinfo stuff.
686 Fix g_print %-strings.
688 * gtk/gtksequence.c (_gtk_sequence_set): Fix C99ism.
690 2004-08-16 Christian Rose <menthos@menthos.com>
692 * configure.in: Added "bs" to ALL_LINGUAS.
694 Mon Aug 16 01:35:25 2004 Matthias Clasen <maclas@gmx.de>
697 * gtk/gtkcombobox.[hc]: Add a ::focus-on-click property and
698 change the default behaviour to focus on click.
700 * gtk/gtkbutton.c (gtk_button_set_focus_on_click): Typo fix.
702 Mon Aug 16 01:03:08 2004 Matthias Clasen <maclas@gmx.de>
704 * gtk/gtktextiter.c (gtk_text_iter_set_visible_line_offset):
705 (gtk_text_iter_set_visible_line_index): Count from the
706 beginning of the line, not from the current position. (#150101,
709 2004-08-15 Tor Lillqvist <tml@iki.fi>
711 * gtk-zip.sh.in: Fix typo. The gtk.immodules file had never been
712 included in my zipfiles...!
714 * gtk/gtkfilesystemwin32.c (extract_icon): Improve handling of
715 icon alpha channel (on Windows XP) and mask (older Windows
716 versions). (#148641, Tim Evans)
718 Sun Aug 15 02:31:55 2004 Matthias Clasen <maclas@gmx.de>
720 * gtk/gtkfilesystemunix.c (get_icon_type_from_stat): Make
721 the use of S_ISFIFO and S_ISSOCK conditional. (#150146,
724 2004-08-14 Tor Lillqvist <tml@iki.fi>
726 * gtk/gtkfilechooserdefault.c (shortcuts_append_home,
727 shortcuts_append_desktop, set_local_only)
728 * gtk/gtkfilesystemwin32.c (gtk_file_system_win32_render_icon)
729 * gtk/gtkpathbar.c (find_button_type, _gtk_path_bar_set_file_system):
730 Guard against g_get_home_dir() returning NULL. (#150007)
732 Sat Aug 14 17:56:33 2004 Soeren Sandmann <sandmann@daimi.au.dk>
734 * gtk/gtkentry.c (gtk_entry_get_pixel_ranges): New function.
736 * gtk/gtkentry.c (in_selection): New function using
737 gtk_entry_get_pixel_ranges() to determine whether a click is in
738 the selection. Improve entry behavior wrt. dragging and
739 selecting. Bug #143249.
741 Sat Aug 14 17:53:46 2004 Soeren Sandmann <sandmann@daimi.au.dk>
743 * configure.in: Require glib 2.5.2
745 * gtk/gtksequence.[ch]: New internal data structure.
747 * gtk/gtkliststore.[hc]: Reimplement in terms of new data
750 * tests/Makefile.am (testtreemodel_SOURCES):
751 * tests/testtreemodel.c: New test program written by Matthias.
753 2004-08-13 Matthias Clasen <mclasen@redhat.com>
755 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_style_set):
756 Don't install the settings_notify_cb from here, since it
757 may be called before the first screen_changed signal,
758 confusing the logic in gtk_file_chooser_screen_changed().
759 (#148803, Abel Daniel)
761 * gtk/gtkcombobox.c: Make re-sensitivation work
764 * gtk/gtkaction.c (gtk_action_new): Fix the docs.
766 Fri Aug 13 01:06:56 2004 Matthias Clasen <maclas@gmx.de>
768 * gtk/gtktreeview.c (gtk_tree_view_row_inserted):
769 Make fixed height mode handle insertions. (#135955,
770 Michael Vogt, testcase by Tim-Philipp Müller, fix by
773 Fri Aug 13 00:40:18 2004 Matthias Clasen <maclas@gmx.de>
775 * gtk/gtkhandlebox.c: Add missing include.
777 Thu Aug 12 23:52:12 2004 Matthias Clasen <maclas@gmx.de>
779 Fix #149547, Markus Lausser:
781 * gtk/gtkcombobox.c (gtk_combo_box_size_allocate):
782 * gtk/gtkcombobox.c (gtk_combo_box_size_request): Don't
783 crash if size_request or size_allocate are called early.
785 * gtk/gtkcombobox.c (gtk_combo_box_size_allocate): Protect
786 against being allocated too small.
788 Thu Aug 12 21:02:57 2004 Matthias Clasen <maclas@gmx.de>
790 * demos/gtk-demo/appwindow.c (about_cb): Adjust to GtkAboutDialog
793 * gtk/gtkaboutdialog.h:
794 * gtk/gtkaboutdialog.c (gtk_about_dialog_set_email_hook):
795 (gtk_about_dialog_set_url_hook): Add callback data and destroy notify
796 for language bindings. (#149999, Olivier Andrieu)
798 2004-08-12 Matthias Clasen <mclasen@redhat.com>
800 * gtk/gtkfilesystem.c: Underscore-prefix gtk_file_system_module_get_type().
801 * gtk/gtkfilechooserdefault.c: Underscore-prefix shortcuts_model_filter_get_type().
803 * gtk/gtkimmodule.c: Make gtk_im_module_get_type() static.
805 * gtk/gtkinternals.h: Remove the no longer exported get_type functions.
807 Thu Aug 12 01:35:46 2004 Matthias Clasen <maclas@gmx.de>
809 * gtk/gtkiconview.c: Make the icon view accessible by
810 implementing the necessary ATK interfaces. (#149728,
813 Thu Aug 12 00:02:29 2004 Matthias Clasen <maclas@gmx.de
815 * gtk/gtkaction.c (gtk_action_new): Link to information about
816 allowed action names. (#149620, David Malcolm)
818 Wed Aug 11 23:14:25 2004 Matthias Clasen <maclas@gmx.de>
822 * gtk/gtkaction.c (gtk_action_set_sensitive):
823 (gtk_action_set_visible): Add setters for the ::sensitive
824 and ::visible properties of GtkAction. (#149622, David Malcolm)
826 2004-08-11 Federico Mena Quintero <federico@ximian.com>
828 Fix #149422, #143457:
830 * gtk/gtkfilechooserdefault.c
831 (gtk_file_chooser_default_should_respond): Rewrite to take the
832 current focus into account, the contents of the save entry, and
833 the last focus for the shortcuts list.
834 (switch_to_selected_folder): We don't need an assertion on the
837 Wed Aug 11 20:56:00 2004 Matthias Clasen <maclas@gmx.de>
839 * gtk/gtkinternals.h:
840 * gtk/gtk.symbols: Add shortcuts_model_filter_get_type.
842 * gtk/abicheck.sh: Check all symbols.
844 Wed Aug 11 19:20:34 2004 Matthias Clasen <maclas@gmx.de>
846 * gtk/gtktreeview.c (gtk_tree_view_maybe_begin_dragging_row):
847 Don't start a drag if the treeview is only a
848 drag destination. (#149836, Pawel Salek)
850 2004-08-11 Matthias Clasen <mclasen@redhat.com>
852 * gtk/gtktreedatalist.[hc]:
853 * gtk/gtkliststore.c:
854 * gtk/gtktreestore.c: Underscore-prefix
855 gtk_tree_data_list_compare_func.
857 * gtk/gtk.symbols: Remove gtk_tree_data_list_compare_func.
859 * gtk/makegtkalias.pl: No need to include gtktreedatalist.h
862 2004-08-10 Matthias Clasen <mclasen@redhat.com>
865 * gtk/Makefile.am: Define TESTS, not TEST, so that make check
866 actually triggers abicheck.sh.
868 * gdk/makegdkalias.pl:
869 * gtk/makegtkalias.pl: Include glib.h before using glib symbols. D'oh.
871 * gdk/makegdkalias.pl:
872 * gtk/makegtkalias.pl: Protect gtkalias.h by G_HAVE_GNUC_VISIBILITY.
874 * gtk/Makefile.am: Include gtkalias.h in the generated
875 sources gtkmarhalers.c and gtkmarshal.c.
877 * gtk/makegtkalias.pl: Cosmetic fix.
879 * gdk/Makefile.am: Remove the . which was accidentally added
880 to SUBDIRS. Include gdkalias.h in the generated sources
881 gdkenumtypes.c and gdkmarshalers.c.
883 * gdk/makegdkalias.pl: Cosmetic fix.
885 * gdk/Makefile.am: Add gdkalias.h to BUILT_SOURCES.
887 2004-08-09 Hans Breuer <hans@breuer.org>
889 * gtk/makefile.msc.in : autogenerate gtk.def, cleanup
891 * gdk/win32/gdkwindow-win32.c gdk/win32/gdkevents-win32.c :
892 removed long time unused ifdef/ed code (WITHOUT_WM_CREATE),
893 removed duplicated call to gdk_window_set_cursor()
895 Mon Aug 9 15:41:17 2004 Matthias Clasen <maclas@gmx.de>
897 Add hidden aliases for exported symbols which are
898 used internally in order to get rid of many PLT
899 entries. (#145519, Arjan van de Ven)
901 * gdk/Makefile.am: Add rules to generate gdk.def and
902 gdkalias.h from gdk.symbols, and make make check check
903 the abi with abicheck.sh.
905 * gdk/gdk.symbols: New file. Definition of the GDK ABI.
906 The file can be processed by cpp to filter out certain
909 * gdk/abicheck.sh: New file. Script to check the actually
910 symbols exported from libgdk-x11.2.0.so against the symbols
911 found in gdk.symbols.
913 * gdk/makegdkalias.pl: New file. Perl script to generate the
914 header containing the alias definitions for internally used
915 exported symbols from a list of symbols.
917 * gdk/*.c, gdk/x11/*.c: Include gdkalias.h
919 2004-08-09 Morten Welinder <terra@gnome.org>
921 * gdk/x11/gdkdnd-x11.c (gdk_drag_drop_succeeded): Fix C99ism.
923 Mon Aug 9 15:27:01 2004 Matthias Clasen <maclas@gmx.de>
925 * gtk/makegtkalias.pl: Also revert
926 GTK_TEXT_USE_INTERNAL_UNSUPPORTED_API to its old status.
928 Mon Aug 9 15:19:34 2004 Matthias Clasen <maclas@gmx.de>
931 * gdk/gdkrgb.h: Add the exported functions
932 gdk_rgb_colormap_ditherable(), gdk_pointer_grab_info_libgtk_only(),
933 gdk_keyboard_grab_info_libgtk_only() to the appropriate
936 Mon Aug 9 14:24:46 2004 Matthias Clasen <maclas@gmx.de>
938 * gdk/x11/gdkevents-x11.c (gdk_event_send_client_message_to_all_recurse):
941 Mon Aug 9 12:48:04 2004 Matthias Clasen <maclas@gmx.de>
943 Add hidden aliases for exported symbols which are
944 used internally in order to get rid of many PLT
945 entries. (#145519, Arjan van de Ven)
947 * gtk/Makefile.am: Add rules to generate gtk.def and
948 gtkalias.h from gtk.symbols, and make make check check
949 the abi with abicheck.sh.
950 (gtk_private_h_sources): Add gtkinternals.h
951 (gtk_built_private_headers): Add gtkalias.h
952 (gtk_extra_sources): Add gtk.symbols
953 (EXTRA_DIST): Add makegtkalias.pl and abicheck.sh
955 * gtk/gtk.symbols: New file. Definition of the GTK+ ABI.
956 The file can be processed by cpp to filter out certain
959 * gtk/abicheck.sh: New file. Script to check the actually
960 symbols exported from libgtk-x11.2.0.so against the symbols
961 found in gtk.symbols.
963 * gtk/makegtkalias.pl: New file. Perl script to generate the
964 header containing the alias definitions for internally used
965 exported symbols from a list of symbols.
967 * gtk/gtkinternals.h: New file. An uninstalled header listing
968 symbols which must be exported for some reason and do not appear
971 * gtk/*.c: Include gtkalias.h
973 Mon Aug 9 11:49:46 2004 Matthias Clasen <maclas@gmx.de>
975 * gtk/gtkmain.c: Only undef gtk_init_check and gtk_init on win32.
977 Mon Aug 9 10:50:05 2004 Matthias Clasen <maclas@gmx.de>
979 * gtk/gtkentry.h: Add gtk_entry_layout_index_to_text_index()
980 and its inverse. The have always been exported and are meant
983 Mon Aug 9 00:28:34 2004 Matthias Clasen <maclas@gmx.de>
985 * gtk/gtkicontheme.c (load_svg_at_size): Don't leak the
988 Mon Aug 9 00:13:03 2004 Matthias Clasen <maclas@gmx.de>
990 * gtk/gtkaboutdialog.c (icon_set_new_from_pixbufs): Don't
991 leak the icon source.
993 Sun Aug 8 23:46:20 2004 Matthias Clasen <maclas@gmx.de>
995 * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Don't
996 leak a reference to the pixbufs.
998 Sun Aug 8 23:36:55 2004 Matthias Clasen <maclas@gmx.de>
1000 * gtk/gtkcombobox.c (gtk_combo_box_menu_setup): Ref
1001 and sink the column.
1002 (gtk_combo_box_menu_destroy): Unref the column.
1004 Sun Aug 8 23:35:00 2004 Matthias Clasen <maclas@gmx.de>
1006 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets):
1007 (gtk_drag_dest_add_text_targets): Don't leak a reference
1010 Sun Aug 8 22:52:26 2004 Matthias Clasen <maclas@gmx.de>
1012 * gtk/gtkcombobox.c (find_menu_by_path): Don't stumble over
1013 separators which are not backed by model rows.
1015 Sun Aug 8 11:01:23 2004 Matthias Clasen <maclas@gmx.de>
1017 * gtk/gtkcombobox.c (gtk_combo_box_set_active): Don't leak
1020 2004-08-08 Hans Breuer <hans@breuer.org>
1022 * gtk/gtkdnd.c (gtk_drag_dest_set) : take targets into
1023 account again to allow dnd of other things than text
1025 * gdk/win32/gdkselection-win32.c : offer windows bitmap to
1026 be pasted from clipboard (makes The GIMP 2.1's
1027 "File/Acquire/Paste as New" work, only using gtk+ API)
1029 Sun Aug 8 01:32:36 2004 Matthias Clasen <maclas@gmx.de>
1031 * gtk/gtk.def: Add gtk_cell_renderer_progress_get_type.
1033 Sun Aug 8 01:29:08 2004 Matthias Clasen <maclas@gmx.de>
1035 * gtk/gtk.def: Replace duplicate gtk_tree_view_get_hover_expand
1036 by gtk_tree_view_set_hover_expand.
1038 Sun Aug 8 01:23:08 2004 Matthias Clasen <maclas@gmx.de>
1040 * gtk/gtk.def: Remove the static function gtk_menu_get_private.
1042 2004-08-07 Tor Lillqvist <tml@iki.fi>
1044 * gdk/win32/gdkkeys-win32.c (update_keymap): Don't hardcode
1045 mapping of VK_DECIMAL to GDK_KP_Decimal. Instead, let ToAsciiEx()
1046 map it to what's printed on the keypad decimal key for the current
1047 input locale (keyboard layout). (#149404)
1049 Sat Aug 7 18:19:03 2004 Matthias Clasen <maclas@gmx.de>
1051 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
1052 (shortcuts_list_create): Use GtkTreeViewRowSeparatorFunc
1053 instead of GtkCellRendererSepText. (#147864)
1055 * gtk/gtkcellrendererseptext.[hc]: Removed.
1057 * gtk/Makefile.am: Remove gtkcellrendererseptext.[hc]
1059 Sat Aug 7 18:15:15 2004 Matthias Clasen <maclas@gmx.de>
1061 * gtk/gtkcombobox.c (gtk_combo_box_menu_row_deleted):
1062 (gtk_combo_box_menu_row_inserted):
1063 (gtk_combo_box_menu_row_changed): Correctly handle
1064 insertion and deletion of separators in menu mode.
1066 2004-08-07 Tor Lillqvist <tml@iki.fi>
1068 * gdk/win32/gdkevents-win32.c (handle_configure_event,
1069 gdk_event_translate:WM_WINDOWPOSCHANGED): Add _gdk_offset_{x,y} to
1070 top-level window coordinates, not just in generated
1071 events. (#148526, Robert Ögren)
1073 Sat Aug 7 01:26:08 2004 Matthias Clasen <maclas@gmx.de>
1075 Make the column drag code a bit more robust (still scary,
1076 though). (#106992, Christian Biere)
1078 * gtk/gtktreeview.c (_gtk_tree_view_column_start_drag): Assert
1079 that cur_reorder is NULL here.
1081 * gtk/gtktreeview.c (gtk_tree_view_button_release_drag_column):
1082 Reset cur_reorder to NULL, and only hide drag_highlight_window
1085 2004-08-06 Federico Mena Quintero <federico@ximian.com>
1089 * gtk/gtkfilechooserdefault.c (save_widgets_create): Use a
1090 GtkFileChooserEntry for the file name, rather than a GtkEntry.
1091 (update_chooser_entry): Set the contents of the file chooser entry
1092 rather than the plain entry's.
1093 (gtk_file_chooser_default_set_current_folder): Set the new folder
1095 (gtk_file_chooser_default_set_current_name): Set the name on the
1097 (check_save_entry): Use the file chooser entry rather than the
1100 * gtk/gtkfilechooserentry.c
1101 (_gtk_file_chooser_entry_set_base_folder): Call
1102 gtk_file_chooser_entry_changed() so that we recompute the current
1103 folder based on the new base folder.
1105 2004-08-06 Hans Breuer <hans@breuer.org>
1107 * gdk/win32/gdkwindow-win32.c : make it compile and more
1108 similar to the X11 implementation [backward compatibility
1109 for GDK_WINDOW_TEMP, GDK_INPUT_ONLY (fixes bug #148702),
1110 use the *screen* function variants, dont reparent already
1112 (get_visible_region) : take the win32 part into account
1113 (_gdk_windowing_window_destroy) : remove from handle table
1115 * gdk/win32/gdkdisplay-win32.c : added
1116 gdk_display_(request|supports)_selection_notification ()
1117 with a currently mostly pointless implementation ;-)
1119 * gtk/gtkfilesystemwin32.c (*_to_path) : same changes as on *NIX,
1121 (gtk_file_system_win32_render_icon) : use new GTK_STOCK_DIRECTORY
1123 * gtk/makefile.msc.in demos/gtk-demo/makefile.msc.in
1124 gtk/stock-icons/makefile.msc tests/makefile.msc : updated
1126 * gdk/gdk.def gtk/gtk.def : updated externals
1128 * tests/testiconview.c : remove unneeded dirent.h inclusion
1130 2004-08-06 Matthias Clasen <mclasen@redhat.com>
1132 * gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): Fix
1133 an off-by-one error. (#141809, Markku Vire)
1135 * gtk/gtkdnd.c (gtk_drag_dest_set, gtk_drag_source_set): Really
1136 fix the initialization of the target list.
1138 Support XDND v5. (#10220, Owen Taylor)
1140 * gdk/x11/gdkdnd-x11.c: Record the XDND version and whether the
1141 drop was successful in the GdkDragContextPrivateX11 struct.
1142 (xdnd_finished_filter): Store the success status of the drop
1143 for an XDND version 5 interaction. For other versions, always
1144 assume the drop was successful.
1145 (xdnd_check_dest): Return the protocol version.
1146 (_gdk_drag_get_protocol_for_display): Return the protocol version.
1147 (gdk_drag_find_window_for_screen): Store the used protocol version
1148 in the GdkDragContext.
1149 (xdnd_send_enter): Send the used protocol version from the context,
1150 instead of hardwiring 3.
1151 (xdnd_enter_filter): Accept protocol versions >= 3 and store the
1152 used protocol version in the context.
1155 * gdk/x11/gdkdnd-x11.c (gdk_drag_drop_succeeded): New function
1156 to find out whether a drop was successful.
1158 2004-07-28 Robert Ögren <gtk@roboros.com>
1160 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Set x_root
1161 and y_root in button and motion events from the tablet. (#148715)
1163 Thu Aug 5 19:58:08 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1165 * gtk/gtkplug.c (gtk_plug_realize): Call
1166 gdk_window_enable_synchronized_configure()
1168 * gdk/x11/gdkwindow-x11.c (gdk_window_configure_finished): Make
1169 noop if gdk_window_enable_synchronized_configure() has not been
1172 2004-08-04 Matthias Clasen <mclasen@redhat.com>
1174 * gtk/gtkfilechooser.[hc]: Add setter and getter for the
1175 ::show-hidden property. (#145610, Jeff Franks)
1177 * tests/testiconview.c: Add buttons to select and unselect all
1178 nodes, make the popup menu actually work.
1180 * gtk/gtkiconview.c: Make GTK_SELECTION_BROWSE work as intended,
1181 let button 3 presses through to the app, to make popup menus
1184 * tests/Makefile.am: Add testiconview.
1185 * tests/testiconview.c: A test for GtkIconView
1186 * tests/gnome-textfile.png: ...which uses this image.
1188 Wed Aug 4 01:37:57 2004 Matthias Clasen <maclas@gmx.de>
1190 * gtk/gtktreeview.c:
1191 * gtk/gtktreestore.c:
1192 * gtk/gtktreemodelfilter.c:
1193 * gtk/gtknotebook.c: s/childs/children/g.
1195 Wed Aug 4 01:04:48 2004 Matthias Clasen <maclas@gmx.de>
1197 Fix #133446, noticed by Christian Persch:
1199 * gtk/gtkaction.c (gtk_action_class_init): Add a new boolean
1200 property ::visible-overflown.
1201 * gtk/gtkaction.c (gtk_action_create_menu_proxy): Don't create
1202 a menu proxy if visible_overflown is FALSE.
1204 Tue Aug 3 20:16:26 2004 Matthias Clasen <maclas@gmx.de>
1206 * gtk/gtkactiongroup.[hc]: Make the the GtkAction{Toggle,Radio,}Entry*
1207 arguments to the gtk_action_group_add_..._actions() functions const,
1208 since the most common use case is to use a static array. (142334,
1209 Mariano Suarez-Alvarez)
1211 Tue Aug 3 20:03:33 2004 Matthias Clasen <maclas@gmx.de>
1213 * gtk/gtkuimanager.c (get_node): Make gtk_ui_manager_add_ui()
1214 accept paths with a leading "/ui". (#149077, David Malcolm)
1216 Tue Aug 3 19:59:29 2004 Matthias Clasen <maclas@gmx.de>
1218 * gtk/gtkiconview.c: Fix some warnings.
1220 Tue Aug 3 18:38:40 2004 Matthias Clasen <maclas@gmx.de>
1222 * gtk/gtktreemodelfilter.c: Correct the return type
1223 of gtk_tree_model_filter_get_flags(). (#149195, Morten Welinder)
1225 Tue Aug 3 18:16:55 2004 Matthias Clasen <maclas@gmx.de>
1227 Fix #149191, reported by Morten Welinder:
1229 * gtk/gtkmain.c: Include gtkclipboard.h,
1230 * gtk/gtkwidget.h: Declare _gtk_widget_grab_notify, not
1231 _gtk_widget_emit_grab_notify.
1233 Tue Aug 3 14:50:14 2004 Matthias Clasen <maclas@gmx.de>
1235 * gtk/gtkicontheme.c (add_size): Add missing parens.
1236 (#149190, Morten Welinder)
1238 Tue Aug 3 14:29:49 2004 Matthias Clasen <maclas@gmx.de>
1240 * gtk/gtkcombobox.c (gtk_combo_box_menu_fill): Remove
1241 accidentally committed debug code.
1243 Tue Aug 3 01:19:12 2004 Matthias Clasen <maclas@gmx.de>
1245 * gtk/gtkcombobox.c (gtk_combo_box_relayout_item): Optimize
1246 for the case that row_column and col_column are unset.
1247 (#148868, Lorenzo Gil Sánchez)
1249 Mon Aug 2 21:52:45 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1251 * gdk/x11/gdkwindow-x11.c (ensure_sync_counter): New
1252 function. Make sure the sync counter is recreated when a window is
1253 reparented to become a toplevel. (#148358)
1255 2004-08-02 Matthias Clasen <mclasen@redhat.com>
1257 * tests/testcombo.c: Some trees in combo boxes.
1259 * gtk/gtkcombobox.c: Rework the combo box to handle
1260 tree models. (#139582, Matt Walton)
1262 * gtk/gtktreeview.h:
1263 * gtk/gtktreeview.c:
1264 * gtk/gtktreeprivate.h: Add a new boolean property
1265 ::hover-expand and make the treeview expand/collapse rows
1266 on mouseover if it is set.
1268 * gtk/gtkiconview.h: Remove some erroneous declarations.
1270 * gtk/gtkcellview.c (gtk_cell_view_set_cell_data): Don't
1271 crash if the displayed row is gone.
1273 2004-08-02 Morten Welinder <terra@gnome.org>
1275 * gtk/gtkentry.c (gtk_entry_motion_notify): C99ism.
1277 Mon Aug 2 01:30:03 2004 Matthias Clasen <maclas@gmx.de>
1279 * gtk/gtktextview.[hc]:
1280 * gtk/gtkentry.[hc]: Add a new binding signal ::backspace,
1281 bind it to the backspace key, and make it pay attention
1282 to the Pango backspace_deletes_character
1283 attribute. (#119891, Noah Levitt, patch by Theppitak
1286 Mon Aug 2 01:02:57 2004 Matthias Clasen <maclas@gmx.de>
1288 * gdk/x11/gdkevents-x11.c (gdk_check_wm_state_changed):
1289 (gdk_check_wm_desktop_changed): Add missing error
1290 traps. (#149011, Thomas Leonard)
1292 Mon Aug 2 00:21:26 2004 Matthias Clasen <maclas@gmx.de>
1294 * gtk/gtktextview.c (blink_cb): Add the same warning
1295 that the blink_cb() in GtkEntry already has. (#148733)
1297 Mon Aug 2 00:12:16 2004 Matthias Clasen <maclas@gmx.de>
1299 * gtk/gtkentry.c (gtk_entry_class_init):
1300 (gtk_entry_get_alignment):
1301 (gtk_entry_set_alignment): Document the xalign property
1302 and its getter and setter as 2.4 additions. (#148978,
1305 Mon Aug 2 00:11:31 2004 Matthias Clasen <maclas@gmx.de>
1307 * gtk/gtkuimanager.c (gtk_ui_manager_class_init):
1308 * gtk/gtkactiongroup.c (gtk_action_group_class_init): Use
1309 canonical signal names in doc comments, since gtk-doc won't
1310 pick up signal docs with underscores.
1312 2004-08-01 Matthias Clasen <mclasen@redhat.com>
1314 * configure.in: Post-release version bump
1316 * === Released 2.5.1 ===
1318 Thu Jul 29 16:36:42 2004 Jonathan Blandford <jrb@redhat.com>
1320 * gtk/gtktreeprivate.h: New arguments
1322 * gtk/gtktreeview.c:
1323 (gtk_tree_view_class_init): Add key_release callback
1324 (gtk_tree_view_init): Initialize timeout handler
1325 (gtk_tree_view_unrealize): clear timeout if needed
1326 (gtk_tree_view_key_press): Typeahead support
1327 (gtk_tree_view_key_release): Not used yet -- will be needed for
1329 (gtk_tree_view_search_entry_flush_timeout): Remove typeahead entry
1331 (gtk_tree_view_ensure_interactive_directory):
1332 (gtk_tree_view_real_start_interactive_search):
1333 (gtk_tree_view_search_init):
1334 (gtk_tree_view_start_interactive_search): Typeahead support added.
1335 (gtk_tree_view_search_dialog_hide): Clear timeout and text when we
1338 Sat Jul 31 23:17:44 2004 Matthias Clasen <maclas@gmx.de>
1342 Sat Jul 31 01:13:01 2004 Matthias Clasen <maclas@gmx.de>
1346 * gtk/gtkaction.c: Use the canonical form of signal names
1347 after "notify::". Otherwise, no notification arrives.
1348 GObject should have a warning for that, really. (#148879,
1349 Lorenzo Gil Sánchez)
1351 Sat Jul 31 00:42:08 2004 Matthias Clasen <maclas@gmx.de>
1353 * gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_below):
1354 * gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_above): Don't
1355 set both states at once. (#148789, Matthew Garrett)
1357 2004-07-30 Matthias Clasen <mclasen@redhat.com>
1359 * gtk/gtkcombobox.c: Don't forget to destroy the row separator
1360 function user data when the combo box is destroyed.
1362 2004-07-30 Matthias Clasen <mclasen@redhat.com>
1364 * gtk/gtkcombobox.h:
1365 * gtk/gtkcombobox.c: Change the api for separators to use a
1366 separator function instead of a boolean column.
1368 * tests/testcombo.c: Update to match the api change.
1370 Fri Jul 30 02:21:41 2004 Matthias Clasen <maclas@gmx.de>
1372 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1373 Fix the positioning of the popup.
1375 Fri Jul 30 00:56:31 2004 Matthias Clasen <maclas@gmx.de>
1377 * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_active_changed):
1378 Implement this in terms of gtk_combo_box_get_active_iter(),
1379 instead of gtk_combo_box_get_active().
1381 2004-07-29 Federico Mena Quintero <federico@ximian.com>
1383 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
1384 a field for an "add to shortcuts" menu item.
1385 (popup_menu_detach_cb): Clear out the field.
1386 (file_list_build_popup_menu): Only build the menu here.
1387 (file_list_update_popup_menu): Build the menu, then update the
1388 sensitivity of its items.
1389 (file_list_popup_menu): Use file_list_update_popup_menu().
1390 (bookmarks_check_add_sensitivity): Also set the sensitivity of the
1391 popup menu item. Correctly handle the case for a *single* file.
1393 (bookmarks_add_selected_folder): New helper function; code moved
1394 over from add_bookmark_button_clicked_cb().
1395 (add_bookmark_button_clicked_cb): Use the function above.
1396 (selection_check): Rather than returning a boolean value for
1397 emptiness, actually return the number of selected rows. Also,
1399 (get_selected_path): New helper function.
1401 2004-07-29 Anders Carlsson <andersca@gnome.org>
1403 * demos/gtk-demo/Makefile.am:
1404 * demos/gtk-demo/clipboard.c: (copy_button_clicked),
1405 (paste_received), (paste_button_clicked), (do_clipboard):
1408 2004-07-28 Federico Mena Quintero <federico@ximian.com>
1410 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
1411 Store signal IDs in gulongs, not guints!
1412 (gtk_file_chooser_default_hierarchy_changed): We now monitor the
1413 focus widget on our toplevel to know which widget was last focused
1414 at the time our "should_respond" method gets called.
1415 (shortcuts_activate_selected): New helper function.
1416 (shortcuts_get_selected): New helper function.
1417 (remove_selected_bookmarks): Use shortcuts_get_selected().
1418 (bookmarks_check_remove_sensitivity): Likewise.
1419 (shortcuts_reorder): Likewise.
1420 (shortcuts_activate_iter): Renamed from shortcuts_activate_item().
1421 Activate by iter, not by item number.
1422 (save_folder_combo_changed_cb): Use shortcuts_activate_iter().
1423 (shortcuts_row_activated_cb): Likewise.
1424 (gtk_file_chooser_default_should_respond): If the last focused
1425 widget on the toplevel was the shortcuts list, activate the
1428 2004-07-28 Matthias Clasen <mclasen@redhat.com>
1430 * gdk/linux-fb/gdkprivate-fb.h: Make the fb backend compile against
1431 current freetype. (#148558, Nicolas Deves)
1433 * gtk/gtktreeview.c: Replace the EXPANDER_MAX macro by
1434 ROW_HEIGHT. (#145528)
1436 * gtk/gtkuimanager.c: Warning fixes.
1438 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_background): Fix
1439 prototype mismatch. (#148589, Nicolas Deves)
1441 2004-07-28 Anders Carlsson <andersca@gnome.org>
1443 * gdk/x11/gdkdrawable-x11.c (gdk_draw_rectangle_alpha_libgtk_only):
1444 Cast to 32-bit integers when premultiplying, suggested by Keith Packard.
1446 2004-07-27 Anders Carlsson <andersca@gnome.org>
1448 * demos/gtk-demo/iconview.c: (do_iconview):
1449 Change selection mode to multiple.
1451 * gdk/gdkdrawable.h:
1452 * gdk/linux-fb/gdkdrawable-fb2.c:
1453 (gdk_draw_rectangle_alpha_libgtk_only):
1454 * gdk/win32/gdkdrawable-win32.c:
1455 (gdk_draw_rectangle_alpha_libgtk_only):
1456 * gdk/x11/gdkdrawable-x11.c: (gdk_x11_draw_image),
1457 (get_impl_drawable), (gdk_x11_draw_pixbuf),
1458 (gdk_draw_rectangle_alpha_libgtk_only):
1459 Add gdk_draw_rectangle_alpha_libgtk_only which uses
1460 XRenderFillRectangle on X11. It's stubbed out on the
1461 Win32 and fb backends.
1463 * gtk/gtkiconview.c:
1464 (gtk_icon_view_paint_rubberband):
1465 Use gdk_draw_rectangle_alpha_libgtk_only here.
1467 2004-07-27 Anders Carlsson <andersca@gnome.org>
1469 * gtk/gtkaboutdialog.c: (gtk_about_dialog_init),
1470 (text_view_style_set), (add_credits_page),
1471 (display_credits_dialog), (display_license_dialog):
1472 Remove dialog separators, fix text view background setting,
1473 use Close buttons instead of OK buttons.
1475 2004-07-27 Matthias Clasen <mclasen@redhat.com>
1477 * gtk/gtktreeview.c (gtk_tree_view_ensure_interactive_directory):
1478 Add a frame around the C-f popup to stop it from merging visually
1479 in whatever is underneath.
1481 * gtk/gtkcombobox.h:
1482 * gtk/gtkcombobox.c (gtk_combo_box_get_popup_accessible): New
1483 function necessary to make GtkComboBox accessible. (#132847,
1486 Tue Jul 27 02:34:06 2004 Matthias Clasen <maclas@gmx.de>
1488 * gtk/gtkwidget.c (gtk_widget_dispose): Hide parentless
1489 windows when disposing them. (#133231, Michael Natterer)
1491 2004-07-26 Matthias Clasen <mclasen@redhat.com>
1493 * gtk/gtklabel.c (gtk_label_class_init): Expand the documentation
1494 for GtkLabel::ellipsize.
1496 Mon Jul 26 00:38:27 2004 Matthias Clasen <maclas@gmx.de>
1498 Make the GtkComboBox in list mode scroll if the list is too
1499 large to fit in the popup. (#135543)
1501 * gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Add a
1502 o scrolled window to the popup in list mode.
1503 (gtk_combo_box_list_position): Calculate the height of the
1504 popup so that it fits on the screen, set the scrollbar policy
1505 of the scrolled window appropriately.
1506 (gtk_combo_box_popup): Use the height calculated by
1507 gtk_combo_box_list_position().
1508 (gtk_combo_box_remeasure): Don't add unnecessary padding.
1509 (gtk_combo_box_size_request): But add the focus with here.
1510 (gtk_combo_box_list_setup): Connect to enter notify on the
1511 popup window to activate auto scrolling.
1512 (gtk_combo_box_list_enter_notify): Activate auto scrolling.
1513 (gtk_combo_box_list_button_pressed): Setup a timeout for
1515 (gtk_combo_box_list_scroll_timeout): Timeout function for
1517 (gtk_combo_box_list_auto_scroll): Scroll the list when the
1518 pointer leaves the window.
1520 Sun Jul 25 19:51:17 2004 Matthias Clasen <maclas@gmx.de>
1522 * gtk/gtknotebook.c (gtk_notebook_scroll): Ignore scroll
1523 events from the content of the page. (#148409, Gabriel
1526 Sat Jul 24 21:38:12 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1528 * gtk/gtktoolbar.c (internal_insert_element): Warn if you try to
1529 add a tool item to a toolbar using the deprecated API.
1531 Fri Jul 23 13:04:10 2004 Matthias Clasen <maclas@gmx.de>
1533 * gtk/gtkdnd.c (gtk_drag_dest_set): Revert the change to
1534 initialize target_list to an empty list instead of NULL,
1535 since it broke tree dnd. (#148215, Ernst Persson)
1537 * gtk/gtkdnd.c (gtk_drag_dest_add_text_targets):
1538 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets): Instead
1539 handle target list being NULL here.
1541 2004-07-23 Dafydd Harries <daf@muse.19inch.net>
1543 * gtk/gtkradioaction.c:
1544 * gtk/gtkradiobutton.c:
1547 Improve various translatable messages. (#137616)
1549 Fri Jul 23 11:11:10 2004 Matthias Clasen <maclas@gmx.de>
1551 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1552 Align the entry in the same way as the cell. (#136749)
1554 Fri Jul 23 11:01:00 2004 Matthias Clasen <maclas@gmx.de>
1556 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
1557 Don't iterate too far up. (#147965, Olivier Sessink)
1559 Fri Jul 23 10:28:43 2004 Matthias Clasen <maclas@gmx.de>
1561 * gtk/gtktreeview.c (gtk_tree_view_finalize):
1562 * gtk/gtkradioaction.c (gtk_radio_action_finalize):
1563 * gtk/gtkfontsel.c (gtk_font_selection_finalize):
1564 * gtk/gtkcellview.c (gtk_cell_view_finalize):
1565 * gtk/gtkcalendar.c (gtk_calendar_finalize):
1566 * gtk/gtkactiongroup.c (gtk_action_group_finalize): Remove
1567 unnecessary checks. (#148175, Morten Welinder)
1569 Thu Jul 22 01:42:16 2004 Matthias Clasen <maclas@gmx.de>
1571 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1572 Add a new :ellipsize property which controls ellipsization of the
1573 rendered text. (#144835, Vincent Untz, patch by Jonathan Blandford
1574 and Anders Carlsson)
1576 * gtk/gtkfilechooserdefault.c (create_file_list): Use ellipsization
1577 for the name column.
1579 Thu Jul 22 01:21:28 2004 Matthias Clasen <maclas@gmx.de>
1581 * gtk/gtkfontsel.c (gtk_font_selection_init): Add additional
1582 accessability relations. (#141804, Padraig O'Briain)
1584 Thu Jul 22 01:16:23 2004 Matthias Clasen <maclas@gmx.de>
1586 * gtk/gtkcombobox.c: Avoid some warnings.
1588 Thu Jul 22 01:05:16 2004 Matthias Clasen <maclas@gmx.de>
1590 * configure.in: Require Pango 1.5.1 (for ellipsisation).
1593 * gtk/gtklabel.c (gtk_label_class_init): Add a new :ellipsize
1594 property which controls ellipsization of the label. (#125250,
1595 Tim Van Wassenhove, patch by James M. Cape)
1597 * tests/testellipsise.c: Simple test for ellipsizsation.
1599 Wed Jul 21 22:46:27 2004 Matthias Clasen <maclas@gmx.de>
1601 * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the
1602 list store. (#148134, Crispin Flowerday)
1604 Wed Jul 21 22:35:47 2004 Matthias Clasen <maclas@gmx.de>
1606 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the
1607 menu. (#148110, Tommi Komulainen)
1609 Wed Jul 21 22:24:10 2004 Matthias Clasen <maclas@gmx.de>
1611 * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak
1612 tree model and tree row reference. (#148125, Crispin Flowerday)
1614 Wed Jul 21 22:17:06 2004 Matthias Clasen <maclas@gmx.de>
1616 * tests/testcombo.c (main): Don't leak models. (#148128,
1619 Wed Jul 21 21:26:08 2004 Matthias Clasen <maclas@gmx.de>
1621 * gtk/gtkviewport.c (viewport_set_adjustment): Don't leak
1622 the adjustments. (#148089, Tommi Komulainen)
1624 Wed Jul 21 21:20:21 2004 Matthias Clasen <maclas@gmx.de>
1626 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't leak
1627 the adjustments. (#148073, Tommi Komulainen)
1629 Wed Jul 21 21:04:50 2004 Matthias Clasen <maclas@gmx.de>
1631 * gtk/gtktoolbar.c (gtk_toolbar_finalize): Don't leak the
1632 arrow. (#148064, Tommi Komulainen)
1634 2004-07-21 Matthias Clasen <mclasen@redhat.com>
1636 * gtk/gtkcalendar.c: Use the new text target functionality
1637 in GtkTargetList instead of hardcoding a subset of text targets.
1639 Tue Jul 20 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
1641 * gdk/x11/gdkevents-x11.c: Hook up gtk-menu-bar-accel to
1642 an XSetting, Gtk/MenuBarAccel. (#120859, Scott James Remnant)
1644 Tue Jul 20 22:26:29 2004 Matthias Clasen <maclas@gmx.de>
1646 * gtk/gtkfilechooserutils.h:
1647 * gtk/gtktoolbutton.c:
1649 * gtk/gtkicontheme.c:
1650 * gtk/gtkcalendar.c:
1651 * demos/gtk-demo/ui_manager.c:
1652 * demos/gtk-demo/appwindow.c: Remove trailing commas
1653 from enumerations. (#148035)
1655 2004-07-20 Federico Mena Quintero <federico@ximian.com>
1657 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Fix the
1658 documentation comment for the editing-started signal.
1660 * gtk/gtkmarshalers.list: Added VOID:OBJECT,STRING for
1661 GtkCellRenderer::editing-started.
1663 2004-07-20 Matthias Clasen <mclasen@redhat.com>
1665 * tests/testactions.c (main):
1666 * tests/testmerge.c (main): Add some refcount debugging.
1668 * gtk/gtkuimanager.c (update_node, free_node): Ref an sink
1669 all proxies, so that we can properly clean up floating proxies
1670 which the app didn't adopt. (#147926, Tommi Komulainen)
1672 2004-07-20 Matthias Clasen <mclasen@redhat.com>
1674 Allow custom initialization of cell editables. (#147221)
1676 * gtk/gtkcellrenderer.h (struct _GtkCellRendererClass):
1677 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Add a
1678 ::editing-started signal as a hook for setting up the
1680 (gtk_cell_renderer_start_editing): ...and emit it here.
1682 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
1684 * gtk/gtktreeview.c (gtk_tree_view_button_press): Set drag_pos
1685 before grabbing the focus, since we may reenter into
1686 gtk_tree_view_motion_resize_column() which requires drag_pos
1687 to be set. (#147913, Guilherme Salgado, patch by John Finlay)
1689 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
1691 * gtk/gtktreeview.c (gtk_tree_view_enter_notify): Don't
1692 use uninitialized node pointer. (#147911, Peter Zelezny)
1694 Tue Jul 20 04:34:56 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1696 * configure.in: Bump version number
1698 Sun Jul 18 17:21:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1700 * === Released 2.5.0 ===
1704 * tests/testcombo.c: Fix compilation
1706 2004-07-19 Matthias Clasen <mclasen@redhat.com>
1708 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_popup_completion):
1711 2004-07-19 Matthias Clasen <mclasen@redhat.com>
1713 Make GtkCellView public, since people seem to have uses for it,
1714 it is clean API and we were just conservative in not making it
1715 public initially. At the same time, get rid of GtkCellViewMenuItem,
1716 which doesn't have any function which can't be served by a
1717 GtkMenuItem with a GtkCellView child. (#136637, Padraig O'Briain)
1719 * gtk/gtk.h: Include gtkcellview.h
1721 * gtk/Makefile.am (gtk_public_h_sources):
1723 * gtk/Makefile.am (gtk_private_h_sources):
1724 (gtk_c_sources): Remove gtkcellviewmenuitem.[hc]
1725 * gtk/gtkcombobox.c: Replace all uses of GtkCellViewMenuItem by
1726 GtkMenuItem with a GtkCellView child.
1728 * gtk/gtkcellviewmenuitem.[hc]: Removed.
1730 2004-07-19 Matthias Clasen <mclasen@redhat.com>
1732 Support inline autocompletion in entries (#135953)
1734 * gtk/gtkentryprivate.h:
1735 * gtk/gtkentrycompletion.h:
1736 * gtk/gtkentrycompletion.c (gtk_entry_completion_class_init):
1737 Add a new signal ::insert-prefix which can be used to override
1738 the default inline-completion behaviour. Add two new boolean
1739 properties, :popup_completion and :inline_completion which
1740 determine how the possible completions should be presented.
1741 (gtk_entry_completion_insert_prefix): New function to request
1744 * gtk/gtkentry.c: Add the necessary glue for inline completion.
1746 Sun Jul 18 15:28:24 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1748 * gtk/gtkdnd.c (gtk_drag_source_set, gtk_drag_dest_set): Create an
1749 empty target list if targets is NULL.
1751 * configure.in: Add check for X11/extensions/sync.h. (#147416,
1754 Sun Jul 18 01:24:31 2004 Matthias Clasen <maclas@gmx.de>
1756 * NEWS: Updates for 2.5.0
1758 Sat Jul 17 23:11:04 2004 Matthias Clasen <maclas@gmx.de>
1760 * gtk/gtkiconview.h:
1761 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1762 * gtk/gtkiconview.c (gtk_icon_view_set_orientation):
1763 * gtk/gtkiconview.c (gtk_icon_view_get_orientation):
1764 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
1765 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row):
1766 Add a new :orientation property to determine whether text
1767 is positioned below or beside icons. (#147463)
1769 Sat Jul 17 23:03:30 2004 Matthias Clasen <maclas@gmx.de>
1771 * gtk/gtkiconview.c (gtk_icon_view_paint_item):
1772 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
1773 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row): Draw
1774 focus indicator outside the selection, respect focus
1775 line width. (#147460)
1777 Sat Jul 17 01:17:33 2004 Matthias Clasen <maclas@gmx.de>
1779 * gdk/x11/gdkdnd-x11.c (xdnd_check_dest): Fix a warning
1782 Sat Jul 17 00:48:27 2004 Matthias Clasen <maclas@gmx.de>
1784 Support text/plain selection target (#55117, Owen Taylor)
1786 * gtk/gtkselection.h:
1788 * gtk/gtkselection.c (gtk_target_list_add_text_targets):
1789 * gtk/gtkdnd.c (gtk_drag_dest_add_text_targets):
1790 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets): New
1791 functions to facilitate handling of text targets.
1794 * gtk/gtktextview.c: Use the new text target handling
1795 functions instead of hardwiring the list of supported
1796 text targets everywhere.
1798 * gtk/gtkselection.c (gtk_selection_data_get_text):
1799 (gtk_selection_data_set_text):
1800 Support the targets text/plain, text/plain?charset=utf-8
1801 and text/plain?charset=<LOCALE-CHARSET> as outlined in
1803 For text/plain send only ASCII, but accept 8-bit text
1804 and treat it as ISO-8859-1 as specified by the Xdnd spec.
1805 Always send CRLF terminators. Accept either and convert
1806 into the native terminator for the platform.
1808 Fri Jul 16 23:20:34 2004 Matthias Clasen <maclas@gmx.de>
1810 Support themed window icons. (#92346, Calum Benson)
1812 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): New
1813 function to obtain information about the sizes in which an
1817 * gtk/gtkwindow.c (gtk_window_class_init):
1818 (gtk_window_set_icon_name):
1819 (gtk_window_get_icon_name): Add an "icon_name" property
1820 (gtk_window_set_default_icon_name): ...and a default icon name.
1821 (icon_list_from_theme):
1822 (update_themed_icon): New auxiliary functions to create a
1823 list of all available sizes of a themed icon and update the
1824 window icon list from it.
1826 2004-07-16 Matthias Clasen <mclasen@redhat.com>
1828 * gtk/gtkcombobox.c (gtk_combo_box_scroll_event): Make
1829 scrolling work if no item is selected.
1830 (gtk_cell_editable_key_press): Don't eat space.
1832 Add a combo box cell renderer (#139347, Lorenzo Gil Sanchez)
1834 * gtk/gtkcellrenderercombo.[hc]: New Files.
1837 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
1840 * gtk/gtkcombobox.[hc]: Implement GtkCellEditable, add a
1841 :has-frame property for suppressing the frame around
1842 the child and redo the size allocation logic to take
1843 focus width into account.
1845 * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_init):
1846 Acknowledge the GtkComboBox:has-frame property and make
1847 the entry fill its allocation vertically.
1849 * gtk/gtkmarshalers.list: Add BOOLEAN:STRING.
1851 * gtk/gtktreeview.c (gtk_tree_view_remove_widget): Queue
1852 a draw here to keep non-widget windows from leaving
1855 2004-07-16 Matthias Clasen <mclasen@redhat.com>
1857 * gtk/gtkcombobox.c (gtk_combo_box_forall): Don't iterate
1858 multiple times over some of the children.
1860 Thu Jul 15 22:19:40 2004 Matthias Clasen <maclas@gmx.de>
1862 Fix #60128, #58307, #144706:
1864 * gtk/gtkstyle.c (gtk_style_real_copy): Handle references
1865 to bg_pixmaps properly.
1866 (gtk_style_real_unrealize): Don't keep dangling references
1868 (gtk_style_attach): Split the loop into two loops, first
1869 looking for a matching style, then for an empty one.
1870 (gtk_style_finalize):
1871 (gtk_style_duplicate): Add comments explaining the handling
1874 Thu Jul 15 20:31:28 2004 Matthias Clasen <maclas@gmx.de>
1876 * gtk/gtkspinbutton.c (start_spinning): Install the timeout
1877 before changing the value, so that a ::value_changed handler
1878 has a chance to remove it. (#122427, Elke Meier)
1880 Thu Jul 15 19:20:05 2004 Matthias Clasen <maclas@gmx.de>
1882 * gdk/x11/gdkgtk+/im-x11.c (_gdk_x11_initialize_locale):
1883 * gtk/gtkcalendar.c (gtk_calendar_class_init): Use 'cannot'
1884 instead of 'can not' in messages. (#144226, Morten Welinder)
1886 2004-07-15 Matthias Clasen <mclasen@redhat.com>
1888 * gtk/gtktreeview.c (gtk_tree_view_class_init):
1889 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
1890 Correct the declared default values of several properties
1891 to be in sync with the actual initial values.
1893 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_class_init):
1894 Make spacing a property, correct the declared default values
1895 of several properties to be in sync with the actual initial
1896 values. (#147654, Matthias Clasen)
1898 * gtk/gtkmenu.c (gtk_menu_set_tearoff_state): Don't reparent
1899 back to menu->toplevel if it is already gone because we're
1900 shutting down. (#147656, John Cupitt)
1902 2004-07-14 Federico Mena Quintero <federico@ximian.com>
1906 * gtk/gtktreeview.c (gtk_tree_view_bin_expose): Draw a focus
1907 indicator along the edge of the bin_window when the tree is empty.
1908 (grab_focus_and_unset_draw_keyfocus): New helper function.
1909 (gtk_tree_view_button_press): Remove a bit of superfluous code.
1910 Use the helper function to save on duplicated code.
1911 (gtk_tree_view_button_press): Grab the focus if the tree is empty.
1912 (gtk_tree_view_focus): Allow focusing into an empty tree.
1914 2004-07-14 Matthias Clasen <mclasen@redhat.com>
1916 * gtk/gtkaboutdialog.c (add_credits_page): Don't use
1917 gcc extensions for the ternary ?: operator. (#147590,
1920 2004-07-14 Federico Mena Quintero <federico@ximian.com>
1922 Fix #144405, patch by Padraig O'Briain <padraig.obriain@sun.com>:
1924 * gtk/gtkfilechooserdefault.c (shortcuts_list_create): Set the
1925 accessible object name for the tree view.
1926 (create_file_list): Likewise.
1928 Tue Jul 13 21:53:08 2004 Matthias Clasen <maclas@gmx.de>
1930 * gtk/gtkicontheme.c (free_unthemed_icon): Don't leak
1931 no_svg_filename. (#147399, Kjartan Maraas)
1933 2004-07-13 Matthias Clasen <mclasen@redhat.com>
1935 * gtk/gtktreeviewcolumn.c (_gtk_tree_view_column_get_neighbor_sizes):
1936 Make this work in RTL context.
1938 2004-07-13 Federico Mena Quintero <federico@ximian.com>
1940 * gtk/gtkfilechooserdefault.c (shortcuts_activate_volume): Set a
1941 busy cursor while mounting the volume. Also, ref the chooser
1942 while mounting, as we may re-enter. Fixes #139376.
1944 2004-07-13 Matthias Clasen <mclasen@redhat.com>
1946 * gtk/gtktreeview.c (gtk_tree_view_adjustment_changed):
1947 Prepare to handle composite implementations of
1948 GtkCellEditable, but recursively poking at
1949 allocation->y (hack stolen from GtkCList).
1950 (check_expander_max): Tweak the warning.
1952 * gtk/gtkmain.h: Add gtk_parse_args(), its a public
1953 function. (#147476, Owen Taylor)
1955 * gtk/gtkcombobox.c (gtk_combo_box_popdown): Don't
1956 crash if unrealized.
1958 Tue Jul 13 01:50:06 2004 Matthias Clasen <maclas@gmx.de>
1960 * gtk/gtkaboutdialog.c (display_credits_dialog): Don't
1961 display untranslated translator credits.
1963 Tue Jul 13 01:15:05 2004 Matthias Clasen <maclas@gmx.de>
1965 * gtk/gtkiconview.c: Some documentation updates.
1967 Tue Jul 13 00:40:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1969 * gdk/gdkwindow.c (gdk_window_process_updates_internal): Do an
1970 empty begin_paint_region()/end_paint() for windows without
1973 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_unset_bg,
1974 _gdk_x11_window_tmp_reset_bg): Remove checks for EXPOSURE_MASK.
1976 2004-07-12 Matthias Clasen <mclasen@redhat.com>
1978 * demos/gtk-demo/appwindow.c: Use a GtkAboutDialog.
1980 * gtk/gtkaboutdialog.h:
1981 * gtk/gtkaboutdialog.c: New widget: GtkAboutDialog.
1983 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
1984 * gtk/gtk.h: Add GtkAboutDialog. (#109435, Paolo Borelli,
1985 patch by Matthias Clasen)
1987 * gtk/gtkrc.c (_gtk_rc_init): Apply the gtk-default-menu-item-style
1988 to cell view menu items as well. (#147405, John Cupitt)
1990 * gtk/gtkentrycompletion.c: Warning fixes. (#147420,
1993 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Pop down
1994 first. (#147399, John Cupitt)
1996 Mon Jul 12 01:56:26 2004 Matthias Clasen <maclas@gmx.de>
1998 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
1999 Include the update_counter check in the HAVE_XSYNC condition,
2000 since update_counter isn't present in the !HAVE_XSYNC case.
2002 Mon Jul 12 00:52:04 2004 Matthias Clasen <maclas@gmx.de>
2004 * gtk/stock-icons/Makefile.am:
2005 * gtk/stock-icons/stock_about_{16,24}.png:
2006 * gtk/stock-icons/stock_connect_{16,24}.png:
2007 * gtk/stock-icons/stock_disconnect_{16,24}.png:
2008 * gtk/stock-icons/stock_edit_{16,24}.png:
2009 * gtk/stock-icons/stock_media_forward_{16,24}.png:
2010 * gtk/stock-icons/stock_media_next_{16,24}.png:
2011 * gtk/stock-icons/stock_media_pause_{16,24}.png:
2012 * gtk/stock-icons/stock_media_play_{16,24}.png:
2013 * gtk/stock-icons/stock_media_previous_{16,24}.png:
2014 * gtk/stock-icons/stock_media_record_{16,24}.png:
2015 * gtk/stock-icons/stock_media_rewind_{16,24}.png:
2016 * gtk/stock-icons/stock_media_stop_{16,24}.png:
2017 * gtk/gtkstock.h (GTK_STOCK_ABOUT):
2018 * gtk/gtkstock.h (GTK_STOCK_CONNECT):
2019 * gtk/gtkstock.h (GTK_STOCK_DISCONNECT):
2020 * gtk/gtkstock.h (GTK_STOCK_EDIT):
2021 * gtk/gtkstock.h (GTK_STOCK_MEDIA_FORWARD):
2022 * gtk/gtkstock.h (GTK_STOCK_MEDIA_NEXT):
2023 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PAUSE):
2024 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PLAY):
2025 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PREVIOUS):
2026 * gtk/gtkstock.h (GTK_STOCK_MEDIA_RECORD):
2027 * gtk/gtkstock.h (GTK_STOCK_MEDIA_REWIND):
2028 * gtk/gtkstock.h (GTK_STOCK_MEDIA_STOP):
2029 * gtk/gtkiconfactory.c (get_default_icons):
2030 * gtk/gtkstock.c (builtin_items): Add a number of new stock
2031 items. (#102530, #68015, #109811, Jordi Mallach, Benjamin Otte,
2034 Sun Jul 11 15:24:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2036 Bug 143330, support update counter spec.
2038 * configure.in: Add check for the Sync extension
2040 * gdk/gdkwindow.h: gdk_window_enable_synchronized_configure() and
2041 gdk_window_configure_finished()
2043 * gtk/gtkwindow.c (gtk_window_move_resize): Call gdk_window_finish_configure().
2044 * gtk/gtkwindow.c (gtk_window_realize): Automatically enable
2045 synchronized configures.
2047 * gdk/x11/gdkwindow-x11.h (struct _GdkToplevelX11): Store current
2048 and pending counter values.
2050 * gdk/x11/gdkwindow-x11.c (gdk_window_configure_finished): New function.
2051 * gdk/x11/gdkwindow-x11.c
2052 (gdk_window_enable_synchronized_configure): New function.
2053 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
2054 Delete update counter.
2055 * gdk/x11/gdkwindow-x11.c (set_wm_protocols): Advertise
2056 _NET_WM_SYNC_REQUEST when Sync is available
2058 * gdk/x11/gdkevents-x11.c (gdk_wm_protocols_filter): Handle
2059 _NET_WM_SYNC_REQUEST messages
2060 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Save counter
2061 value for use by gdk_window_configure_finished() when receiving
2064 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add use_sync flag
2065 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Check if the XSync
2066 extension is available
2067 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_SYNC_REQUEST and
2068 _NET_WM_SYNC_REQUEST_COUNTER to list of supported atoms.
2070 * gdk/linux-fb/gdkwindow-fb.c, gdk/win32/gdkwindow-win32.c: Add
2071 stubs for enable_synchronized_configure() and configure_finished()
2073 Sat Jul 10 23:35:13 2004 Matthias Clasen <maclas@gmx.de>
2075 * gtk/gtkentry.c (paste_received): Make middle-button pasting
2076 work as expected inside the entry. (#116789, Scott Bronson)
2078 Sat Jul 10 22:13:53 2004 Matthias Clasen <maclas@gmx.de>
2080 * gtk/gtktextbuffer.c (gtk_text_buffer_select_range): Update
2081 clipboards. (#142805, Mikael Hallendal)
2083 Sun Jul 11 01:38:48 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2085 * gtk/gtkpaned.c (gtk_paned_expose): Remove clip-region computing
2086 code. Just use &paned->handle_pos.
2088 Sun Jul 11 01:12:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2092 * gtk/gtknotebook.c (gtk_notebook_size_allocate): Remove an
2093 unnecessary redraw..
2095 * gtk/gtknotebook.c (gtk_notebook_page_allocate): Remove some
2098 Sat Jul 10 01:33:25 2004 Matthias Clasen <maclas@gmx.de>
2100 * docs/RELEASE-HOWTO: Updates.
2102 Sat Jul 10 01:55:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2104 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{re|un}set_bg):
2105 Insert checks for root window. The root window is never mapped.
2107 Sat Jul 10 01:06:05 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2109 * gdk/x11/gdkwindow-x11.c (post_unmap): Fix a warning
2110 * gdk/x11/gdkwindow-x11.c (show_window_internal): Actually unset
2113 Sat Jul 10 00:37:45 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2117 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{un|re}set_bg):
2118 New functions that can do a recursive unset/reset bg.
2120 * gdk/x11/gdkgeometry-x11.c: Remove
2121 gdk_window_tmp_{un|re}set_bg().
2123 * gdk/x11/gdkwindow-x11.c (pre_unmap, post_unmap): New functions
2124 called before and after unmapping a window. They unset the
2125 background of all other windows to prevent flicker from the X
2126 server repainting the background. post_unmap() also invalidates
2127 the parent of the unmapped window to draw it without roundtrips.
2129 * gdk/x11/gdkwindow-x11.c (show_window_internal): Unset
2130 background of newly mapped windows and all desendants to prevent
2133 Fri Jul 9 15:33:55 2004 Manish Singh <yosh@gimp.org>
2135 * gdk/gdkevents.c: have a dummy case GDK_OWNER_CHANGE in switch
2136 statements to avoid gcc warnings about not all enum values handled.
2138 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): ignore should live in
2141 Fri Jul 9 23:26:09 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2145 * gdk/x11/gdkwindow-x11.h (struct _GdkWindowImplX11): Add an
2146 "override_redirect" bit.
2148 * gdk/x11/gdkwindow-x11.c (gdk_window_new): Set it here.
2150 * gdk/x11/gdkwindow-x11.c (gdk_window_move, gdk_window_resize,
2151 gdk_window_move_resize):
2152 Update the local size/position cache
2153 immediately for override redirect windows.
2155 * gdk/x11/gdkwindow-x11.c (show_window_internal): Invalidate
2156 newly mapped child and override redirect windows.
2158 2004-07-09 Federico Mena Quintero <federico@ximian.com>
2162 * gtk/gtkfilesystemunix.c (get_fallback_icon): New helper
2163 function, fetches a stock icon as a fallback.
2164 (gtk_file_system_unix_volume_render_icon): Fall back to a stock
2166 (gtk_file_system_unix_render_icon): Fall back to a stock icon.
2167 Use helper functions rather than being a mega-function.
2168 (get_icon_name_for_directory): Renamed from
2169 get_icon_for_directory().
2170 (get_icon_type_from_path): New helper function; code pulled out
2171 from gtk_file_system_unix_render_icon().
2172 (get_special_icon): Likewise.
2173 (get_icon_for_mime_type): Likewise.
2175 2004-07-09 Federico Mena Quintero <federico@ximian.com>
2177 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Fix typo; tmp_event ->
2180 2004-07-09 Matthias Clasen <mclasen@redhat.com>
2182 * gtk/gtktooltips.c (gtk_tooltips_paint_window): Use the
2183 requisition of the widget instead of relying on the style
2184 drawing function to supply the size of the drawable. (#146531)
2186 2004-07-09 Matthias Clasen <mclasen@redhat.com>
2188 Make GtkEntry work harder to protect passwords: (#143955,
2191 * gtk/gtkentry.c (gtk_entry_destroy): Add a destroy handler
2192 to clear the password even if the widget is leaked.
2194 * gtk/gtkentry.c (gtk_entry_real_delete_text):
2195 * gtk/gtkentry.c (gtk_entry_finalize): Zero out the memory
2198 * gtk/gtkentry.c (gtk_entry_real_insert_text): Zero and free
2199 the old memory instead of just reallocating it.
2201 * gtk/gtkentry.c (gtk_entry_create_layout): Don't leak text
2202 direction information for passwords.
2204 2004-07-09 Matthias Clasen <mclasen@redhat.com>
2206 * gtk/gtkstyle.c: Fix some cases where style functions were
2207 not handling widget == NULL properly. (#146282)
2209 Thu Jul 8 22:38:58 2004 Matthias Clasen <maclas@gmx.de>
2211 * gtk/gtktreeview.c: Improve the EXPANDER_MAX warning.
2213 2004-07-08 Federico Mena Quintero <federico@ximian.com>
2217 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_new): Add a
2218 GError argument. Do check for errors when getting the
2219 GtkFileFolder: get the folder and read the children before
2220 actually creating the model. Removed obsolete code that handled
2221 roots-changed on the file system.
2222 (file_model_node_get_info): Assert that we don't reach the old
2223 case to display file system roots.
2224 (roots_changed_callback): Removed.
2226 * gtk/gtkfilechooserdefault.c (set_list_model): Add a GError
2227 argument, and a boolean return value. Return an error if we
2228 cannot create the file system model. On error, set a NULL model
2230 (gtk_file_chooser_default_set_current_folder): Use the error value
2231 from set_list_model().
2232 (gtk_file_chooser_default_set_property): Set the show_hidden
2233 property only if the browse_files_model exists.
2234 (gtk_file_chooser_default_unselect_path): Only operate if the
2235 browse_files_model exists.
2236 (check_preview_change): Check whether we have the sort_model.
2237 (change_folder_and_display_error): Copy the path we get passed
2238 before using it. There's a comment in there that explains why we
2239 need to copy it; basically, if the passed path belongs to the
2240 model, the model may go away in the middle of this function and
2241 we'll be left with a dangling pointer.
2242 (install_list_model_filter): Assert that the model is not NULL.
2243 (set_current_filter): Check whether the model exists.
2245 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected): Don't
2246 g_return_if_fail if the model is NULL.
2247 (gtk_tree_selection_get_selected_rows): Likewise.
2248 (gtk_tree_selection_count_selected_rows): Likewise.
2249 (gtk_tree_selection_selected_foreach): Likewise.
2250 (gtk_tree_selection_path_is_selected): Likewise; rather just
2252 (gtk_tree_selection_select_all): Likewise.
2253 (gtk_tree_selection_unselect_all): Likewise.
2254 (gtk_tree_selection_select_range): Do g_return_if_fail() if the
2256 (gtk_tree_selection_unselect_range): Likewise.
2258 * gtk/gtkfilesystemunix.c (fill_in_names): Return immediately if
2259 g_dir_open() fails: there is no need to set the error ourselves,
2260 as g_dir_open() already does it.
2262 2004-07-08 Matthias Clasen <mclasen@redhat.com>
2264 * gtk/gtktreeview.c (gtk_tree_view_set_search_equal_func): Allow
2265 to restore the default search function. (#145365, John Finlay)
2267 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Don't leak
2268 references to the drag context. (#144324, Alex Larsson)
2270 Thu Jul 8 00:31:34 2004 Matthias Clasen <maclas@gmx.de>
2272 * gtk/gtktreeview.c (gtk_tree_view_set_model): Stop editing
2273 when a new model is set. (#145566, Dmitry M. Shatrov)
2275 Wed Jul 7 23:44:32 2004 Matthias Clasen <maclas@gmx.de>
2277 * gtk/gtkimage.c (gtk_image_expose): Make sure that subpixbufs
2278 are properly aligned for gdk_pixbuf_saturate_and_pixelate(),
2279 in order to avoid rendering artifacts from misaligned
2280 pixelation patterns. (#145585, Felipe Heidrich, Billy Biggs)
2282 2004-07-07 Matthias Clasen <mclasen@redhat.com>
2284 * gtk/gtktreeview.c:
2285 * gtk/gtktreeview.h: Small documentation fixes.
2287 2004-07-07 Matthias Clasen <mclasen@redhat.com>
2289 Support separators in combo boxes and more generally in tree
2292 * gtk/gtkcombobox.h:
2293 * gtk/gtkcombobox.c (gtk_combo_box_get_row_separator_column):
2294 * gtk/gtkcombobox.c (gtk_combo_box_set_row_separator_column):
2295 Add a ::row-separator-column property with getter and setter,
2296 which can indicate a boolean model column to determine which
2297 rows are separators.
2299 * gtk/gtkcombobox.c: Display separator rows as separator menu
2300 items in menu mode, and by using the new treeview separator
2301 functionality in list mode.
2303 * gtk/gtktreeview.h:
2304 * gtk/gtktreeprivate.h:
2305 * gtk/gtktreeview.c (gtk_tree_view_get_row_separator_func):
2306 * gtk/gtktreeview.c (gtk_tree_view_set_row_separator_func):
2307 Add a callback to determine whether a row is a separator.
2309 * gtk/gtktreeview.c (gtk_tree_view_bin_expose):
2310 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
2311 * gtk/gtktreeview.c (validate_row): Use the new callback
2312 to determine whether a row is a separator, and draw it
2313 as a separator then. Since separators should take up less
2314 vertical space than regular rows, this requires removing
2315 the redundant MAX(...,expander_size) calls which appear in
2316 many places. Instead, the MAX() is now only done in
2317 validate_row(), and only if the row is not a separator.
2318 To catch possible side effects of this intrusive change,
2319 I have left EXPANDER_MAX() calls in place of the MAX() calls
2320 which will emit a warning if something breaks. They should
2321 be removed before 2.6.
2323 * gtk/gtktreeselection.c (row_is_selectable): Don't let
2324 separator rows be selected.
2326 * tests/testcombo.c (create_blaat): Add a separator column.
2328 Tue Jul 6 22:58:00 2004 Matthias Clasen <maclas@gmx.de>
2330 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Fix
2331 a 64bit alignment issue. (#144302, Sunil)
2333 2004-07-07 Tor Lillqvist <tml@iki.fi>
2335 * gdk/win32/gdkdrawable-win32.c (gdk_win32_draw_text)
2336 * gdk/win32/gdkfont-win32.c (gdk_text_extents)
2337 * gdk/win32/gdkproperty-win32.c (find_common_locale,
2338 gdk_property_change)
2339 * gdk/win32/gdkselection-win32.c (gdk_selection_convert): Use
2340 g_utf8_to_utf16() instead of the removed _gdk_utf8_to_ucs2() (see
2343 * gdk/win32/gdkglobals-win32.c
2344 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init)
2345 * gdk/win3/gdkprivate-win32.h: Add a variable for the TARGETS
2346 atom. Initialize it. Declare it. Drop the variable for the
2349 * gdk/win32/gdkim-win32.c (gdk_wcstombs): Don't return UTF-8. This
2350 function is supposed to return the string in the locale's charset
2351 and encoding. Use g_convert().
2353 (gdk_mbstowcs): Similarily, don't take an UTF-8 string, but a
2354 string in the locale's charset. Use g_convert().
2356 (_gdk_ucs2_to_utf8, _gdk_utf8_to_wcs, _gdk_utf8_to_ucs2):
2357 Delete. The UCS-2 functions didn't handle surrogates anyway. Use
2358 GLib's UTF-16 functions instead. Windows uses UTF-16.
2360 * gdk/win32/gdkprivate-win32.h: Remove declarations of the deleted
2361 functions mentioned above.
2363 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Use CF_TEXT
2364 also if the string is of type STRING, i.e. ISO-8859-1, and the
2365 current codepage is 1252, and contains no C1 chars. Accept
2368 * gdk/win32/gdkselection-win32.c (_gdk_selection_property_store):
2369 Mark as static. When storing STRING data, convert to
2371 (gdk_selection_owner_set_for_display): Now that STRING is always
2372 ISO-8859-1, use UTF8_STRING when sending the selection request
2375 (gdk_selection_convert): Handle also UTF8_STRING. (#140537, John
2378 (gdk_text_property_to_text_list_for_display): Make work more like
2379 X11 version. Do obey the encoding parameter.
2381 (gdk_string_to_compound_text_for_display,
2382 gdk_utf8_to_compound_text_for_display): Don't even pretend
2383 supporting COMPOUND_TEXT.
2385 (gdk_utf8_to_string_target): Convert to ISO-8859-1, like on X11.
2387 (sanitize_utf8): Zero-terminate string.
2389 2004-07-06 Matthias Clasen <mclasen@redhat.com>
2391 * gtk/stock-icons/Makefile.am: Add stock_file_16.png,
2392 stock_file_24.png, stock_directory_16.png and stock_directory_24.png.
2394 * gtk/gtkstock.h (GTK_STOCK_FILE, GTK_STOCK_DIRECTORY):
2395 * gtk/gtkiconfactory.c (get_default_icons): New stock icons as
2396 fallbacks for gtkfilechooser. Currently these are the same images
2397 as the "new" and "open" items...
2399 Tue Jul 6 10:00:22 2004 Jonathan Blandford <jrb@redhat.com>
2401 Fix for #136496, Pawel Salek:
2403 * gtk/gtktreeview.c (gtk_tree_view_row_changed): Queue a redraw on
2404 a node when it changes in fixed_height mode.
2406 (gtk_tree_view_node_queue_redraw): new function to queue a redraw
2409 2004-07-06 Matthias Clasen <mclasen@redhat.com>
2411 * gtk/gtkmenu.c (gtk_menu_position): Make sure
2412 private->monitor_num is a valid monitor number before
2413 using it. (#139187, Michael Natterer)
2415 Tue Jul 6 02:00:28 2004 Matthias Clasen <maclas@gmx.de>
2417 * gtk/gtkfilechooserdefault.c (popup_position_func):
2418 * gtk/gtkentry.c (popup_position_func):
2419 * gtk/gtktextview.c (popup_position_func): Improve positioning
2420 of keyboard-activated menus with Xinerama.
2422 Tue Jul 6 00:29:03 2004 Matthias Clasen <maclas@gmx.de>
2424 * gtk/gtkuimanager.c (do_updates):
2425 (do_updates_idle): Only call GDK_THREADS_ENTER() / _LEAVE()
2426 when called from an idle handler. (#145429, Jan-Marek Glogowski)
2428 Mon Jul 5 23:47:38 2004 Matthias Clasen <maclas@gmx.de>
2430 * gtk/gtkfilechooserutils.c (delegate_notify): Use
2431 the less efficient g_object_interface_find_property () instead
2432 of the param_id range check, since the GParamSpecs we're
2433 dealing with are the overridden onces on the interface, whose
2434 param_id is always zero. (#145312, Alex Roitman, fix proposed
2437 2004-07-05 Lorenzo Gil Sanchez <lgs@sicem.biz>
2439 * gtk/gtklayout.c (gtk_layout_add): added a default method for the add
2440 virtual method of GtkContainer.
2441 (gtk_layout_class_init): assign gtk_layout_add to the 'add' virtual
2442 method slot of the container class.
2444 2004-07-05 Anders Carlsson <andersca@gnome.org>
2446 * gtk/gtkiconview.c: (gtk_icon_view_set_markup_column):
2447 * gtk/gtkiconview.h:
2448 Use gint, not int in gtk_icon_view_set_markup_column,
2451 2004-07-05 Anders Carlsson <andersca@gnome.org>
2453 * gtk/gtkiconview.c: (gtk_icon_view_class_init),
2454 (gtk_icon_view_real_select_cursor_item),
2455 (gtk_icon_view_real_activate_cursor_item):
2456 * gtk/gtkiconview.h:
2457 Add an "activate_cursor_item" action signal
2458 and bind it to the return key.
2460 2004-07-04 Anders Carlsson <andersca@gnome.org>
2462 * demos/gtk-demo/Makefile.am:
2463 * demos/gtk-demo/gnome-fs-directory.png:
2464 * demos/gtk-demo/gnome-fs-regular.png:
2465 * demos/gtk-demo/iconview.c: (load_pixbufs), (fill_store),
2466 (sort_func), (create_store), (item_activated), (up_clicked),
2467 (home_clicked), (do_iconview):
2468 Add a simple file browser based on the icon view.
2471 Add gtk/gtkiconview.h
2473 * gtk/gtkiconview.c: (gtk_icon_view_layout),
2474 (gtk_icon_view_item_new), (gtk_icon_view_item_activated):
2475 Fix a few bugs discovered while writing the demo.
2477 2004-07-04 Anders Carlsson <andersca@gnome.org>
2481 * gtk/gtkiconview.h:
2482 Add GtkIconView to the build, remove debugging output.
2484 Sun Jul 4 01:29:35 2004 Matthias Clasen <maclas@gmx.de>
2486 * gtk/gtkcalendar.c (gtk_calendar_drag_data_get):
2487 (gtk_calendar_drag_data_received): Fix off-by-one error.
2488 GDate month is one-based and GtkCalendar month is zero-based.
2489 (#145134, William Jon McCann)
2491 Sun Jul 4 01:11:07 2004 Matthias Clasen <maclas@gmx.de>
2493 * gtk/gtktreestore.c (gtk_tree_store_move): Don't crash if
2494 somebody tries to move a node after itself in a list of
2495 length 1. (#145291, Sampo Nurmentaus)
2497 Sat Jul 3 23:43:23 2004 Matthias Clasen <maclas@gmx.de>
2499 * docs/faq/gtk-faq.sgml:
2500 * gtk/gtkwindow.c: Fix links to www.freedesktop.org. (#145210,
2503 Sat Jul 3 02:09:51 2004 Matthias Clasen <maclas@gmx.de>
2505 * gtk/gtksocket.c (gtk_socket_end_embedding): Reset current_width
2506 and current_height to 0 when ending the embedding. (#143675,
2507 Nickolay V. Shmyrev)
2509 Sat Jul 3 01:48:19 2004 Matthias Clasen <maclas@gmx.de>
2511 * gtk/gtkentry.c (gtk_entry_move_visually): Let the cursor move
2512 to the right end of the entry text, even if it ends in combining
2513 marks. (#141728, Theppitak Karoonboonyanan)
2515 Fri Jul 2 23:34:33 2004 Matthias Clasen <maclas@gmx.de>
2517 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Unset the displayed
2518 row when unsetting the model. (#138560, Christian Persch)
2520 Fri Jul 2 23:01:07 2004 Matthias Clasen <maclas@gmx.de>
2522 * gtk/gtkcombobox.c (update_menu_sensitivity): Don't crash if there
2525 Fri Jul 2 22:41:27 2004 Matthias Clasen <maclas@gmx.de>
2527 * gtk/gtkimage.c (gtk_image_expose): Properly align mask and
2528 pixbuf if a subarea is exposed. (#135423, fix by John Ehresman)
2530 Fri Jul 2 21:40:21 2004 Matthias Clasen <maclas@gmx.de>
2532 * gtk/gtknotebook.c (gtk_notebook_realize): Add scroll events
2533 to the event mask, set a scroll_event handler.
2534 * gtk/gtknotebook.c (gtk_notebook_scroll): Handle scroll events
2535 by switching tabs. (#145244, Gabriel de Perthuis)
2537 2004-07-02 Anders Carlsson <andersca@gnome.org>
2539 * gtk/gtktreeview.c (gtk_tree_view_set_model):
2540 Make sure we check for a NULL model first.
2542 2004-07-01 J. Ali Harlow <ali@juiblex.co.uk>
2544 * gdk/win32/gdkinput-win32.c (_gdk_input_ungrab_pointer): Fix
2545 win32 build problem w/o wintab. Fixed #145242
2547 2004-06-30 Anders Carlsson <andersca@gnome.org>
2549 * gtk/gtktreeview.c (gtk_tree_view_set_model): Use
2550 g_return_if_fail to make sure that the model is a GtkTreeModel.
2552 Sat Jun 26 17:41:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2554 * gtk/gtk[hv]separator.c (gtk_[hv]separator_expose): Draw line with the
2555 current state, not GTK_STATE_NORMAL
2557 * gtk/gtkframe.c (gtk_frame_paint): Fix a rounding error
2559 Sat Jun 26 15:07:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2561 * gtk/gtkstyle.c, gtk/gtkrc.c: small color tweak. (#141173)
2563 Sat Jun 26 01:15:40 2004 Matthias Clasen <maclas@gmx.de>
2565 * gdk/x11/gdkwindow-x11.c (set_initial_hints): Handle
2566 _NET_WM_STATE_ABOVE and _NET_WM_STATE_BELOW. (#144851,
2569 Sat Jun 26 01:04:31 2004 Matthias Clasen <maclas@gmx.de>
2571 * gtk/gtkiconfactory.c (clear_cache): Prevent unwanted
2572 recursion by resetting icon_set->cache before freeing
2573 the cache. (#144947, Tim Janik)
2575 Sat Jun 26 00:40:02 2004 Matthias Clasen <maclas@gmx.de>
2577 * gtk/gtkiconfactory.c (render_icon_name_pixbuf):
2578 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon):
2579 * gtk/gtkstyle.c (gtk_default_render_icon): Accept a NULL
2582 Sat Jun 26 00:04:36 2004 Matthias Clasen <maclas@gmx.de>
2584 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
2585 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Reflect the
2586 last change in the docs.
2588 Fri Jun 25 23:35:42 2004 Matthias Clasen <maclas@gmx.de>
2590 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
2591 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Allow passing
2592 NULL to unset the model. (#137211, patch by Mariano Suárez-Alvarez)
2594 Fri Jun 25 23:33:05 2004 Matthias Clasen <maclas@gmx.de>
2596 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Fix the
2597 placement policy for GtkComboBoxEntry to be: if it fits below,
2598 place below, if it fits above place above, else place in the
2599 larger space and scroll so that the scroll arrow appear at the
2600 far end. (#144362, David A. Knight)
2602 Fri Jun 25 22:49:58 2004 Matthias Clasen <maclas@gmx.de>
2604 * gtk/gtktreestore.c (gtk_tree_store_move): Avoid uninitialized
2605 use of &parent_iter. (#145007, John Finlay)
2607 2004-06-25 Bastien Nocera <hadess@hadess.net>
2609 reviewed by: Matthias Clasen <maclas@gmx.de>
2611 * gdk/x11/gdkkeys-x11.c: (get_symbol), (update_keymaps),
2612 (gdk_keymap_lookup_key), (translate_keysym): fix keys parsing when
2613 the number of keysyms per keycode is odd. Fixes #144808.
2615 2004-06-25 Matthias Clasen <mclasen@redhat.com>
2617 * gtk/gtkfontbutton.c (gtk_font_button_update_font_info): Avoid
2618 a crash if the font doesn't exist. (#144967, Yevgen Muntyan)
2620 Fri Jun 25 00:32:15 2004 Matthias Clasen <maclas@gmx.de>
2622 * gtk/gtktreestore.c (gtk_tree_store_swap): Commit the change
2623 which was mentioned below.
2625 Thu Jun 24 23:35:09 2004 Matthias Clasen <maclas@gmx.de>
2627 * gtk/gtknotebook.c (gtk_notebook_class_init): Fix a typo,
2628 string change. (#139503, Baris Cicek)
2630 2004-06-22 Federico Mena Quintero <federico@ximian.com>
2632 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a Save
2633 or an Open stock button for the C-l dialog depending on the action
2634 in which the file chooser operates. Fixes #141753.
2636 2004-06-22 Federico Mena Quintero <federico@ximian.com>
2638 Fixes the GTK+ part of #142308:
2640 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_filename_to_path):
2641 Use filename_to_path().
2642 (gtk_file_system_unix_uri_to_path): Likewise.
2643 (filename_to_path): Use remove_trailing_slash().
2645 2004-06-22 Matthias Clasen <mclasen@redhat.com>
2647 * gtk/gtktextview.c (gtk_text_view_class_init): Improve docs
2648 for the ::move_cursor signal.
2650 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
2651 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
2654 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
2655 this gets defined for all backends, so linux-fb has a
2656 chance of compiling.
2658 * gdk/x11/gdkgc-x11.c:
2659 * gdk/gdkgc.c: Move function docs inline, add hints about
2660 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
2662 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
2663 for children of the root. (#139785, Jean-François Wauthy,
2664 patch by John Finlay)
2666 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
2667 fix. (#144750, Jeff Franks)
2669 2004-06-21 Michael Natterer <mitch@gimp.org>
2672 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
2673 function public as _gdk_x11_convert_to_format().
2675 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
2676 the pixels from the GdkPixbuf when putting them in the
2677 Xcursor image. Fixes bug #144350.
2679 2004-06-16 Federico Mena Quintero <federico@ximian.com>
2681 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
2682 visible node, free the old path before creating the new one.
2685 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
2687 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
2688 (#144198, Mariano Suárez-Alvarez)
2690 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
2692 * gtk/gtkfilechooserdefault.c: Don't use
2693 contractions like "don't" or "isn't" in error messages.
2694 It isn't nice to use them in log entries either...
2695 (#137774, Morten Welinder, patch by Alexander Winston)
2697 2004-06-11 Federico Mena Quintero <federico@ximian.com>
2701 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
2702 Don't ref the editable node.
2703 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
2704 (_gtk_file_system_model_remove_editable): Ahem, free the node.
2706 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
2707 Added fields for edited_idle and edited_new_text.
2708 (renderer_edited_cb): Queue the
2709 creation of the folder in an idle handler.
2710 (renderer_editing_canceled_cb): Likewise for the cancellation.
2711 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
2713 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
2715 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
2717 2004-06-10 Federico Mena Quintero <federico@ximian.com>
2719 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
2721 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
2722 Refer to gtk_file_chooser_add_shortcut_folder().
2723 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
2724 gtk_file_chooser_add_shortcut_folder_uri().
2726 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
2728 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
2729 the drag before focusing the selected.day.
2730 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
2731 a beginning drag if the widget becomes insensitive.
2733 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
2735 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
2736 spinning before calling arrow_action(), so that a signal
2737 handler triggered from arrow_action() has a chance to
2738 stop the spinning. (#143966, Davyd Madeley)
2740 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
2742 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
2743 typo. (#144070, Kent Sandvik)
2745 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2747 * gtk/gtkmenu.c: Revert the "drag select" part of
2750 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
2752 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
2753 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
2755 2004-06-07 Federico Mena Quintero <federico@ximian.com>
2757 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
2758 from 2003/Sep/12. This kept DnD in tree views within modal
2759 dialogs from working, which is especially bad for the file
2760 chooser. Fixes #135168.
2762 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
2764 Make the entry context menu work in editable text cells. The changes
2765 are based on a patch by Kristian Rietveld, which implemented an
2766 approach outlined by Owen Taylor. (#50075)
2768 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
2769 Ignore focus out if the entry menu is posted.
2770 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
2771 posted, and set up a signal handler to clear the flag if the menu
2773 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
2774 set up a timeout to stop editing if the focus is lost.
2775 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
2776 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
2777 signal on the entry and keep a pointer to the entry.
2778 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
2779 clear the pointer to the entry.
2781 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
2783 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
2784 of the ::language property. (#143802, Owen Taylor)
2786 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
2788 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
2789 (gtk_entry_completion_list_enter_notify),
2790 (gtk_entry_completion_list_motion_notify),
2791 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
2792 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
2793 use it as in the menu code to avoid the initial selection if
2794 the window pops up under the pointer. (Anders Carlsson)
2796 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2798 * tests/testmerge.c: Add a checkbox to queue an
2799 merge/unmerge. Patch from Matthias Clasen.
2801 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
2803 (rebuild_menu): New function that rebuilds the overflow menu and
2804 makes sure it doesn't start or end with a separator.
2805 (toolbar_content_new_tool_item)
2806 (toolbar_content_remove)
2807 (toolbar_content_new_compatibility): Set the rebuild_needed flag
2808 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
2809 have actually overflown an item with a proxy menu item. Also make
2810 sure we rebuild the menu if needed.
2812 Fix #125504, #142377, #143463
2814 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
2815 Obey the "priv->draw" flag. (#143692)
2817 2004-06-04 Matthias Clasen <mclasen@redhat.com>
2819 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
2820 quirk in the button size allocation code.
2822 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
2823 requested for drawing the focus indicator to the child in the
2824 !CAN_FOCUS case. This should fix issues which the Gimp has with
2825 the button allocation changes in 2.4.2.
2827 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
2829 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
2830 length of the entry contents in characters, not in bytes.
2832 * gtk/gtkentry.c (paste_received): Don't pop up the completion
2833 window on paste, noticed by Anders Carlsson.
2835 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
2837 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
2838 values and default value for the ::active property. (#143669,
2841 2004-06-03 Michael Natterer <mitch@gimp.org>
2843 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
2844 instead of accessing item->image->allocation.width/height
2845 directly. Makes widgets which only have a requisition set using
2846 gtk_widget_set_size_request() work and fixes bug #142789.
2848 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2850 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
2851 of sticky right click menus to return.
2853 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2855 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
2856 better handle the "click" case. bug Better fix for #141169.
2858 2004-06-02 Federico Mena Quintero <federico@ximian.com>
2860 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
2861 model is empty. Fixes #143536.
2863 2004-06-02 Matthias Clasen <mclasen@redhat.com>
2865 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
2866 close the dialog on focus out of the size entry. (#143505,
2869 2004-06-02 Federico Mena Quintero <federico@ximian.com>
2873 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
2874 (gtk_fnmatch_intern): Likewise; also implement this option.
2876 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
2878 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
2879 no_leading_period argument of _gtk_fnmatch().
2880 (attempt_file_completion): Likewise.
2882 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
2883 no_leading_period argument of _gtk_fnmatch().
2885 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
2887 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
2890 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
2892 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
2893 allow unless selection mode is multiple. (#142634, John Finlay)
2895 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
2899 * gtk/gtkentrycompletion.h:
2900 * gtk/gtkentrycompletion.c:
2901 * gtk/gtkcombobox.h:
2902 * gtk/gtkcombobox.c: Rename function parameters from
2903 index to index_ to prevent clash with BSD index(). (#143001)
2905 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
2907 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
2908 NULL on an accel label. (#139641, Sam Stephenson, patch by
2911 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
2913 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
2914 lookup finding icons in the wrong prefix. (#143328,
2917 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2921 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
2922 only stay up if you release within 500 milliseconds.
2923 (gtk_menu_shell_button_press): Set the activate_time to the event
2924 time when a button is pressed.
2926 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
2927 Interprete button releases as activate when we have seen both an
2928 enter an a motion event.
2930 2004-06-01 Federico Mena Quintero <federico@ximian.com>
2932 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
2933 dummy node if there is no parent node. Fixes #143362.
2935 2004-05-31 Federico Mena Quintero <federico@ximian.com>
2937 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
2938 newly-created folder. Fixes #138932.
2939 (trap_activate_cb): Only return TRUE if we did handle the event.
2940 Fixes #143359; patch by jylefort@brutele.be.
2942 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
2944 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
2945 docs. (#142892, Tommi Komulainen)
2947 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
2949 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
2950 parent is minimized, porting the fix from 1.2. (#1923, #57182)
2952 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
2954 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
2955 unmapped windows work.
2957 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
2959 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
2962 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
2964 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
2965 Refer to ::update-preview, not ::selection-changed.
2967 2004-05-29 Christian Rose <menthos@menthos.com>
2969 * configure.in: Added "tk" to ALL_LINGUAS.
2971 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
2973 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
2974 messages for common problems. (#137974, Owen Taylor)
2976 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
2978 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
2979 errors. (#143337, Billy Biggs)
2981 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
2983 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
2984 bits within visual->depth that aren't used for color to
2985 1s, in case they are alpha.
2987 2004-05-27 Anders Carlsson <andersca@gnome.org>
2989 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
2990 Make separator rows insensitive.
2992 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
2994 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
2997 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
2999 * gtk/gtkentrycompletion.h:
3000 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
3001 Getter for text_column. Also make ::text_column a property.
3003 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
3005 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
3007 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
3009 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
3010 signal if the box exists.
3012 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
3014 Support insensitive cells in tree views and combo boxes:
3016 * gtk/gtkcellrenderer.h:
3017 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
3019 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
3020 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
3021 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
3022 Support drawing insensitive.
3024 * gtk/gtkcellview.h:
3025 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
3026 function to obtain the cell renderers from a cell view. Also
3027 export gtk_cell_view_set_cell_data().
3029 * gtk/gtktreeselection.c (tree_column_is_sensitive):
3030 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
3031 to determine whether all visible cells in a row are insensitive
3032 and whether a row is selectable. A row is not selectable if the
3033 user function says so or if all visible cells are insensitive.
3034 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
3035 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
3036 Use row_is_selectable().
3038 * gtk/gtkcombobox.c (row_is_sensitive):
3039 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
3040 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
3041 to determine row sensitivity in menu or list mode.
3043 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
3044 to set up sensitivity menu items from the underlying rows.
3046 * gtk/gtkcombobox.c (gtk_combo_box_popup):
3047 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
3048 update_menu_sensitivity().
3050 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
3053 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
3056 * tests/testcombo.c (main): Make some rows insensitive.
3058 2004-05-26 Robert Ögren <gtk@roboros.com>
3060 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
3061 modifiers (shift, ctrl etc) in button and motion events from the
3064 2004-05-26 Robert Ögren <gtk@roboros.com>
3066 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
3067 implementation for extended input devices using last known
3068 device state (#143237)
3070 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
3072 * gtk/gtkframe.c: Move docs inline, fixing them on the
3073 way. (#143029, Steve Chaplin)
3075 2004-05-11 Robert Ögren <gtk@roboros.com>
3077 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
3078 events to windows that want extended input events. (#142943)
3079 (gdk_event_translate): Move check for extended input devices to
3080 propagate, new parameter to propagate.
3081 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
3082 _gdk_input_(un)grab_pointer. (#142943)
3084 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
3085 input grab. [Fix missing update of impl in "dijkstra" event
3086 propagation loop] Drop the parallel "impl" pointer, just use a
3087 cast. Don't propagate beyond windows that want normal input
3089 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
3090 implementation of input grab. (#142943)
3092 2004-05-22 Tor Lillqvist <tml@iki.fi>
3094 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
3095 line. (Spotted by Benoît Carpentier.)
3097 2004-05-18 Matthias Clasen <mclasen@redhat.com>
3099 * configure.in: Check for XFIXES extension.
3101 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
3102 a gboolean have_xfixes member.
3104 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
3105 XFIXES events and set have_xfixes.
3107 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
3108 (GdkEventOwnerChange): New event struct for owner change events.
3109 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
3111 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
3112 XFixesSelectionNotify events into GdkEventOwnerChange events.
3115 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
3116 (gdk_display_request_selection_notification): New api
3117 to support selection ownership notification.
3119 * gtk/gtkclipboard.h:
3120 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
3121 api to handle owner change events.
3122 (clipboard_peek): Refactored out the body of
3123 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
3125 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
3126 by calling _gtk_clipboard_handle_event().
3128 2004-05-18 Matthias Clasen <mclasen@redhat.com>
3130 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
3131 the P_() macros ourselves.
3133 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
3134 Restrict the width of the popup to be no larger than the
3135 monitor. (#142678, DmD Ljungmark)
3137 * gtk/gtkbutton.c: Go back to the initial fix for the
3138 focus-overdrawing problem, which was actually correct
3139 according to docs/widget_geometry.txt.
3141 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
3142 arrow size from 11 to 15 to compensate for that.
3144 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
3145 arguments of the ::move-cursor signal. (#142725)
3147 2004-05-17 Matthias Clasen <mclasen@redhat.com>
3151 * gtk/gtkbutton.c (gtk_button_size_request)
3152 (gtk_button_size_allocate, _gtk_button_paint): Allocate
3153 space for the focus rectangle only if necessary. (#142668,
3156 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
3160 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
3161 lines. (#142479, Morten Welinder)
3163 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
3165 * gtk/gtkintl.h (Q_): Add a Q_() macro.
3167 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
3168 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
3169 they are not really needed.
3171 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
3172 instead of hardwired padding, use Q_() for the default label,
3173 compute a reasonable minimal size. (#142571, #142572, #142573,
3174 Tommi Komulainen, Christian Persch)
3176 2004-05-15 Tor Lillqvist <tml@iki.fi>
3178 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
3179 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
3180 time). It is used by the OLE2_DND code, which is unfinished and
3181 presumably horribly broken, but still, let's not make it not
3182 compile on purpose. Silence some gcc warnings in the OLE2_DND
3185 2004-05-14 Matthias Clasen <mclasen@redhat.com>
3187 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
3188 New function to go from tree window to tree coordinates, kept
3189 static for now until we figure out the multiple coordinate
3190 system mess in GtkTreeView API-wise.
3191 (gtk_tree_view_scroll_to_cell): Transform the coordinates
3192 from tree window to tree coordinates, using the new function.
3193 Previously, the x coordinate was wrongly transformed. (#142494)
3195 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
3198 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
3199 modifier bit to mark stock item which need to be freed
3200 eventually. (#140654, Michal Pasternak, Scott Tsai)
3202 2004-05-11 Robert Ögren <gtk@roboros.com>
3204 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
3205 call to g_object_ref in Wintab code. (#138341)
3207 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
3208 including unallocated buffers for event->motion.axes and
3209 event->button.axes, unsigned wraparound problem in the code for
3210 detecting missing press/release events and assigning min instead
3211 of max when setting up axes.
3213 2004-05-12 Matthias Clasen <mclasen@redhat.com>
3215 * tests/testtreeedit.c: Add a progress column.
3217 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
3220 * gtk/gtk.h: Include gtkcellrendererprogress.h.
3222 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
3223 based on the one found in Epiphany.
3225 2004-05-11 Michael Natterer <mitch@gimp.org>
3227 * gtk/gtkcombobox.c (gtk_combo_box_popup)
3228 (gtk_combo_box_menu_button_press): don't allocate the popup
3229 smaller than the combobox. Fixes bug #59660.
3231 2004-05-11 Matthias Clasen <mclasen@redhat.com>
3233 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
3234 previous change to this function, clarify the docs instead.
3236 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
3237 GTK_SELECTION_BROWSE.
3239 * gtk/gtktreeview.c: Make hover selection work for
3240 GTK_SELECTION_BROWSE as well.
3242 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
3244 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
3245 Document the ::toggled signal.
3247 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3249 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
3251 2004-05-10 Matthias Clasen <mclasen@redhat.com>
3253 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
3255 * gdk/gdkdisplay.c (singlehead_...):
3256 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
3257 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
3258 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
3260 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
3261 note about COLUMN_FIXED restriction.
3263 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
3264 Set the entry in the default handler of the ::match-selected signal.
3267 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
3268 do the move-selected-item below pointer thingie, do the
3269 place-below-or-above one.
3271 * tests/testentrycompletion.c: Make the second example use the
3272 ::match-selected signal to make it actually work.
3274 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
3275 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
3276 mode. (#127648, Dave Bordoley)
3278 * gtk/gtktreeview.h:
3279 * gtk/gtktreeview.c: Add a new property "hover_selection", which
3280 when TRUE makes the selection follow the mouse. Also add setter
3281 and getter for the fixed_height property.
3283 2004-05-10 Matthias Clasen <mclasen@redhat.com>
3285 * gtk/gtkcombobox.c (gtk_combo_box_popup)
3286 (gtk_combo_box_menu_button_press): Make sure the menu pops up
3287 as wide as the combobox. (#59660, Havoc Pennington)
3289 2004-05-10 Matthias Clasen <mclasen@redhat.com>
3291 * gtk/gtkcombobox.h:
3292 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
3293 mode). Add a new property, add-tearoffs, for this. (#135956)
3295 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
3296 default button. (#118921)
3298 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3300 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
3301 that emits the grab notify signal.
3303 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
3305 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
3307 * gtk/gtkmenu.c: Make destruction of a torn off menu work
3308 like un-tearing off.
3310 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
3314 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
3315 Allow to suppress the stock accelerator by using "". (#142196,
3318 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
3322 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
3323 In list mode, accept the same mouse/wheel bindings on
3324 the cellview as on the button. (#136967)
3326 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
3328 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
3329 cached icons. (#135888, Crispin Flowerday)
3331 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
3333 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
3334 that we actually return menus for nodes of type menu, not the
3335 menuitems they're attached to.
3337 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
3339 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
3340 Add a note regarding UTF-8 requirements, proposed by
3341 Mariano Suárez-Alvarez.
3343 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
3345 * gtk/gtktearoffmenuitem.h:
3346 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
3347 into the GtkTearoffMenuItem struct, since it is used
3348 by the Gimp, and keep it synchronized with the
3349 tearoff_state property of the parent menu.
3351 2004-05-08 Hans Breuer <hans@breuer.org>
3353 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
3354 create the correct mask for 'pseudo mime' icons
3356 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
3357 take focus_on_map into account
3359 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
3361 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
3362 ... must return a value
3364 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
3366 2004-05-07 Matthias Clasen <mclasen@redhat.com>
3368 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
3369 draw over the focus rectangle.
3371 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
3372 standard focus style. (#63071, Bill Haneman, idea for new
3373 style by Owen Taylor)
3375 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
3376 focus on the colorwheel via details.
3378 2004-05-06 Matthias Clasen <mclasen@redhat.com>
3382 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
3383 this no longer needed signal handler. (#141817, Paul Pogonyshev)
3385 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
3387 * gtk/gtktearoffmenuitem.h:
3388 * gtk/gtktearoffmenuitem.c: Make the tearoff
3389 functionality model/view, the tearoffmenuitem being
3390 the view and the tearoff_state property of the menu
3391 being the model. (#101185, Owen Taylor)
3393 * gtk/gtkmenu.c: Add a tearoff_state property.
3395 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
3399 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
3400 popup the submenu for items in torn off menus. (#122051)
3402 2004-05-06 Sven Neumann <sven@gimp.org>
3404 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
3405 position the title lable next to the arrow just as we do for LTR
3406 rendering. Fixes bug #141825.
3408 2004-05-06 Matthias Clasen <mclasen@redhat.com>
3410 * docs/RELEASE-HOWTO: Document the new policy of
3411 bumping version numbers after release.
3413 * configure.in: Bump version number to 2.5.0.
3415 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
3418 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
3421 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
3423 * gtk/gtkactiongroup.h:
3424 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
3425 New function to translate a string with translate_func.
3428 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
3430 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
3431 (gtk_combo_box_get_row_span_column):
3432 (gtk_combo_box_get_column_span_column): Add missing getters
3433 for readwrite properies. (#135649)
3435 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
3437 * gtk/gtkcombobox.h:
3438 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
3439 Add gtk_combo_box_get_active_text() convenience
3440 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
3442 2004-05-05 Elijah Newren <newren@math.utah.edu>
3444 Changes to support do-not-focus-on-map hint in conjunction with
3445 _NET_WM_USER_TIME (#115650):
3447 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
3450 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
3453 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
3454 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
3456 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
3457 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
3458 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
3459 Initialize the focus_on_map field to TRUE.
3461 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
3462 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
3463 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
3464 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
3465 Implementations for the various backends. The Win32 and linux-fb
3466 implementations set the focus_on_map field, but don't use it yet
3467 to actually implement noinput windows. The X implementation sets
3468 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
3470 * gdk/x11/gdkwindow-x11.h:
3471 * gdk/x11/gdkevents-x11.c (set_user_time):
3472 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
3473 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
3474 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
3475 since we want that function to be part of the public API.
3477 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
3481 * gtk/gtkiconfactory.c (icon_source_clear): Don't
3482 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
3484 2004-05-05 Matthias Clasen <mclasen@redhat.com>
3488 * gtk/gtkuimanager.c (print_node): Make the output
3489 parseable. (#141929, Sven Neumann)
3491 2004-05-05 Tor Lillqvist <tml@iki.fi>
3493 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
3494 multi-monitor offset. (#141842, John Ehresman)
3496 2004-05-04 Federico Mena Quintero <federico@ximian.com>
3498 Fixes #139562, based on a patch by Christian Neumair.
3500 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
3501 a filter_combo_hbox field to contain the filter combo.
3502 (show_filters): Show/hide the filter_combo_hbox.
3503 (create_filename_entry_and_filter_combo): Removed.
3504 (file_pane_create): Create the filter_combo_hbox here.
3506 2004-05-04 Matthias Clasen <mclasen@redhat.com>
3508 * modules/input/gtkimcontextxim.c: Fix the recent
3509 string_conversion_callback change to work on
3510 Solaris. (#141190, Padraig O'Briain)
3512 * gtk/gtkselection.c: Disable debug logging again.
3514 2004-05-03 Matthias Clasen <mclasen@redhat.com>
3516 * gtk/gtkselection.c: Make the chunk size for
3517 incremental transfers depend on the maximal request
3518 size, capped at 256k. This should allow most selections
3519 to be transferred nonincrementally, avoiding many
3520 roundtrips and protocol overhead.
3522 2004-05-03 Federico Mena Quintero <federico@ximian.com>
3524 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
3525 g_signal_new() correctly and initialize the signal fields. Fixes
3526 #141749; patch based on Michael Natterer's.
3528 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
3530 * gtk/gtkselection.c (_gtk_selection_request): Fix
3531 a debug message to show correct information.
3532 (_gtk_selection_incr_event): Make INCRemental transfer
3533 of MULTIPLE targets work. This was broken since 1997!
3535 2004-05-02 Hans Breuer <hans@breuer.org>
3537 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
3538 modify the passed in GdkSegment(s) in place, we may get
3539 them again to draw at the same place. Fixes bug #129095,
3541 (draw_segments) draw the end pixel again to get the
3542 pixmap mask right, fixes bug #126710, #130202
3544 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
3545 fixes bug #106013, John Ehresman
3547 * gtk/makefile.msc.in : don't try to link gtk.res but
3548 use gtk-win32.res (as supposed to be fixed below :)
3550 2004-05-01 Hans Breuer <hans@breuer.org>
3552 * tests/Makefile.am : tests/makefile.msc is in CVS for
3553 a long time, finally added to EXTRA_DIST : fixes bug
3554 #141334, John Ehresman
3556 2004-04-30 Matthias Clasen <mclasen@redhat.com>
3558 * === Released 2.4.1 ===
3560 * configure.in: Version 2.4.1, interface age 1.
3564 2004-04-29 Federico Mena Quintero <federico@ximian.com>
3568 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
3569 function; moved the code over from
3570 remove_bookmark_button_clicked_cb().
3571 (remove_selected_bookmarks): Now, getting a non-removable bookmark
3572 is not an error, as we may be called as a result of hitting the
3574 (shortcuts_key_press_event_cb): New handler; delete the bookmark
3575 if the user presses Backspace, Delete, or KP_Delete.
3577 2004-04-29 Matthias Clasen <mclasen@redhat.com>
3579 * gtk/gtkaction.c (closure_accel_activate): Use
3580 _gtk_action_emit_activate() instead of directly
3581 emitting the activate signal. (#141429, Jody Goldberg)
3583 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
3584 Warn people when the accelerator can not be
3585 parsed. (#141429, Jody Goldberg)
3587 2004-04-29 Matthias Clasen <mclasen@redhat.com>
3589 * tests/testentrycompletion.c (main): Add a missing
3590 cat. (#141070, Chris Sherlock)
3592 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
3593 variable. (#141022, Chris Sherlock)
3595 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
3596 cast. (#141013, Chris Sherlock)
3598 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
3599 unused variable. (#141011, Chris Sherlock)
3601 2004-04-29 Tor Lillqvist <tml@iki.fi>
3603 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
3604 leak. (#140775, John Ehresman)
3606 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
3608 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
3609 to index the cached gcs, not depth. (#139494)
3611 2004-04-28 Matthias Clasen <mclasen@redhat.com>
3613 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
3615 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3617 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
3618 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
3620 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
3622 Patch to add support for string conversion callbacks to
3623 GtkIMContextXIM (#101814)
3625 * modules/input/gtkimcontextxim.c: Set the string conversion callback
3626 if supported by the XIC.
3628 (struct _GtkIMContextXIM): Add string_conversion_callback member.
3630 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
3631 whether string conversion callback is supported.
3633 (gtk_im_context_get_ic, +set_string_conversion_callback,
3634 +string_conversion_callback): Also initialize string conversion
3635 callback, if supported, along with the IC initialization.
3637 * modules/input/imxim.c: Make "xim" module default for Thai as well.
3639 2004-04-23 Matthias Clasen <mclasen@redhat.com>
3641 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
3642 initialize targets. (#139883, John Finlay)
3644 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
3646 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
3647 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
3650 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
3651 Remove an excessive g_return_if_fail().
3653 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
3655 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
3656 _-prefix calls of gdk_x11_window_set_user_time().
3658 2004-04-22 Matthias Clasen <mclasen@redhat.com>
3660 * gtk/gtkuimanager.c (update_node): Make sure the separators
3661 used to demarkate placeholder ends don't show up on
3662 show_all(). (#140496, Murray Cumming)
3664 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
3665 work with negative increments. (#137975, Tim Gerla)
3667 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3669 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
3670 gtk_tool_button_set_icon_widget): Remove the old widget from the
3671 tool button before overwriting it with the new widget.
3673 (#140508, Todd Goyen)
3675 2004-04-22 Tor Lillqvist <tml@iki.fi>
3677 Fix the file chooser on Windows. I can't make it misbehave or
3678 crash any more now. But presumably there are still corner cases
3679 not handled. I haven't really checked behaviour of UNC paths, for
3682 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
3683 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
3686 (gtk_file_system_win32_get_parent): Like the Unix version, assert
3687 filename is absolute, and avoid one unnecessary string allocation
3690 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
3691 letters more correctly.
3693 (gtk_file_system_win32_render_icon): Assure correct syntax is used
3694 for root folder of a drive. (#137962, Morten Welinder)
3696 (filename_is_some_root): New function that accepts also root
3697 without any drive specified.
3699 (filename_is_drive_root): Rename from filename_is_root.
3701 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
3704 2004-04-21 Matthias Clasen <mclasen@redhat.com>
3706 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
3707 completion window if there are no completions anymore.
3709 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
3710 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
3711 It doesn't like that. (#140642, Christian Persch)
3713 * demos/gtk-demo/expander.c (do_expander): A new demo.
3715 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
3717 2004-04-20 Matthias Clasen <mclasen@redhat.com>
3719 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
3720 sure anchored children get size allocated, even if the layout
3721 is valid. (#122323, Andrew E. Makeev)
3722 (gtk_text_view_scroll_pages):
3723 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
3724 if we already have pending scrolls. Bandaid fix for #78513.
3726 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
3728 * INSTALL.in: Update libpng and libjpeg URLs, remove
3729 note about building without since that's not the normal
3732 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
3734 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
3735 handling of SVG/non-SVG unthemed icons.
3737 2004-04-19 Morten Welinder <terra@gnome.org>
3739 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
3742 2004-04-19 Matthias Clasen <mclasen@redhat.com>
3744 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
3745 Don't stop the iteration up to the tag_root too
3746 early. (#109945, Dongho Shin)
3748 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3750 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
3751 gdk_keymap_translate_keyboard_state() handle NULL
3752 keymaps. (#139715, Torsten Schoenfeld).
3754 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3756 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
3757 reported by Pedro RODRIGUEZ, about compilation problems when
3758 Xcursor is installed in a non-standard location.
3760 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
3762 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
3765 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
3766 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
3768 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
3770 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
3773 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
3774 property on user interaction.
3776 2004-04-15 Federico Mena Quintero <federico@ximian.com>
3778 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
3779 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
3781 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
3782 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
3785 2004-04-15 Matthias Clasen <mclasen@redhat.com>
3787 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
3788 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
3790 2004-04-14 Matthias Clasen <mclasen@redhat.com>
3792 * gtk/gtkcombobox.c:
3794 Make all style properties readonly.
3796 2004-04-14 Matthias Clasen <mclasen@redhat.com>
3798 * gtk/gtkcolorsel.c: Add a11y relations between the color
3799 wheel and the spin buttons. (#132745, Padraig O'Briain)
3801 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
3802 the meaning of size == -1.
3804 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
3805 a size of -1. (#137436, Brian Cameron)
3807 * gtk/gtkcombobox.c: Make the arrow and separator regular
3808 children of an hbox inside the button, and propagate state
3809 changes from the button to the cell view. (part of the fix
3810 for #138650, should also fix #137535)
3812 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
3813 state to gtk_cell_renderer_render() when prelighted. (part
3814 of the fix for #138650)
3816 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
3817 Use PRELIGHT state when appropriate. (part of the fix for
3820 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
3821 out warnings if called before the combo box is
3822 realized. (#139742, Philip Langdale)
3824 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
3826 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
3829 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
3831 * gtk/gtkpathbar.c (make_directory_button): remove spurious
3834 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
3836 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
3837 make the buttons sized by a bold label. This makes the text
3838 'swim' a little, but stops the buttons from resizing, #137210
3840 2004-04-13 Matthias Clasen <mclasen@redhat.com>
3842 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
3844 (start_element_handler): Accept separators without unique
3845 names. (#133302, Anders Carlsson)
3847 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
3848 possible accelerator gotcha when using this function. (#139641,
3851 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
3852 list nodes. (#138862, Morten Welinder)
3854 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
3856 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
3858 (gtk_tree_view_button_press): If we activated the row we don't
3859 want to grab focus back, as moving focus to another widget is
3860 pretty common, #138458
3862 2004-04-12 Federico Mena Quintero <federico@ximian.com>
3864 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
3865 documentation to all the signals.
3867 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
3869 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
3870 model if it is NULL. (#139770)
3872 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
3874 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
3875 a shadow inside the scrolled window, add it around the vbox.
3877 * gtk/gtkentryprivate.h:
3878 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
3879 Return a boolean indicating whether the popup is positioned above
3880 or below. Scroll the completions to the beginning or the end,
3881 depending on the positioning.
3883 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
3884 wrap around in the entry completion popup, and allow GDK_UP to
3885 enter the popup. (#137440)
3887 2004-04-12 Matthias Clasen <mclasen@redhat.com>
3889 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
3890 there before using it.
3892 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
3894 * gtk/gtktreeprivate.h: Moved search entries into priv data.
3896 * gtk/gtktreeview.c: Prep for type-ahead support.
3898 (gtk_tree_view_destroy): Destroy the search window explicitly.
3899 (gtk_tree_view_key_press): Minor change; prep for type-ahead
3900 (gtk_tree_view_ensure_interactive_directory): New function
3901 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
3902 (gtk_tree_view_real_start_interactive_search): rework
3903 (gtk_tree_view_search_dialog_hide): ditto
3904 (gtk_tree_view_search_delete_event): ditto
3905 (gtk_tree_view_search_button_press_event): ditto
3906 (gtk_tree_view_search_key_press_event): ditto
3907 (gtk_tree_view_search_move): ditto
3908 (gtk_tree_view_search_init): ditto
3910 * gtk/gtktreeviewcolumn.c:
3911 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
3913 * tests/testfilechooser.c: (main): change
3915 2004-04-11 Hans Breuer <hans@breuer.org>
3917 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
3918 the real fix would involve just another small API breakage,
3919 i.e. gdk_spawn_* using GPid not just gint.
3921 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
3923 2004-04-10 Tor Lillqvist <tml@iki.fi>
3925 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
3926 If both Shift and CapsLock pressed, ignore the shift only for
3927 letters (that would have been affected by the CapsLock). (#139095)
3929 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
3930 seems to be even buggier now than it used to be. (#138341)
3931 Initialize _gdk_input_ignore_wintab to TRUE.
3933 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
3934 GDK_USE_WINTAB environment variable to turn on tablet support.
3936 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
3938 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
3939 (gtk_ui_manager_remove_action_group): Terminate
3940 g_object_[dis]connect() calls with NULL instead of 0.
3943 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
3945 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
3947 2004-04-07 Federico Mena Quintero <federico@ximian.com>
3951 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
3952 passed-in 'str' is not NULL.
3954 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
3955 expands "~/" or "~foo/" at the beginning of a filename.
3956 (gtk_file_system_unix_parse): Use expand_tilde() before doing
3959 * gtk/gtkfilechooserentry.c
3960 (gtk_file_chooser_entry_maybe_update_directory): Take in a
3961 force_reload argument.
3962 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
3963 returns an error, set the file_part_pos to -1.
3964 (load_directory_callback): Only populate the model if the
3965 file_part_pos is not -1.
3967 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
3969 * configure.in: Added Icelandic (is) to ALL_LINGUAS
3971 2004-04-05 Federico Mena Quintero <federico@ximian.com>
3973 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
3974 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
3976 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
3977 for G_DIR_SEPARATOR in the display_name, and err out if it is
3978 present; use the same error message as Nautilus. Fixes #136467.
3980 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
3981 new-folder button say "Create Fo_lder" rather than "Create
3982 _Folder", so that the mnemonic doesn't conflict with the "Save in
3983 _folder" label. Fixes #136975.
3985 2004-04-05 Federico Mena Quintero <federico@ximian.com>
3987 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
3988 buttons. Also, free them correctly upon failure. Based on a
3989 patch by Morten Welinder, fixes #137956.
3991 2004-04-05 Anders Carlsson <andersca@gnome.org>
3993 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
3995 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
3997 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
3998 correctly for fixed height when inserting a node, #138082
4000 2004-04-01 Federico Mena Quintero <federico@ximian.com>
4004 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
4005 "child_is_hidden" boolean argument to the "path-clicked" signal.
4007 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
4009 (make_directory_button): Take a file_is_hidden argument; put it in
4011 (_gtk_path_bar_set_path): See whether each path component path is
4013 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
4014 "path-clicked" signal.
4015 (button_clicked_cb): See if the downwards button represents a
4016 hidden file for the file_is_hidden argument in the signal
4019 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
4021 * gtk/gtkfilechooserdefault.c
4022 (gtk_file_chooser_default_select_path): If we fail to switch
4023 folders, don't try to select the path in the file system model.
4024 Also, return the result from _gtk_file_system_model_path_do().
4025 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
4026 file system model if we are asked to select a hidden file.
4027 (path_bar_clicked): Show hidden files based on whether the
4028 immediate downwards folder in the path bar is a hidden file
4030 (struct _GtkFileChooserDefault): Added fields
4031 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
4032 (create_file_list): Set an object data key of
4033 "GtkFileChooserDefault" on the tree view so that we can find the
4034 impl from the popup menu callbacks. Also, hook up to the
4035 "button-press-event" and "popup-menu" signals in the file list to
4036 bring up a popup menu.
4037 (list_popup_menu_cb): New callback.
4038 (list_button_press_event_cb): New callback.
4042 * gtk/gtkfilesystemmodel.c
4043 (_gtk_file_system_model_new): Oops, connect_object to
4046 2004-03-31 Tor Lillqvist <tml@iki.fi>
4048 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
4049 for native Win32. (#136559, J. Ali Harlow)
4051 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
4052 angles. Thanks to Tim Newsham.
4054 2004-03-29 Federico Mena Quintero <federico@ximian.com>
4058 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
4059 for an ::is_finished_loading() method and a ::finished_loading()
4060 signal at the end of the struct.
4062 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
4063 "finished-loading" signal.
4064 (gtk_file_folder_is_finished_loading): New function.
4066 * gtk/gtkfilesystemunix.c
4067 (gtk_file_folder_unix_is_finished_loading): Implement.
4069 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
4070 slot for a "finished-loading" signal.
4071 (gtk_file_system_model_class_init): Create the "finished-loading"
4073 (struct _GtkFileSystemModel): New field
4074 idle_finished_loading_source. We emit the "finished-loading"
4075 signal in an idle if the root folder was done loading right in
4076 _gtk_file_system_model_new(), so that the caller has a chance to
4077 connect to the signal.
4078 (_gtk_file_system_model_new): Connect to the normal signals of the
4079 folder even if the initial _list_children() fails. Also, see if
4080 the folder is finished loading; connect to the "finished-loading"
4082 (gtk_file_system_model_finalize): Remove the idle handler.
4084 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
4085 and connect to the model's "finished-loading" signal.
4086 (get_toplevel): New helper function.
4087 (error_message): Use get_toplevel().
4088 (trap_activate_cb): Likewise.
4089 (location_popup_handler): Likewise.
4090 (set_busy_cursor): New function.
4091 (browse_files_model_finished_loading_cb): New callback.
4093 2004-03-25 Federico Mena Quintero <federico@ximian.com>
4095 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
4096 file under the cursor; we don't need the logic from
4097 GtkFileSelection after all. Fixes #132255.
4099 2004-03-25 Federico Mena Quintero <federico@ximian.com>
4101 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
4102 location entry with the display name of the file under the cursor
4103 for Open mode, or the typed filename in Save mode.
4105 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
4107 * gtk/gtkfilesystemwin32.c
4108 (filename_is_root): Bare drive designators (eg., "c:") are
4109 no longer considered as root filenames. Fixed #137942
4111 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
4113 * gtk/gtkfilesystemwin32.c
4114 (gtk_file_system_win32_create_folder): Invert test for error in
4115 mkdir. Fixes #137945
4117 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
4119 Fixed #138004 using Federico's code from #132327.
4121 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
4122 folder_hash field to keep a list of live folder objects.
4123 (gtk_file_system_win32_init): Create the folder_hash.
4124 (gtk_file_system_win32_finalize): Destroy the folder_hash.
4125 (gtk_file_system_win32_get_folder): Ref and return an existing
4126 folder if we have it around, otherwise return a new folder object.
4127 (struct _GtkFileFolderWin32): Add a field for the parent file system.
4128 (gtk_file_folder_win32_finalize): Remove the folder from the file
4129 system's hash table.
4130 (gtk_file_system_win32_create_folder): Emit "files-added" on the
4131 newly-created folder's parent. Fixes #138004.
4133 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
4135 * gtk/gtkfilesystemwin32.c
4136 (gtk_file_system_win32_get_folder): Test that path is actually
4137 a directory and throw error if not. Fixed bug #137950
4139 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
4141 * gtk/gtkfilesystemwin32.c
4142 (gtk_file_system_win32_volume_get_display_name): Ignore empty
4143 volume labels; assume that GetVolumeInformation would fail if
4144 GetVolumeInformationW does; catches a small memory leak;
4145 pass the buffer size to GetVolumeInformationW in wide
4146 characters instead of bytes. Fixes bug #137543
4147 (list_volumes): Cope with the theoretical possibility of
4148 more than 26 logical drives. Fixes bug #137940
4149 (bookmarks_serialize): Now actually removes bookmarks.
4152 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
4154 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
4156 2004-03-21 Tor Lillqvist <tml@iki.fi>
4158 * gtk/gtkfilesystemwin32.c
4159 (gtk_file_system_win32_volume_get_base_path): Include the
4160 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
4161 NULL for a volume base path, as g_filename_to_uri() requires an
4162 absolute path, and just a drive letter and colon isn't. (#137543)
4164 2004-03-20 Hans Breuer <hans@breuer.org>
4166 * gtk/gtkfilesystemwin32.c : applied the undisputable and
4167 required [due to recent gtkfilesystem internal api semantic
4168 changes] part of patches to fix bug #137543 (Tor Lillqvist,
4171 * gdk/gdkevents-win32.c (handle_configure_event) :
4172 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
4173 GdkWindowObject::x, y with screen coords to make
4174 gdk_window_get_position () return the right thing and thus fix
4175 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
4177 2004-03-19 Federico Mena Quintero <federico@ximian.com>
4179 * Revert the patch to #137520, as 2.4.1 is for conservative bug
4180 fixes only. The patch is attached to the bug report, for
4183 2004-03-19 Morten Welinder <terra@gnome.org>
4185 * gtk/gtkfilechooserdefault.c
4186 (gtk_file_chooser_default_set_current_folder): Test existance of
4187 the path after checking for locality, if needed.
4189 2004-03-19 Federico Mena Quintero <federico@ximian.com>
4193 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
4194 for an ::is_finished_loading() method and a ::finished_loading()
4195 signal at the end of the struct.
4197 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
4198 "finished-loading" signal.
4199 (gtk_file_folder_is_finished_loading): New function.
4201 * gtk/gtkfilesystemunix.c
4202 (gtk_file_folder_unix_is_finished_loading): Implement.
4204 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
4205 slot for a "finished-loading" signal.
4206 (gtk_file_system_model_class_init): Create the "finished-loading"
4208 (struct _GtkFileSystemModel): New field
4209 idle_finished_loading_source. We emit the "finished-loading"
4210 signal in an idle if the root folder was done loading right in
4211 _gtk_file_system_model_new(), so that the caller has a chance to
4212 connect to the signal.
4213 (_gtk_file_system_model_new): Connect to the normal signals of the
4214 folder even if the initial _list_children() fails. Also, see if
4215 the folder is finished loading; connect to the "finished-loading"
4217 (gtk_file_system_model_finalize): Remove the idle handler.
4219 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
4220 and connect to the model's "finished-loading" signal.
4221 (get_toplevel): New helper function.
4222 (error_message): Use get_toplevel().
4223 (trap_activate_cb): Likewise.
4224 (location_popup_handler): Likewise.
4225 (set_busy_cursor): New function.
4226 (browse_files_model_finished_loading_cb): New callback.
4228 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
4230 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
4231 eventbox for expander. (#137564, reported by
4234 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
4236 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
4238 2004-03-17 Morten Welinder <terra@gnome.org>
4240 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
4241 volumes not actually put into the shortcut list.
4243 * tests/prop-editor.c (object_changed): Plug leak.
4245 * tests/testfilechooser.c (main): Plug some leaks and expose
4248 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
4249 object. Fixed #136652.
4251 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
4252 have no screen. Fixes #137260.
4253 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
4254 thereby fixing leak. Fixes #137259.
4256 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
4257 slider buttons have been destroyed.
4258 (gtk_path_bar_remove): Make this work for slider buttons too.
4261 2004-03-15 Morten Welinder <terra@gnome.org>
4263 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
4264 Sanitize and plug leak.
4265 (check_icon_theme): Only do something if the widget has a screen.
4267 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
4269 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
4270 Move the repositioning logic from _gtk_entry_completion() popup
4271 over here. Fixes #137355, reported by Niklas Knutsson.