glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
#ifndef ROAM_DEBUG
+ g_mutex_lock(&opengl->sphere_lock);
roam_sphere_update_errors(opengl->sphere);
roam_sphere_split_merge(opengl->sphere);
+ g_mutex_unlock(&opengl->sphere_lock);
#endif
#ifdef ROAM_DEBUG
{
struct RenderLevel *level = value;
if (level->sorted.next)
- g_list_free(level->sorted.next);
+ g_list_free_full(level->sorted.next, g_object_unref);
if (level->unsorted.next)
- g_list_free(level->unsorted.next);
+ g_list_free_full(level->unsorted.next, g_object_unref);
g_free(level);
}
-static gpointer grits_opengl_add(GritsViewer *_opengl, GritsObject *object,
+static void grits_opengl_add(GritsViewer *_opengl, GritsObject *object,
gint num, gboolean sort)
{
g_assert(GRITS_IS_OPENGL(_opengl));
if (list->next)
list->next->prev = link;
list->next = link;
+ object->ref = link;
+ g_object_ref(object);
g_mutex_unlock(&opengl->objects_lock);
- return link;
}
-static GritsObject *grits_opengl_remove(GritsViewer *_opengl, GritsObject *object)
+void grits_opengl_remove(GritsViewer *_opengl, GritsObject *object)
{
g_assert(GRITS_IS_OPENGL(_opengl));
GritsOpenGL *opengl = GRITS_OPENGL(_opengl);
- GList *link = object->ref;
+ if (!object->ref)
+ return;
g_mutex_lock(&opengl->objects_lock);
+ GList *link = object->ref;
/* Just unlink and free it, link->prev is assured */
link->prev->next = link->next;
if (link->next)
link->next->prev = link->prev;
- g_mutex_unlock(&opengl->objects_lock);
- object->ref = NULL;
- object->viewer = NULL;
g_free(link);
+ object->ref = NULL;
g_object_unref(object);
- return object;
+ g_mutex_unlock(&opengl->objects_lock);
}
/****************
static void grits_opengl_dispose(GObject *_opengl)
{
g_debug("GritsOpenGL: dispose");
+ GritsOpenGL *opengl = GRITS_OPENGL(_opengl);
+ if (opengl->objects) {
+ GQueue *objects = opengl->objects;;
+ opengl->objects = NULL;
+ g_mutex_lock(&opengl->objects_lock);
+ g_queue_foreach(objects, _objects_free, NULL);
+ g_queue_free(objects);
+ g_mutex_unlock(&opengl->objects_lock);
+ }
G_OBJECT_CLASS(grits_opengl_parent_class)->dispose(_opengl);
}
static void grits_opengl_finalize(GObject *_opengl)
g_debug("GritsOpenGL: finalize");
GritsOpenGL *opengl = GRITS_OPENGL(_opengl);
roam_sphere_free(opengl->sphere);
- g_queue_foreach(opengl->objects, _objects_free, NULL);
- g_queue_free(opengl->objects);
g_mutex_clear(&opengl->objects_lock);
g_mutex_clear(&opengl->sphere_lock);
+ gtk_gl_disable(GTK_WIDGET(opengl));
G_OBJECT_CLASS(grits_opengl_parent_class)->finalize(_opengl);
}
static void grits_opengl_class_init(GritsOpenGLClass *klass)