Cody Russell [Mon, 8 Oct 2007 15:02:23 +0000 (15:02 +0000)]
Fix memory leak, and fix two instances where a GtkRequisition and a
2007-10-08 Cody Russell <bratsche@gnome.org>
* modules/engines/ms-windows/msw_style.c:
(draw_tab): Fix memory leak, and fix two instances where
a GtkRequisition and a GtkBorder were being freed with
g_free() rather than gtk_requisition_free() and
gtk_border_free(). (#484730, Daniel Atallah)
Cody Russell [Mon, 8 Oct 2007 14:49:26 +0000 (14:49 +0000)]
Fix a typo in GdkEventGrabBroken where it said "@grab_window id NULL" and
2007-10-08 Cody Russell <bratsche@gnome.org>
* docs/reference/gdk/tmpl/event_structs.sgml:
Fix a typo in GdkEventGrabBroken where it said
"@grab_window id NULL" and should say
"@grab_window is NULL". (#484650, Chris Lord)
don't "corrupt" all iterators by reversing the list after adding the
2007-10-08 Kristian Rietveld <kris@imendio.com>
* gtk/gtkfilesystemmodel.c (got_root_folder_cb),
(get_children_get_folder_cb): don't "corrupt" all iterators by
reversing the list after adding the items. Reversing the list isn't
needed anyway as the order of the items in the model does not matter.
(Fixes #327243, comment 10).
* gtk/gtktooltip.c (gtk_tooltip_display_closed): use g_object_set_data
instead of g_object_set ...
(_gtk_tooltip_toggle_keyboard_mode),
(_gtk_tooltip_handle_event): connect to GdkDisplay::closed after
creating tooltip.
Murray Cumming [Fri, 5 Oct 2007 08:18:43 +0000 (08:18 +0000)]
Revert the change on 2007-04-29 (Also check the default handler when
2007-10-05 Murray Cumming <murrayc@murrayc.com>
* gtk/gtkprintoperation.c: (print_pages_idle):
Revert the change on 2007-04-29 (Also check
the default handler when deciding whether to emit the
paginate signal. (#345345, Yevgen Muntyan)).
This stopped printing from working in gtkmm, and is apparently
not appropriate anyway. Bug #482089.
Emmanuele Bassi [Thu, 4 Oct 2007 22:52:13 +0000 (22:52 +0000)]
Iterate on the proxies we hold when we change the sorting function and the
2007-10-04 Emmanuele Bassi <ebassi@gnome.org>
* gtk/gtkrecentaction.c:
(gtk_recent_action_set_sort_func), (set_current_filter): Iterate
on the proxies we hold when we change the sorting function and
the filter.
(gtk_recent_action_connect_proxy),
(gtk_recent_action_create_menu): Set the GtkRecentChooser:filter
property when we create/connect a proxy chooser. Thanks to
Jonh Wendell for pointing this bug out on gtk-list.
(gtk_recent_chooser_set_property): Bail out without iterating
over the proxies when there's no need to.
Loïc Minier [Thu, 4 Oct 2007 07:40:55 +0000 (07:40 +0000)]
Fix warnings and display of modified date / time in filechooser for some
2007-10-04 Loïc Minier <lool@dooz.org>
* gtk/gtkfilechooserdefault.c: (list_mtime_data_func): Fix warnings
and display of modified date / time in filechooser for some locales as
it was missing a locale to UTF-8 conversion. Fixes #482504.
Richard Hult [Tue, 2 Oct 2007 17:51:06 +0000 (17:51 +0000)]
Don't do anything while in fullscreen mode. (gdk_window_set_decorations):
2007-10-02 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkwindow-quartz.c: (gdk_window_move),
(gdk_window_resize): Don't do anything while in fullscreen mode.
(gdk_window_set_decorations): Update the size of the window after
showing/hiding the title bar so the size of the content area
doesn't change.
(gdk_window_get_decorations): NSBorderlessWindowMask is 0, so
don't try to check it as a bit being set.
(gdk_window_fullscreen), (gdk_window_unfullscreen): Implement.
455284 - Focus or toggle location entry
2007-10-02 Federico Mena Quintero <federico@novell.com>
Fix http://bugzilla.gnome.org/show_bug.cgi?id=455284 - In the file
chooser, Ctrl-L should switch to the location entry. If we are
already on the location entry, turn it off. Based on a patch by
Jaap A. Haitsma <jaap@haitsma.org> and an idea by Wouter
Bolsterlee.
* gtk/gtkfilechooserdefault.c (location_button_toggled_cb): Call
location_mode_set() directly instead of using toggle_location_mode().
(toggle_location_mode): Removed.
(location_toggle_popup_handler): If the file entry is not visible,
show it. If it is visible, turn it off only if it is focused.
Otherwise, switch to the entry.
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=18874
fix up if-condition to only set the true arrow type if show_sort_indicator
2007-10-01 Kristian Rietveld <kris@imendio.com>
* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_update_button):
fix up if-condition to only set the true arrow type if
show_sort_indicator is TRUE. (#448343, reported by Emil Nowak).
* gtk/gtksearchenginesimple.c:
(gtk_search_engine_simple_dispose), (search_thread_done_idle): Cancel
the file tree walking thread when disposing the search engine
implementation.
* gtk/gtkfilechooserdefault.c (search_stop_searching): Forcibly
stop the search engine implementation when stopping the search,
instead of just unreffing the object.
add extra NULL check for tooltipsdata to avoid code fiddling with
2007-09-24 Kristian Rietveld <kris@imendio.com>
* gtk/gtktooltips.c (gtk_tooltips_set_tip): add extra NULL check
for tooltipsdata to avoid code fiddling with active_tips_data
from crashing. (Fixes #460194, Peter Wright, Matthijs De Smedt).
gtk/gtkstyle.c (option_menu_get_props) use gtk_requisition_free() instead
2007-09-21 Manish Singh <yosh@gimp.org>
* gtk/gtkstyle.c (option_menu_get_props)
* gtk/gtkoptionmenu.c (gtk_option_menu_get_props): use
gtk_requisition_free() instead of g_free() for freeing
requisitions.
Michael Natterer [Fri, 21 Sep 2007 14:29:59 +0000 (14:29 +0000)]
merged patch from maemo-gtk which handles failed keynav correctly also
2007-09-21 Michael Natterer <mitch@imendio.com>
* gtk/gtktextview.c (gtk_text_view_move_cursor_internal)
(gtk_text_view_move_viewport): merged patch from maemo-gtk which
handles failed keynav correctly also when the cursor is invisible.
(Tommi Komulainen)
Michael Natterer [Fri, 21 Sep 2007 14:29:08 +0000 (14:29 +0000)]
merged patch from maemo-gtk which handles failed keynav correctly also
2007-09-21 Michael Natterer <mitch@imendio.com>
* gtk/gtktextview.c (gtk_text_view_move_cursor_internal)
(gtk_text_view_move_viewport): merged patch from maemo-gtk which
handles failed keynav correctly also when the cursor is invisible.
(Tommi Komulainen)
Cody Russell [Thu, 20 Sep 2007 16:51:16 +0000 (16:51 +0000)]
Override draw_layout method in GtkStyle in order to adjust by 2 pixels any
2007-09-20 Cody Russell <bratsche@gnome.org>
* modules/engines/ms-windows/msw_style.c: Override draw_layout
method in GtkStyle in order to adjust by 2 pixels any labels
that are in GtkNotebook tabs using XP theme, so that they appear
correctly centered. (#478637)
Michael Natterer [Sat, 15 Sep 2007 16:48:56 +0000 (16:48 +0000)]
don't simply crash if any of the pointer args are NULL. Instead,
2007-09-15 Michael Natterer <mitch@imendio.com>
* gtk/gtkselection.c (gtk_target_list_find): don't simply crash if
any of the pointer args are NULL. Instead, g_return_if_fail() on
"list != NULL" and allow to pass NULL as return location for "info".
the tooltip-column property getter needs to set an integer, not a boolean.
2007-09-14 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_get_property): the tooltip-column
property getter needs to set an integer, not a boolean. (#476689,
spotted and patch by Christian Persch).
if cell is set, always pass in path to gtk_tree_view_get_cell_area()
2007-09-13 Kristian Rietveld <kris@imendio.com>
* gtk/gtktreeview.c (gtk_tree_view_set_toooltip_cell): if cell
is set, always pass in path to gtk_tree_view_get_cell_area() whether
it is NULL or set. Added explanatory comment and added this
side case to the API documentation.
Use the "document-open-recent" icon for the the Recently Used shortcut in
2007-09-12 Emmanuele Bassi <ebassi@gnome.org>
* gtk/gtkfilechooserdefault.c (render_recent_icon): Use the
"document-open-recent" icon for the the Recently Used shortcut
in the file chooser. (#306445)
* gtk/Makefile.am:
* gtk/stock-icons/16/document-open-recent.png:
* gtk/stock-icons/16/document-open-recent.svg:
* gtk/stock-icons/24/document-open-recent.png:
* gtk/stock-icons/24/document-open-recent.svg: Add the
"document-open-recent" icon to the builtin theme we provide
as a fallback.
* gdk/gdk.symbols:
* gdk/gdkwindow.[ch]
(gdk_window_freeze_toplevel_updates_libgtk_only),
(gdk_window_thaw_toplevel_updates_libgtk_only): new functions
to freeze a toplevel window and all its descendants. To be made
public in 2.14,
(gdk_window_schedule_update): return if toplevel is frozen,
(gdk_window_process_all_updates): defer processing updates if toplevel
is frozen.
* gtk/gtkwindow.c (gtk_window_configure_event): directly size
allocate for override redirect windows, freeze toplevel and
descendants otherwise and wait until resizing is done.
Michael Natterer [Tue, 11 Sep 2007 18:54:00 +0000 (18:54 +0000)]
remove useless member "has_title" from the private struct and simply set
2007-09-11 Michael Natterer <mitch@imendio.com>
* gtk/gtkfilechooserbutton.c: remove useless member "has_title"
from the private struct and simply set the default title in
constructor() whenever we create a dialog or the supplied one has
no title. Also accept RESPONSE_ACCEPT *and* RESPONSE_OK as
affirmative responses and document that accordingly. Fixes bug
#436576. Fixed all compiler warnings in the file.
Michael Natterer [Tue, 11 Sep 2007 17:38:12 +0000 (17:38 +0000)]
Make sure menu_shell->button gets reset to 0 when we bail out early here
2007-09-11 Michael Natterer <mitch@imendio.com>
* gtk/gtkmenu.c (gtk_menu_button_release): Make sure
menu_shell->button gets reset to 0 when we bail out early here
instead of chaining up, so it is in a consistent state for the
next press/release in GtkMenuShell. Fixes bug #449371.
projects / ~andy / gtk / log