]> Pileus Git - ~andy/gtk/log
~andy/gtk
12 years agoUpdated Japanese translation
Jiro Matsuzawa [Sun, 16 Oct 2011 16:25:41 +0000 (01:25 +0900)]
Updated Japanese translation

12 years agoUpdated British English translation
Bruce Cowan [Sun, 16 Oct 2011 13:45:05 +0000 (14:45 +0100)]
Updated British English translation

12 years agoBug 658772: Directory paths for resource directories are hard coded.
John Ralls [Fri, 14 Oct 2011 23:39:37 +0000 (16:39 -0700)]
Bug 658772: Directory paths for resource directories are hard coded.

Corrected formatting to match coding standards; introduced local statics
to prevent leaking returned strings.

12 years agogtk: fix syntax of an annotation
Torsten Schönfeld [Sat, 15 Oct 2011 17:37:43 +0000 (19:37 +0200)]
gtk: fix syntax of an annotation

12 years agoUse G_VALUE_INIT
Javier Jardón [Fri, 30 Sep 2011 15:31:04 +0000 (16:31 +0100)]
Use G_VALUE_INIT

Instead of an explicit { 0, } when declaring the variable.

12 years agogdk: s/gdk_cursor_unref/g_object_unref/
Michael Natterer [Sat, 15 Oct 2011 12:35:28 +0000 (14:35 +0200)]
gdk: s/gdk_cursor_unref/g_object_unref/

12 years agoFixed referenced images for GTK_STOCK_INDENT
Sebastian Pölsterl [Fri, 14 Oct 2011 15:40:01 +0000 (17:40 +0200)]
Fixed referenced images for GTK_STOCK_INDENT

https://bugzilla.gnome.org/show_bug.cgi?id=661780

12 years agoAdd deprecation annotations for GtkHandleBox and GtkTable
Matthias Clasen [Fri, 14 Oct 2011 04:54:01 +0000 (00:54 -0400)]
Add deprecation annotations for GtkHandleBox and GtkTable

12 years agobuild: Strip out -DG_DISABLE_DEPRECATED
Colin Walters [Wed, 12 Oct 2011 15:54:56 +0000 (11:54 -0400)]
build: Strip out -DG_DISABLE_DEPRECATED

It's unnecessary pain now that they're warnings.

12 years agoBug 660730: Win32: Only use _fstat32 if available
Chun-wei Fan [Wed, 12 Oct 2011 03:39:06 +0000 (11:39 +0800)]
Bug 660730: Win32: Only use _fstat32 if available

_fstat32 is only introduced with msvcrt80.dll (i.e. Visual C++ 2005), in
which using this function will break compilation with MinGW, which links
against msvcrt.dll.  The msvcrt.lib in the Windows DDK which links to
a later incarnation of the msvcrt.dll in later Windows systems may have
this symbol defined, but that needs to be checked upon to be sure.

Thanks to Dieter Verfaillie for pointing out this problem.

12 years agoAdd deprecation annotations for deprecated functions
Matthias Clasen [Tue, 11 Oct 2011 19:03:46 +0000 (15:03 -0400)]
Add deprecation annotations for deprecated functions

We define our own GDK_DEPRECATED[_FOR] macros for this
and allow it to be turned off by defining the
GDK_DISABLE_DEPRECATION_WARNINGS macro.

12 years agoInclude gdk.h in gail.c
Matthias Clasen [Tue, 11 Oct 2011 19:01:41 +0000 (15:01 -0400)]
Include gdk.h in gail.c

This is needed so that we pick up deprecation macros here in the
future.

12 years agoAdd a new symbol
Matthias Clasen [Mon, 10 Oct 2011 15:02:33 +0000 (11:02 -0400)]
Add a new symbol

gtk_widget_get_modifier_mask was added recently.

12 years agoFix void function n gtkfontbutton.c so it does not try to return a value.
Brian Cameron [Mon, 10 Oct 2011 19:13:35 +0000 (14:13 -0500)]
Fix void function n gtkfontbutton.c so it does not try to return a value.
 Fixes bug #661089.

12 years agoBug 658767 - Drag and Drop NSEvent capture is racy
John Ralls [Sun, 25 Sep 2011 01:19:56 +0000 (18:19 -0700)]
Bug 658767 - Drag and Drop NSEvent capture is racy

Create a synthetic NSMouseLeftDown to store in the GtkQuartzDragSourceInfo
rather than relying on the NSWindow's latest event being the right one (or the
right kind).

12 years agoBug 657770 - Write to released memory in gtkdnd-quartz.c
Kristian Rietveld [Sun, 25 Sep 2011 00:32:21 +0000 (17:32 -0700)]
Bug 657770 - Write to released memory in gtkdnd-quartz.c

Clear the Drag paste board just before the info->context is released.
This way the GtkDragSourceOwner is released just before the drag context
is and thus can pasteboard:provideDataForType: not accidentally access
an already released drag context

12 years agoQuartz, Bug 655057: Eliminate Compiler Warning
Alex Corrado [Sun, 9 Oct 2011 16:52:14 +0000 (09:52 -0700)]
Quartz, Bug 655057: Eliminate Compiler Warning

When compiled with older SDKs, the original change for this bug caused a
compiler warning about NSWindow not being able to handle a setStyleMask
message. This tricks the compiler into thinking that it can.

12 years agoAdd G_GNUC_DEPRECATED annotations in GDK
Matthias Clasen [Sun, 9 Oct 2011 13:55:08 +0000 (09:55 -0400)]
Add G_GNUC_DEPRECATED annotations in GDK

12 years agoBug 658772: Directory paths for resource directories are hard coded.
John Ralls [Sun, 11 Sep 2011 23:45:06 +0000 (16:45 -0700)]
Bug 658772: Directory paths for resource directories are hard coded.

Provide dynamic path discovery functions as are provided for win32.

12 years agoquartz: also update window position on windowDidResize
Kristian Rietveld [Sat, 8 Oct 2011 09:47:11 +0000 (11:47 +0200)]
quartz: also update window position on windowDidResize

When a window goes fullscreen, the resize also changes its size.

12 years agoUpdated Dutch translation by Wouter Bolsterlee
Wouter Bolsterlee [Fri, 7 Oct 2011 22:40:12 +0000 (00:40 +0200)]
Updated Dutch translation by Wouter Bolsterlee

12 years agoUpdated Dutch translation by Rachid
Rachid [Fri, 7 Oct 2011 22:39:18 +0000 (00:39 +0200)]
Updated Dutch translation by Rachid

12 years agogtk: remove the private GTK_DEFAULT_ACCEL_MOD_MASK define
Michael Natterer [Fri, 7 Oct 2011 18:58:58 +0000 (20:58 +0200)]
gtk: remove the private GTK_DEFAULT_ACCEL_MOD_MASK define

and finish the port to using the new modifier abstraction API.
This commit has some evilness, it uses the default display for
the lack of a widget context, and the change to gtkstock.c
is very ugly, but I can't think of anything better given
GtkStockItem needs an accel mask instead of a proper accel
string.

12 years agogdk: fix gdk_keyval_to_lower/upper() for Quartz, Win32 and Broadway
Michael Natterer [Fri, 7 Oct 2011 14:10:19 +0000 (16:10 +0200)]
gdk: fix gdk_keyval_to_lower/upper() for Quartz, Win32 and Broadway

In 2.x, the !HAVE_XCONVERTCASE fallback of keyval_convert_case() was
implicitly used as implementation for all !X11 backends.

In 3.x, when this function was virtualized in GdkDisplayManager,
this fallback was moved to the X11 backend and the other backends
"equipped" with /* FIXME implement */ implementations of
keyval_convert_case() which don't convert anything.

Move the fallback code back to gdk/ as default implementation
of GdkDisplayManager::keyval_convert_case() and remove its
implementations is all backends but X11. Also remove the
implementation in Wayland which was a plain copy of what
is now the default implementation.
(cherry picked from commit f46c1b76d839a03bdc8080bc130fabd1068f2557)

12 years agogtk: use the new modifier API instead of GTK_DEFAULT_ACCEL_MOD_MASK
Michael Natterer [Fri, 7 Oct 2011 07:29:43 +0000 (09:29 +0200)]
gtk: use the new modifier API instead of GTK_DEFAULT_ACCEL_MOD_MASK

in gtkimcontextsimple and gtktreeview, which are the easy places,
but also true bugfixes, because on OSX we can't use the virtual META
here, we needs MOD2 as delivered in key events.

12 years agoUpdated Galician translations
Fran Dieguez [Thu, 6 Oct 2011 23:25:04 +0000 (01:25 +0200)]
Updated Galician translations

12 years agoGtkComboBox: Add the format-entry-text signal.
Tristan Van Berkom [Thu, 6 Oct 2011 09:14:38 +0000 (11:14 +0200)]
GtkComboBox: Add the format-entry-text signal.

This provides more control over how the selected item is shown in
the entry.
Bug #631167

12 years agoGtkTreeViewColumn: dispose: Remove from the treeview
Kjell Ahlstedt [Wed, 28 Sep 2011 11:02:20 +0000 (13:02 +0200)]
GtkTreeViewColumn: dispose: Remove from the treeview

This handles the case (with gtkmm) that the GtkTreeViewColumn is
destroyed before the GtkTreeView is destroyed.
Bug #659672

12 years agoBug 628936: Minimal change to pass introspection.
John Ralls [Sun, 21 Nov 2010 21:06:57 +0000 (13:06 -0800)]
Bug 628936: Minimal change to pass introspection.

gobject_introspection's G-ir-scanner doesn't like the -xobjective-c
option needed to compile ObjectiveC features in quartz implementations
of certain gtk functions. This rearranges the compiler flag environment
variables in Makefile so that G-ir-scanner doesn't see them.

12 years agoFixed gtk_cell_area_stop_editing() to properly notify when editing is not canceled
Tristan Van Berkom [Mon, 3 Oct 2011 23:32:00 +0000 (19:32 -0400)]
Fixed gtk_cell_area_stop_editing() to properly notify when editing is not canceled

This fixes bug 653289, in gtk+-2 gtk_tree_view_stop_editing() was previously
responsible for notifying with gtk_cell_editable_editing_done(), this detail
was missed when porting the cell renderer management to GtkCellArea.

12 years agoreftests: add a reftest for the CSS :only-child selector
Cosimo Cecchi [Tue, 4 Oct 2011 15:46:25 +0000 (11:46 -0400)]
reftests: add a reftest for the CSS :only-child selector

https://bugzilla.gnome.org/show_bug.cgi?id=660833

12 years agoall: add an 'only-child' pseudo-class selector
Cosimo Cecchi [Mon, 3 Oct 2011 21:09:09 +0000 (17:09 -0400)]
all: add an 'only-child' pseudo-class selector

Add an :only-child pseudo-class selector, which selects single children
of a parent container.

https://bugzilla.gnome.org/show_bug.cgi?id=660833

12 years agoappchooser: make the "Find applications online" follow search state
Cosimo Cecchi [Mon, 3 Oct 2011 15:50:53 +0000 (11:50 -0400)]
appchooser: make the "Find applications online" follow search state

Set the button as insensitive while searching, so that it can't be
accidentally clicked twice.

https://bugzilla.gnome.org/show_bug.cgi?id=651818

12 years agoappchooser: add a GCancellable to the search operation
Cosimo Cecchi [Mon, 3 Oct 2011 15:47:09 +0000 (11:47 -0400)]
appchooser: add a GCancellable to the search operation

So that we can cancel it when the dialog is destroyed.

https://bugzilla.gnome.org/show_bug.cgi?id=651818

12 years agoUpdated Spanish translation
Jorge González [Mon, 3 Oct 2011 21:21:40 +0000 (23:21 +0200)]
Updated Spanish translation

12 years agoFix commit 61d6c73f186a08cd55852c0a44a1704a6fbbbc39
Kristian Rietveld [Mon, 3 Oct 2011 20:57:12 +0000 (22:57 +0200)]
Fix commit 61d6c73f186a08cd55852c0a44a1704a6fbbbc39

Where the commit suggested "somebody should review it [the test]",
it would have been useful to test this particular commit instead...

12 years agoBug 659022 - gtk_tree_model_filter_clear_cache_helper: assertion failed
Kristian Rietveld [Mon, 3 Oct 2011 20:38:42 +0000 (22:38 +0200)]
Bug 659022 - gtk_tree_model_filter_clear_cache_helper: assertion failed

This bug is resolved by fixing two things in
gtk_tree_model_filter_row_deleted():

  (1) It is possible for an elt to have elt->visible_siter == NULL, when
  it is deleted.  Only call g_sequence_remove() if this pointer is
  non-NULL.

  (2) For the case len (level->seq) > 1, free the elt->children level
  if non-NULL.  Failing to do this means the level will stick around.
  If this child level was not referenced, it will still have a zero
  ref count on its parent which cannot be removed!

For both bugs unit tests have been added in the preceding commit.

12 years agoAdd two more unit tests for bug 659022
Kristian Rietveld [Mon, 3 Oct 2011 20:37:49 +0000 (22:37 +0200)]
Add two more unit tests for bug 659022

Both pointing out problems in gtk_tree_model_filter_row_deleted().

12 years agoFix first part of bug 659022
Kristian Rietveld [Mon, 3 Oct 2011 19:35:21 +0000 (21:35 +0200)]
Fix first part of bug 659022

Push creation of path into if clause, the path cannot be created anyway
(and would be meaningless otherwise) if the parent is not visible.

12 years agoAdd unit test for part 1 of bug 659022
Kristian Rietveld [Mon, 3 Oct 2011 19:33:30 +0000 (21:33 +0200)]
Add unit test for part 1 of bug 659022

This tests a case where gtk_tree_model_filter_row_changed() is run
for a node with visible_siter != NULL, however its parent has
visible_iter == NULL. For this case, no valid paths can be generated
as the node cannot be accessed (because the parent is invisible).

12 years agobox: add some missing includes
Cosimo Cecchi [Mon, 3 Oct 2011 20:54:09 +0000 (16:54 -0400)]
box: add some missing includes

12 years agoiconcache: Fix gcc warning
Benjamin Otte [Mon, 3 Oct 2011 16:03:57 +0000 (18:03 +0200)]
iconcache: Fix gcc warning

12 years agofilesystemmodel: Add a missing check
Benjamin Otte [Sun, 2 Oct 2011 03:27:41 +0000 (05:27 +0200)]
filesystemmodel: Add a missing check

Paths with depth > 1 should return FALSE instead of pretending the depth
is 1.

12 years agoBug 660730: Use GStatBuf for portability
Chun-wei Fan [Mon, 3 Oct 2011 15:25:33 +0000 (23:25 +0800)]
Bug 660730: Use GStatBuf for portability

Thanks to Kean Johnston for pointing this out.

There are a few places in GTK that use "struct stat",
and then g_stat(), rather than using GStatBuf.This breaks things on
Windows. Since the size of struct stat can vary depending on other
flags specified, this has the potential to cause overwrites and is
trivial to fix.

Based on patch submitted by Kean Johnston

12 years agogdk: Plug leak in gdk_display_pointer_is_grabbed
Adel Gadllah [Sun, 2 Oct 2011 07:52:16 +0000 (09:52 +0200)]
gdk: Plug leak in gdk_display_pointer_is_grabbed

gdk_x11_device_manager_core_list_devices returns a new allocated
list, which has to be freed.

valgrind output:

==18686== 160,176 (80,088 direct, 80,088 indirect) bytes in 3,337 blocks are definitely lost in loss record 25,347 of 25,378
==18686==    at 0x4C256DD: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==18686==    by 0x6CD7752: g_malloc (in /lib64/libglib-2.0.so.0.3000.0)
==18686==    by 0x6CEE2B6: g_slice_alloc (in /lib64/libglib-2.0.so.0.3000.0)
==18686==    by 0x6CCB37D: g_list_prepend (in /lib64/libglib-2.0.so.0.3000.0)
==18686==    by 0x654CADA: gdk_x11_device_manager_core_list_devices (gdkdevicemanager-core-x11.c:836)
==18686==    by 0x6531489: gdk_display_pointer_is_grabbed (gdkdisplay.c:1270)
==18686==    by 0x5162E1E: filter_func (ui.c:140)
==18686==    by 0x6558B50: gdk_event_apply_filters (gdkeventsource.c:83)
==18686==    by 0x6558CB3: _gdk_x11_display_queue_events (gdkeventsource.c:197)
==18686==    by 0x6530680: gdk_display_get_event (gdkdisplay.c:311)
==18686==    by 0x65589F1: gdk_event_source_dispatch (gdkeventsource.c:356)
==18686==    by 0x6CD0A0E: g_main_context_dispatch (in /lib64/libglib-2.0.so.0.3000.0)

https://bugzilla.gnome.org/show_bug.cgi?id=660676

12 years agoUpdated Esperanto translation
Tiffany Antopolski [Mon, 3 Oct 2011 10:48:57 +0000 (12:48 +0200)]
Updated Esperanto translation

12 years ago__SIZEOF_INT__ and __SIZEOF_POINTER__ may not be defined.
Antoine Jacoutot [Mon, 3 Oct 2011 07:11:50 +0000 (09:11 +0200)]
__SIZEOF_INT__ and __SIZEOF_POINTER__ may not be defined.

Protect __SIZEOF_INT__ and __SIZEOF_POINTER__ with an ifdef to prevent
warnings about them not being defined when including gtktextattributes.h.

https://bugzilla.gnome.org/show_bug.cgi?id=660619

12 years agogtkbox: Move private functions to private header
Javier Jardón [Sun, 2 Oct 2011 20:21:49 +0000 (21:21 +0100)]
gtkbox: Move private functions to private header

12 years agoAdd 'Since 3.4' indices to the docs
Matthias Clasen [Sun, 2 Oct 2011 14:20:48 +0000 (10:20 -0400)]
Add 'Since 3.4' indices to the docs

12 years agoAdd new api to gdk.symbols
Matthias Clasen [Sun, 2 Oct 2011 14:19:15 +0000 (10:19 -0400)]
Add new api to gdk.symbols

This keeps 'make check' happy.
And if 'make check' is happy, so am I.

12 years agogdkcreen-x11: Use GdkRGBA instead GdkColor
Javier Jardón [Mon, 13 Jun 2011 00:54:02 +0000 (01:54 +0100)]
gdkcreen-x11: Use GdkRGBA instead GdkColor

12 years agoUpdated Vietnamese translation
Nguyễn Thái Ngọc Duy [Sat, 1 Oct 2011 10:10:12 +0000 (20:10 +1000)]
Updated Vietnamese translation

12 years agopo/vi: import from Damned Lies
Nguyễn Thái Ngọc Duy [Sat, 1 Oct 2011 09:55:34 +0000 (19:55 +1000)]
po/vi: import from Damned Lies

12 years agouimanager: Deprecate add-tearoffs property
Benjamin Otte [Sat, 1 Oct 2011 03:58:27 +0000 (05:58 +0200)]
uimanager: Deprecate add-tearoffs property

Don't use it. Please.

12 years agomenu: Deprecate GtkTearoffMenuItem
Benjamin Otte [Sat, 1 Oct 2011 03:49:48 +0000 (05:49 +0200)]
menu: Deprecate GtkTearoffMenuItem

12 years agotestgtk: Remove tearoff menus from tests
Benjamin Otte [Sat, 1 Oct 2011 03:49:30 +0000 (05:49 +0200)]
testgtk: Remove tearoff menus from tests

12 years agogtk-demo: Don't use tearoff menus
Benjamin Otte [Sat, 1 Oct 2011 03:49:00 +0000 (05:49 +0200)]
gtk-demo: Don't use tearoff menus

Demoing bad things, sheesh.

12 years agogtkwindow: Clean up gtk_window_map()
Rui Matos [Sat, 1 Oct 2011 00:18:52 +0000 (01:18 +0100)]
gtkwindow: Clean up gtk_window_map()

Remove unneeded variable and delete trailing whitespace.

12 years agodocs: Delete duplicate line in gdkwindow.c
Rui Matos [Sat, 1 Oct 2011 00:15:45 +0000 (01:15 +0100)]
docs: Delete duplicate line in gdkwindow.c

12 years agohandlebox: Deprecate
Benjamin Otte [Fri, 30 Sep 2011 20:31:56 +0000 (22:31 +0200)]
handlebox: Deprecate

12 years agotestgtk: Remove handlebox example
Benjamin Otte [Fri, 30 Sep 2011 20:10:18 +0000 (22:10 +0200)]
testgtk: Remove handlebox example

Rather than keeping it and enabling deprecated code in testgtk I decided
to delete the example. The warnings from testgtk about deprecated code
are too useful IMO.
Should we need it again, we can make it into its own test, or add a
testgtkdeprecated.

12 years agotests: Remove handleboxes from testmerge example
Benjamin Otte [Fri, 30 Sep 2011 20:10:04 +0000 (22:10 +0200)]
tests: Remove handleboxes from testmerge example

12 years agoa11y: Don't include gtkx when not needed
Benjamin Otte [Fri, 30 Sep 2011 19:40:39 +0000 (21:40 +0200)]
a11y: Don't include gtkx when not needed

12 years agoa11y: Remove useless check
Benjamin Otte [Fri, 30 Sep 2011 19:39:08 +0000 (21:39 +0200)]
a11y: Remove useless check

12 years agoUpdated Hebrew translation.
Yaron Shahrabani [Fri, 30 Sep 2011 10:27:54 +0000 (13:27 +0300)]
Updated Hebrew translation.

12 years agotests: Fix a bunch of set-but-unused warnings in the filtermodel test
Benjamin Otte [Thu, 29 Sep 2011 10:31:43 +0000 (12:31 +0200)]
tests: Fix a bunch of set-but-unused warnings in the filtermodel test

The whole test doesn't seem to unref any memoery, somebody should review
it.

12 years agodocs: Fix typo in treeview docs
Benjamin Otte [Thu, 29 Sep 2011 04:30:20 +0000 (06:30 +0200)]
docs: Fix typo in treeview docs

12 years agogtktable: Fix gtk-doc notation
Javier Jardón [Thu, 29 Sep 2011 11:42:38 +0000 (12:42 +0100)]
gtktable: Fix gtk-doc notation

12 years agoReplace some references to the GtkTable, use GtkGrid instead
Javier Jardón [Thu, 29 Sep 2011 11:36:39 +0000 (12:36 +0100)]
Replace some references to the GtkTable, use GtkGrid instead

12 years agonotebook: don't forget to prepare the tab style context before drawing
Cosimo Cecchi [Thu, 29 Sep 2011 05:49:55 +0000 (01:49 -0400)]
notebook: don't forget to prepare the tab style context before drawing

The previous commit a9affcdd3f9c888c5e68dc76b0c5173d918bc725
accidentally removed the call to notebook_tab_prepare_style_context()

12 years agonotebook: Remove unused variables
Benjamin Otte [Thu, 29 Sep 2011 02:23:16 +0000 (04:23 +0200)]
notebook: Remove unused variables

12 years agocombobox: Remove unused define
Benjamin Otte [Mon, 26 Sep 2011 20:51:55 +0000 (22:51 +0200)]
combobox: Remove unused define

12 years agoGtkTreeViewColumn: initialize a variable
Cosimo Cecchi [Wed, 28 Sep 2011 22:27:35 +0000 (18:27 -0400)]
GtkTreeViewColumn: initialize a variable

Shut up valgrind complaining about uninitialized values

==5330== Conditional jump or move depends on uninitialised value(s)
==5330==    at 0x624FF4C: gdk_window_move_resize_internal
(gdkwindow.c:6037)
==5330==    by 0x62502C3: gdk_window_move_resize (gdkwindow.c:6274)
==5330==    by 0x5E4FBB5: _gtk_tree_view_column_allocate
(gtktreeviewcolumn.c:2169)
==5330==    by 0x5E3846B: gtk_tree_view_size_allocate_columns
(gtktreeview.c:2631)
==5330==    by 0x5E43D76: gtk_tree_view_size_allocate
(gtktreeview.c:2686)
==5330==    by 0x7F03959: g_closure_invoke (gclosure.c:774)
==5330==    by 0x7F16446: signal_emit_unlocked_R (gsignal.c:3202)
==5330==    by 0x7F20256: g_signal_emit_valist (gsignal.c:3003)
==5330==    by 0x7F20421: g_signal_emit (gsignal.c:3060)
==5330==    by 0x5E6DFBE: gtk_widget_size_allocate (gtkwidget.c:4886)
==5330==    by 0x5D94ADD: gtk_scrolled_window_allocate_child
(gtkscrolledwindow.c:1506)
==5330==    by 0x5D95299: gtk_scrolled_window_size_allocate
(gtkscrolledwindow.c:1704)
==5330==    by 0x7F03959: g_closure_invoke (gclosure.c:774)
==5330==    by 0x7F16446: signal_emit_unlocked_R (gsignal.c:3202)
==5330==    by 0x7F20256: g_signal_emit_valist (gsignal.c:3003)
==5330==    by 0x7F20421: g_signal_emit (gsignal.c:3060)
==5330==    by 0x5E6DFBE: gtk_widget_size_allocate (gtkwidget.c:4886)
==5330==    by 0x5C62708: gtk_box_size_allocate (gtkbox.c:658)
==5330==    by 0x7F03959: g_closure_invoke (gclosure.c:774)
==5330==    by 0x7F16446: signal_emit_unlocked_R (gsignal.c:3202)
==5330==  Uninitialised value was created by a stack allocation
==5330==    at 0x5E4FA8D: _gtk_tree_view_column_allocate
(gtktreeviewcolumn.c:2139)

12 years agoGdkWindow: fix conditional jump depends on uninitialized value error
Cosimo Cecchi [Wed, 28 Sep 2011 22:16:30 +0000 (18:16 -0400)]
GdkWindow: fix conditional jump depends on uninitialized value error

Those if() blocks don't have any reason being there, as x and y are not
pointers. If the window is destroyed, just set the out values to zero
and return.

As seen in valgrind:

==3306== Conditional jump or move depends on uninitialised value(s)
==3306==    at 0x624C74F: gdk_window_get_root_coords (gdkwindow.c:6933)
==3306==    by 0x5E193C3: gtk_tooltip_show_tooltip (gtktooltip.c:1160)
==3306==    by 0x5E19C05: tooltip_popup_timeout (gtktooltip.c:1282)
==3306==    by 0x623B102: gdk_threads_dispatch (gdk.c:754)
==3306==    by 0x8592F3A: g_timeout_dispatch (gmain.c:3907)
==3306==    by 0x859174C: g_main_context_dispatch (gmain.c:2441)
==3306==    by 0x8591F47: g_main_context_iterate (gmain.c:3089)
==3306==    by 0x8592494: g_main_loop_run (gmain.c:3297)
==3306==    by 0x5D2E501: gtk_main (gtkmain.c:1362)
==3306==    by 0x5C5652F: gtk_application_run_mainloop
(gtkapplication.c:115)
==3306==    by 0x7C47C9D: g_application_run (gapplication.c:1323)
==3306==    by 0x447B5F: main (nautilus-main.c:102)
==3306==  Uninitialised value was created by a stack allocation
==3306==    at 0x624D48A: gdk_window_get_device_position
(gdkwindow.c:4952)

12 years agotable: Deprecate GtkTable for GtkGrid
Benjamin Otte [Wed, 28 Sep 2011 23:30:16 +0000 (01:30 +0200)]
table: Deprecate GtkTable for GtkGrid

12 years agodocs: Make infobar code example use GtkGrid instead of GtkTable
Benjamin Otte [Wed, 28 Sep 2011 23:06:21 +0000 (01:06 +0200)]
docs: Make infobar code example use GtkGrid instead of GtkTable

12 years agotesttoolbar: Fix test to use GtkGrid
Benjamin Otte [Wed, 28 Sep 2011 23:03:44 +0000 (01:03 +0200)]
testtoolbar: Fix test to use GtkGrid

The conversion in commit 7724f14dfa7545cfb9f7a13cd0f2aa6a41018157 was
incomplete. Redo it.

12 years agotestgtk: Convert panes example from GtkTable to GtkGrid
Benjamin Otte [Wed, 28 Sep 2011 22:41:35 +0000 (00:41 +0200)]
testgtk: Convert panes example from GtkTable to GtkGrid

12 years agotestgtk: Convert size groups example from GtkTable to GtkGrid
Benjamin Otte [Wed, 28 Sep 2011 22:35:35 +0000 (00:35 +0200)]
testgtk: Convert size groups example from GtkTable to GtkGrid

12 years agotestgtk: Switch progress bar example from GtkTable to GtkGrid
Benjamin Otte [Wed, 28 Sep 2011 17:40:11 +0000 (19:40 +0200)]
testgtk: Switch progress bar example from GtkTable to GtkGrid

12 years agotestgtk: Clean up code
Benjamin Otte [Wed, 28 Sep 2011 17:21:58 +0000 (19:21 +0200)]
testgtk: Clean up code

Remove unused hboxes.

12 years agoquartz: don't filter away directly encoded 24-bit UCS characters
Michael Natterer [Wed, 28 Sep 2011 11:48:52 +0000 (13:48 +0200)]
quartz: don't filter away directly encoded 24-bit UCS characters

gdk_unicode_to_keyval(uc) returning (uc | 0x01000000) is not an
error return value but simply the way to encode 24-bit unicode
characters directly as keyvals.

12 years agotestgtk: Move paned example from GtkTable to GtkGrid
Benjamin Otte [Wed, 28 Sep 2011 03:21:29 +0000 (05:21 +0200)]
testgtk: Move paned example from GtkTable to GtkGrid

12 years agotestgtk: Move display example from GtkTable to GtkGrid
Benjamin Otte [Wed, 28 Sep 2011 03:13:00 +0000 (05:13 +0200)]
testgtk: Move display example from GtkTable to GtkGrid

12 years agotestgtk: Remove invalid property
Benjamin Otte [Wed, 28 Sep 2011 03:08:19 +0000 (05:08 +0200)]
testgtk: Remove invalid property

12 years agotestgtk: Convert focus example from GtkTable to GtkGrid
Benjamin Otte [Wed, 28 Sep 2011 03:03:20 +0000 (05:03 +0200)]
testgtk: Convert focus example from GtkTable to GtkGrid

12 years agotestgtk: Simplify code
Benjamin Otte [Wed, 28 Sep 2011 02:42:54 +0000 (04:42 +0200)]
testgtk: Simplify code

Use a for loop for iterating.

12 years agotestgtk: Switch scrolled windows example from GtkTable to GtkGrid
Benjamin Otte [Wed, 28 Sep 2011 01:33:47 +0000 (03:33 +0200)]
testgtk: Switch scrolled windows example from GtkTable to GtkGrid

12 years agotestgtk: Convert radio/check button examples from GtkTable to GtkGrid
Benjamin Otte [Wed, 28 Sep 2011 01:25:47 +0000 (03:25 +0200)]
testgtk: Convert radio/check button examples from GtkTable to GtkGrid

12 years agoprint: Convert custom paper dialog from GtkTable to GtkGrid
Benjamin Otte [Wed, 28 Sep 2011 01:02:19 +0000 (03:02 +0200)]
print: Convert custom paper dialog from GtkTable to GtkGrid

12 years agotestgtk: Convert buttons example from GtkTable to GtkGrid
Benjamin Otte [Wed, 28 Sep 2011 00:52:07 +0000 (02:52 +0200)]
testgtk: Convert buttons example from GtkTable to GtkGrid

12 years agotestgtk: Beautify buttons example
Benjamin Otte [Wed, 28 Sep 2011 00:45:43 +0000 (02:45 +0200)]
testgtk: Beautify buttons example

12 years agotestgtk: Convert big windows example from GtkTable to GtkGrid
Benjamin Otte [Wed, 28 Sep 2011 00:28:39 +0000 (02:28 +0200)]
testgtk: Convert big windows example from GtkTable to GtkGrid

12 years agotestgtk: Upgrade alpha windows test from GtkTable to GtkGrid
Benjamin Otte [Wed, 28 Sep 2011 00:25:07 +0000 (02:25 +0200)]
testgtk: Upgrade alpha windows test from GtkTable to GtkGrid

Also fix some extra code.

12 years agotests: Convert testframe from GtkTable to GtkGrid
Benjamin Otte [Wed, 28 Sep 2011 00:12:05 +0000 (02:12 +0200)]
tests: Convert testframe from GtkTable to GtkGrid

12 years agotests: Convert testgeometry from GtkTable to GtkGrid
Benjamin Otte [Tue, 27 Sep 2011 23:47:32 +0000 (01:47 +0200)]
tests: Convert testgeometry from GtkTable to GtkGrid

12 years agotests: Convert testexpand from GtkTable to GtkGrid
Benjamin Otte [Tue, 27 Sep 2011 20:40:32 +0000 (22:40 +0200)]
tests: Convert testexpand from GtkTable to GtkGrid

12 years agotests: Convert testentryicons example from GtkTable to GtkGrid
Benjamin Otte [Tue, 27 Sep 2011 20:35:49 +0000 (22:35 +0200)]
tests: Convert testentryicons example from GtkTable to GtkGrid

12 years agotests: Convert testdnd from GtkTable to GtkGrid
Benjamin Otte [Tue, 27 Sep 2011 20:23:26 +0000 (22:23 +0200)]
tests: Convert testdnd from GtkTable to GtkGrid

12 years agotests: Convert testadjustsize example from GtkTable to box and grid
Benjamin Otte [Tue, 27 Sep 2011 20:02:00 +0000 (22:02 +0200)]
tests: Convert testadjustsize example from GtkTable to box and grid