Bug 528320 - Incorrect icons displayed for files with custom mimetype
2008-10-23 Alexander Larsson <alexl@redhat.com>
Bug 528320 - Incorrect icons displayed for files with custom mimetype icons
* gtk/gtkfilesystem.c:
(_gtk_file_info_render_icon):
Fall back on default file icon if there was no icon or it
was not found in the theme. This goes with the corresponding
change in glib to not add the fallback icon, but is useful
in other cases too.
Michael Natterer [Tue, 21 Oct 2008 21:42:39 +0000 (21:42 +0000)]
gdk/gdkdraw.c gdk/gdkimage.c gdk/gdkscreen.c replace assertions for obj !=
2008-10-21 Michael Natterer <mitch@imendio.com>
* gdk/gdkdraw.c
* gdk/gdkimage.c
* gdk/gdkscreen.c
* gdk/gdkwindow.c: replace assertions for obj != NULL by
GDK_IS_OBJ(), remove redundant != NULL checks when there is
already a type check, add some g_return_if_fail() that were
missing entirely, fix some broken indentation and spacing.
Tor Lillqvist [Tue, 21 Oct 2008 20:31:05 +0000 (20:31 +0000)]
Bug 557266 - Window Management Problem
2008-10-21 Tor Lillqvist <tml@novell.com>
Bug 557266 - Window Management Problem
Also reported in mail to gtk-list, and of course it has been well
known in general that window state management is messy and buggy
in various ways in gdk/win32.
* gdk/win32/gdkwindow-win32.c (show_window_internal): Correct
handling of GDK_WINDOW_STATE_ABOVE windows. It doesn't work to set
the WS_EX_TOPMOST extended style bit using SetWindowLong(). We
must call SetWindowPos() on the window using HWND_TOPMOST
instead. The description for WS_EX_TOPMOST in the documentation
for CreateWindowEx() even implies that if you read it carefully.
Michael Natterer [Tue, 21 Oct 2008 20:20:50 +0000 (20:20 +0000)]
reorder functions to be in standard order, add prototypes and namespace to
2008-10-21 Michael Natterer <mitch@imendio.com>
* gdk/gdkapplaunchcontext.c: reorder functions to be in standard
order, add prototypes and namespace to static functions, add
g_return_if_fail()s which were missing all over the place.
Christian Persch [Mon, 20 Oct 2008 16:55:00 +0000 (16:55 +0000)]
Bug 557059 – crash when compositing emblems with icon
2008-10-20 Christian Persch <chpe@gnome.org>
Bug 557059 – crash when compositing emblems with icon
* gtk/gtkicontheme.c: (apply_emblems): Copy the pixbuf before using it
with gtk_pixbuf_composite, in case its pixdata is read-only (mmaped
from icon cache or builtins).
Tor Lillqvist [Fri, 17 Oct 2008 22:56:33 +0000 (22:56 +0000)]
On WM_WINDOWPOSCHANGING, don't dereference windowpos in the debugging
2008-10-18 Tor Lillqvist <tml@novell.com>
* gdk/win32/gdkevents-win32.c (gdk_event_translate): On
WM_WINDOWPOSCHANGING, don't dereference windowpos in the debugging
output without setting it first.
2008-10-18 Tor Lillqvist <tml@novell.com>
Bug 556578 - GIMP windows stay on top of other windows
* gdk/win32/gdkevents-win32.c (ensure_stacking_on_unminimize)
(ensure_stacking_on_window_pos_changing)
(ensure_stacking_on_activate_app): Ignore unmapped windows in the
loops where we look for the lowest "transient-type" window.
(gdk_event_translate): Don't call
ensure_stacking_on_window_pos_changing() or
ensure_stacking_on_activate_app() for unmapped windows.
Matthias Clasen [Tue, 14 Oct 2008 03:47:18 +0000 (03:47 +0000)]
Bug 555779 – GtkCellRendererPixbuf crashed on failed GIcon lookup
2008-10-13 Matthias Clasen <mclasen@redhat.com>
Bug 555779 – GtkCellRendererPixbuf crashed on failed GIcon lookup
* gtk/gtkcellrendererpixbuf
(gtk_cell_renderer_pixbuf_create_themed_pixbuf): Don't crash
if a GIcon is not present in the current theme. Patch by
Alex Larsson.
Matthias Clasen [Tue, 14 Oct 2008 02:00:11 +0000 (02:00 +0000)]
Bug 552318 – menubar mnemonics consumed even when
2008-10-13 Matthias Clasen <mclasen@redhat.com>
Bug 552318 – menubar mnemonics consumed even when
gtk-enable-mnemonics=false
* gtk/gtkwindow.c (gtk_window_activate_key): Don't let mnemonic
entries block accelerator activation when gtk-enable-mnemonics is
FALSE. Problem reported by Andreas Moog.
Matthias Clasen [Sun, 12 Oct 2008 15:27:57 +0000 (15:27 +0000)]
Revert the GtkSettings::gtk-toolbar-icon-size part of the previous change,
2008-10-11 Matthias Clasen <mclasen@redhat.com>
* gtk/gtktoolbar.c: Revert the GtkSettings::gtk-toolbar-icon-size
part of the previous change, since it doesn't work correctly without
extra complication, and using custom icon sizes doesn't make too
much sense in a desktop-wide setting.
Matthias Clasen [Sun, 12 Oct 2008 03:17:16 +0000 (03:17 +0000)]
Bug 555186 – Setting gtk-toolbar-icon-size with custom icon_size
2008-10-11 Matthias Clasen <mclasen@redhat.com>
Bug 555186 – Setting gtk-toolbar-icon-size with custom icon_size
* gtk/gtktoolbar.c: Turn GtkToolbar::icon-size and
GtkSettings::gtk-toolbar-icon-size into int properties, to
allow the use of app-registered icon sizes.
Christian Dywan [Thu, 9 Oct 2008 15:57:55 +0000 (15:57 +0000)]
Bug 555578 – GtkTable propertiy maxima are wrong
* gtk/gtktable.c (gtk_table_class_init), (gtk_table_resize):
Always use 65535 instead of G_MAXUINT since that is
the actually supported maximum number of columns and rows
Bug 516425 – Optionally display accelerators in popups
2008-10-09 Michael Natterer <mitch@imendio.com>
Bug 516425 – Optionally display accelerators in popups
* gtk/gtkuimanager.h (enum GtkUIManagerItemType): add value
GTK_UI_MANAGER_POPUP_WITH_ACCELS which works like _POPUP but
shows the actions' accelerators.
* gtk/gtkuimanager.c: honor the new enum value for programmatically
created UIs, and support <popup accelerators="true"> in the XML
for the same purpose.
Matthias Clasen [Wed, 8 Oct 2008 15:32:23 +0000 (15:32 +0000)]
Don't forget to reset reload_state when current_folder is already correct.
2008-10-08 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkfilechooserdefault.c (update_current_folder_get_info_cb):
Don't forget to reset reload_state when current_folder is already
correct. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=465992
Christian Dywan [Wed, 8 Oct 2008 02:27:07 +0000 (02:27 +0000)]
Bug 555270 – Allow unsetting a MessageDialog's image
2008-10-08 Christian Dywan <christian@imendio.com>
Bug 555270 – Allow unsetting a MessageDialog's image
* gtk/gtkmessagedialog.c (gtk_message_dialog_set_property),
Remove a superfluous cast to GtkWidget*
(gtk_message_dialog_set_image): Accept NULL for the image
and unset the image in that case.
Christian Dywan [Wed, 8 Oct 2008 02:16:08 +0000 (02:16 +0000)]
Bug 436533 – Allow more space efficient scroll arrows placement
* gtk/gtkenums.h: Add GtkArrowPlacement
* gtk/gtkmenu.c (gtk_menu_class_init), (get_arrows_border),
(get_arrows_visible_area), (get_double_arrows),
(get_arrows_sensitive_area): Implement GtkMenu::arrow-placement
to allow scrolling arrows to be placed at the start, end or both
Patch by Tommi Komulainen and myself
keep GtkBox as an abstract type and keep _gtk_box_new() as private
2008-10-07 11:03:30 Tim Janik <timj@imendio.com>
* gtk/gtkbox.h: keep GtkBox as an abstract type and keep _gtk_box_new()
as private function until we settle on the exact semantics.
renamed _gtk_box_set_old_defaults() as suggested by Mitch.
* gtk/gtkbox.[hh]: implement the GtkOrientable interface and
swallow all code from GtkHBox and GtkVBox. Add gtk_box_new()
which takes a GtkOrientation argument. Also move the newly
added "spacing_set" boolean from struct GtkBox to the new
private struct.
* gtk/gtkhbox.[ch]
* gtk/gtkvbox.[ch]: remove all code except the constructor and
call gtk_orientable_set_orientation() in init().
Tor Lillqvist [Sun, 5 Oct 2008 00:00:10 +0000 (00:00 +0000)]
Bug 132501 - Make utility window translate to tool window in win32
2008-10-04 Tor Lillqvist <tml@novell.com>
Bug 132501 - Make utility window translate to tool window in win32
Implement the utility window type hint. Such windows are kept on
top of other windows. Makes GIMP's toolbox and dock windows behave
more like in GNOME under metacity. Apply the same logic also to
windows marked with the dialog window type hint, and windows that
are transient for some other window. I'll call such windows
"transient-type" below.
* gdk/win32/gdkevents-win32.c (doesnt_want_key): Drop unused
variables.
(ensure_stacking_on_unminimize)
(ensure_stacking_on_window_pos_changing)
(ensure_stacking_on_activate_app): New functions to implement the
desired stacking order. Make sure that a window that is not
transient-type stays below any transient-type windows of the
application. When activating a non-transient-type window make sure
it rises as high as possible.
(gdk_event_translate): Call above functions on
WM_WINDOWPOSCHANGING, WM_ACTIVATEAPP and on WM_SIZE when
unminimizing. Improve debugging printout.
* gdk/win32/gdkwindow-win32.c (get_effective_window_decorations):
Handle utility windows like toolbar windows.
(gdk_window_new_internal) (update_style_bits): Give utility
windows the WS_EX_TOOLWINDOW extended style.
(gdk_window_set_title): If debugging "misc" or "events", make the
handle of top-level windows show up in their title bars. Very
useful when looking at debugging output.
(gdk_window_set_keep_above) (gdk_window_set_keep_below)
(gdk_window_set_modal_hint) (gdk_window_set_skip_taskbar_hint)
(gdk_window_set_skip_pager_hint): Add and improve debugging
printout.
(gdk_window_set_type_hint): Print hint symbolically in GDK_NOTE().
2008-10-04 Tor Lillqvist <tml@novell.com>
* gdk/win32/gdkmain-win32.c (_gdk_win32_window_exstyle_to_string)
(_gdk_win32_window_pos_bits_to_string): New debugging printout
functions. Decode the WS_EX_* and SWP_* bits.
* gdk/win32/gdkprivate-win32.h: Declare them. Define
GDK_DEBUG_MISC_OR_EVENTS for use in GDK_NOTE() to match either
"misc" or "events".
Matthias Clasen [Fri, 3 Oct 2008 01:16:48 +0000 (01:16 +0000)]
Bug 530575 – GtkEntry with invisible chars has a confused cursor in
2008-10-02 Matthias Clasen <mclasen@redhat.com>
Bug 530575 – GtkEntry with invisible chars has a confused cursor in
overwrite mode
* gtk/gtkentry.c (gtk_entry_draw_cursor): Use the visible text
in the layout when positioning the cursor, not the actual text
content of the entry. This makes a different when using overwrite
mode in an invisible entry.
Problem noticed by Jonathan Blandford
* gtk/gtkruler.[ch]: implement the GtkOrientable interface and
swallow all code from GtkHRuler and GtkVRuler. Add gtk_ruler_new()
which takes a GtkOrientation argument.
* gtk/gtkhruler.c
* gtk/gtkvruler.c: remove all code except the constructor and
call gtk_orientable_set_orientation() in init().
Tor Lillqvist [Wed, 1 Oct 2008 11:02:22 +0000 (11:02 +0000)]
Implement trivially on Windows. Not sure if something more complex is
2008-10-01 Tor Lillqvist <tml@novell.com>
* gdk/win32/gdkkeys-win32.c (gdk_keymap_get_caps_lock_state):
Implement trivially on Windows. Not sure if something more complex
is actually needed, more specifically whether the function needs
to differentiate between "Caps Lock" and "Shift Lock" semantics?
Michael Natterer [Tue, 30 Sep 2008 14:20:30 +0000 (14:20 +0000)]
Bug 553582 – Add orientation API to GtkSeparator
2008-09-30 Michael Natterer <mitch@imendio.com>
Bug 553582 – Add orientation API to GtkSeparator
* gtk/gtkseparator.[ch]: implement the GtkOrientable interface and
swallow all code from GtkHSeparator and GtkVSeparator. Add
gtk_separator_new() which takes a GtkOrientation argument.
* gtk/gtkhseparator.c
* gtk/gtkvseparator.c: remove all code except the constructor and
call gtk_orientable_set_orientation() in init().
Marek Kasik [Tue, 30 Sep 2008 08:45:01 +0000 (08:45 +0000)]
Bug 344522 – support non-local destination files (GtkPrint):
2008-09-30 Marek Kasik <mkasik@redhat.com>
Bug 344522 – support non-local destination files (GtkPrint):
* gtk/gtkprintunixdialog.c
* gtk/gtkprinteroptionwidget.c: Process URI instead of filename.
* modules/printbackends/file/gtkprintbackendfile.c: Add ability
to save files on non-local filesystems.
Michael Natterer [Tue, 30 Sep 2008 08:14:11 +0000 (08:14 +0000)]
Bug 541009 – Get rid of separate subclasses for horizontal and vertical
2008-09-30 Michael Natterer <mitch@imendio.com>
Bug 541009 – Get rid of separate subclasses for horizontal and
vertical orientation:
* gtk/Makefile.am
* gtk/gtk.symbols
* gtk/gtk.h
* gtk/gtkorientable.[ch]: add new interface GtkOrientable which
will be implemented by everything that can switch orientation.
* gtk/gtkimmulticontext.c (gtk_im_multicontext_append_menuitems):
Display the actually selected context in the system menuitem.
Complaint by Akira Tagoh.
Bug 530568 – Entries with visibility=FALSE should warn for caps-lock on
2008-09-29 Matthias Clasen <mclasen@redhat.com>
Bug 530568 – Entries with visibility=FALSE should warn for caps-lock
on
* gtk/gtkentry.c: Add a tooltip-like Caps Lock warning for
password entries. The warning is also triggered if an input method
is active. The warning can be turned off using the
GtkEntry::caps-lock-warning property.
Proposed by Owen Taylor
Bug 487624 - Tooltips doesn't get updated if ther's no mouse motion over
2008-09-29 Kristian Rietveld <kris@imendio.com>
Bug 487624 - Tooltips doesn't get updated if ther's no mouse motion
over widget
* gtk/gtkwidget.c (gtk_widget_set_property): after updating
tooltip text or markup, call gtk_widget_trigger_tooltip_query()
so that existing visible tooltips are updated.
projects / ~andy / gtk / log