]> Pileus Git - ~andy/linux/commitdiff
cxgb4: Do not set net_device::dev_id to VI index
authorBen Hutchings <bhutchings@solarflare.com>
Mon, 10 Jun 2013 16:34:13 +0000 (17:34 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Jun 2013 08:24:17 +0000 (01:24 -0700)
net_device::dev_id should not be used merely to indicate a VI index,
as it affects the way the local part of IPv6 addresses is normally
generated.

This field was intended for use where multiple devices may share a
single assigned MAC address and need to have different IPv6 addresses.
T4 VIs each have their own MAC address.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Acked-by: Dimitris Michailidis <dm@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c

index bff89a437b760c9d8f2630531e67bbd577629a79..4cbb2f9850be554c9ec48afd7479b4fcd9e5ebc2 100644 (file)
@@ -3782,7 +3782,6 @@ int t4_port_init(struct adapter *adap, int mbox, int pf, int vf)
                p->lport = j;
                p->rss_size = rss_size;
                memcpy(adap->port[i]->dev_addr, addr, ETH_ALEN);
-               adap->port[i]->dev_id = j;
 
                ret = ntohl(c.u.info.lstatus_to_modtype);
                p->mdio_addr = (ret & FW_PORT_CMD_MDIOCAP) ?