From 3c2b901003b4c152e19e6578c1705ce2c90edd4a Mon Sep 17 00:00:00 2001 From: Dmitry Torokhov Date: Mon, 1 Apr 2013 01:09:15 -0700 Subject: [PATCH] Input: ims-pcu - fix a memory leak on error Reported-by: Dan Carpenter Signed-off-by: Dmitry Torokhov --- drivers/input/misc/ims-pcu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c index 1b044b99da6..e204f26b001 100644 --- a/drivers/input/misc/ims-pcu.c +++ b/drivers/input/misc/ims-pcu.c @@ -292,7 +292,8 @@ static int ims_pcu_setup_gamepad(struct ims_pcu *pcu) if (!gamepad || !input) { dev_err(pcu->dev, "Not enough memory for gamepad device\n"); - return -ENOMEM; + error = -ENOMEM; + goto err_free_mem; } gamepad->input = input; @@ -1156,7 +1157,7 @@ static ssize_t ims_pcu_update_firmware_store(struct device *dev, { struct usb_interface *intf = to_usb_interface(dev); struct ims_pcu *pcu = usb_get_intfdata(intf); - const struct firmware *fw; + const struct firmware *fw = NULL; int value; int error; -- 2.43.2