]> Pileus Git - ~andy/linux/commit
bio-integrity: Drop bio_integrity_verify BUG_ON in post bip->bip_iter world
authorNicholas Bellinger <nab@linux-iscsi.org>
Thu, 20 Feb 2014 00:52:01 +0000 (00:52 +0000)
committerJens Axboe <axboe@fb.com>
Fri, 21 Feb 2014 23:56:36 +0000 (15:56 -0800)
commiteec70897d81bb2913e22c6792ea2739faf59c3e1
tree4ec843f5e4eb7ccd641870ac92bc6bac867e7b70
parentd6a25b31315327eef7785b895c354cc45c3f3742
bio-integrity: Drop bio_integrity_verify BUG_ON in post bip->bip_iter world

Given that bip->bip_iter.bi_size is decremented after bio_advance() ->
bio_integrity_advance() is called, the BUG_ON() in bio_integrity_verify()
ends up tripping in v3.14-rc1 code with the advent of immutable biovecs
in:

commit d57a5f7c6605f15f3b5134837e68b448a7cea88e
Author: Kent Overstreet <kmo@daterainc.com>
Date:   Sat Nov 23 17:20:16 2013 -0800

    bio-integrity: Convert to bvec_iter

Given that there is no easy way to ascertain the original bi_size
value, go ahead and drop this BUG_ON().

Reported-by: Sagi Grimberg <sagig@dev.mellanox.co.il>
Reported-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Kent Overstreet <kmo@daterainc.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Jens Axboe <axboe@fb.com>
fs/bio-integrity.c