]> Pileus Git - ~andy/linux/commit
drm/i915: grab a pages pin count for preallocate stolen
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 17 Dec 2013 22:42:11 +0000 (23:42 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 18 Dec 2013 12:25:29 +0000 (13:25 +0100)
commitd8ccba866356e5b8989ff9081df66cf300b1f834
treedc38dd10c6d94b908f12ef2b66535886c88eae0a
parent820c1980353808717f78a0c4ca2c734f0247dc0c
drm/i915: grab a pages pin count for preallocate stolen

But only when we indeed set up a gtt mapping. We need this since the
vma also holds a pages_pin_count, on top of the unconditional
pages_pin_count we grab for all stolen objects (to avoid swap-out).

This should avoid a pages_pin_count underrun when cleaning up
framebuffers objects taken over from the BIOS.

Chris mentioned in his review that this bug even predates the vma
conversion.

Reported-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Ben Widawsky <benjamin.widawsky@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_gem_stolen.c