]> Pileus Git - ~andy/linux/commit
ARM: OMAP3+: SmartReflex: clear ERRCONFIG_VPBOUNDINTST only on a need
authorNishanth Menon <nm@ti.com>
Wed, 29 Feb 2012 22:33:42 +0000 (23:33 +0100)
committerKevin Hilman <khilman@ti.com>
Mon, 5 Mar 2012 19:29:26 +0000 (11:29 -0800)
commitcfec9c54f99ce6aa3e31c39ef6df749550ab49c1
tree4590035e3cd9b3bc962cadd0b5e3c6710146d218
parentade6ec056fd4acdf4826178eeb305ed263844532
ARM: OMAP3+: SmartReflex: clear ERRCONFIG_VPBOUNDINTST only on a need

The VPBOUNDINTST field of the ERRCONFIG register has an additional
functional meaning of force clearing the SR internal signal with VP
(sr_interruptz).
This can result in scenarios where the VP->SR protocol is violated
because the SR internal signal with VP is already high and VP will
never clear the vpirqclr signal.
Therefore during the next force update to reset to nominal voltage,
VP cannot pulse vpirqclr, so the PRCM HW cannot generate the tranxdone
IRQ and the situation is not recoverable until a cold reset is invoked.

To prevent this situation, check if status is set before clearing it
as this needs to be done only on a need basis.

Reported-by: Vincent Bour <v-bour@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Jean Pihet <j-pihet@ti.com>
Reviewed-by: Kevin Hilman <khilman@ti.com>
Signed-off-by: Kevin Hilman <khilman@ti.com>
arch/arm/mach-omap2/smartreflex.c