]> Pileus Git - ~andy/linux/commit
Input: elantech - improve clickpad detection
authorHans de Goede <hdegoede@redhat.com>
Mon, 16 Dec 2013 15:09:25 +0000 (07:09 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 18 Dec 2013 16:47:29 +0000 (08:47 -0800)
commitc15bdfd5b9831e4cab8cfc118243956e267dd30e
tree0b239e0ae12ab4189a83a6f7c71feb5c814484b3
parent768d9aa55740754aa4efb8aca594e3841237dd88
Input: elantech -  improve clickpad detection

The current assumption in the elantech driver that hw version 3 touchpads
are never clickpads and hw version 4 touchpads are always clickpads is
wrong.

There are several bug reports for this, ie:
https://bugzilla.redhat.com/show_bug.cgi?id=1030802
http://superuser.com/questions/619582/right-elantech-touchpad-button-not-working-in-linux

I've spend a couple of hours wading through various bugzillas, launchpads
and forum posts to create a list of fw-versions and capabilities for
different laptop models to find a good method to differentiate between
clickpads and versions with separate hardware buttons.

Which shows that a device being a clickpad is reliable indicated by bit 12
being set in the fw_version. I've included the gathered list inside the
driver, so that we've this info at hand if we need to revisit this later.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/mouse/elantech.c