]> Pileus Git - ~andy/linux/commit
HID: core: fix reporting of raw events
authorJiri Kosina <jkosina@suse.cz>
Mon, 3 Jun 2013 09:27:48 +0000 (11:27 +0200)
committerJiri Kosina <jkosina@suse.cz>
Mon, 3 Jun 2013 09:27:48 +0000 (11:27 +0200)
commitb1a1442a23776756b254b69786848a94d92445ba
treec02acbe08a96ec04d4a836624ce972f86d85a15b
parent68e353fe476e7dab4644b9e7b4979b72726397ae
HID: core: fix reporting of raw events

hdrw->raw event can return three different return value types:

- ret < 0 indicates that the hdrv driver found an error while parsing
- ret == 0 indicates no error has been encountered, and the driver has
           processed the report
- ret > 0 indicates that there was no parsing error, and the driver hasn't
processed the event.

Calling hid_report_raw_event() has to be called appropriately so that it
reflects what has been done by ->raw_event() callback, otherwise we might
updates of the in-kernel structure are lost upon arrival of the report, which
is wrong.

Reported-and-tested-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Reported-and-tested-by: Daniel Leung <daniel.leung@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-core.c