]> Pileus Git - ~andy/linux/commit
iwlegacy: 4965-rs: avoid null pointer dereference error
authorColin Ian King <colin.king@canonical.com>
Tue, 26 Mar 2013 17:35:23 +0000 (17:35 +0000)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 27 Mar 2013 15:07:05 +0000 (11:07 -0400)
commitace5af39866da7d45f43774150dace19a73716d6
treeecf729c4259b96a37fa3b98024076e76e9f88ab8
parent7fc0357479eeff4ca808c4d8c09bc7631f576b8d
iwlegacy: 4965-rs: avoid null pointer dereference error

il4965_rs_initialize_lq checks to see if sta is null, however, before that
check il4965_rs_use_green dereferences sta when intializing use_green.
Avoid a potential null pointer dereference error by only calling
il4965_rs_use_green after we are sure sta is not null.

Smatch analysis:

drivers/net/wireless/iwlegacy/4965-rs.c:2160 il4965_rs_initialize_lq() warn:
  variable dereferenced before check 'sta' (see line 2155)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/iwlegacy/4965-rs.c