]> Pileus Git - ~andy/linux/commit
rtc: ds1286: Initialize drvdata before registering device
authorJohn Stultz <john.stultz@linaro.org>
Sat, 7 May 2011 00:21:12 +0000 (17:21 -0700)
committerJohn Stultz <john.stultz@linaro.org>
Sat, 7 May 2011 00:42:47 +0000 (17:42 -0700)
commit9a281a677c1dbf25943b5bc3225de21fcb4945ae
tree2923528b76a0f27e6244ff58daf4c80cb3e32f20
parent92d921c5def1a7b1411bc54859c0771b2cf2c08d
rtc: ds1286: Initialize drvdata before registering device

Commit f44f7f96a20 ("RTC: Initialize kernel state from RTC") uncovered
an issue in a number of RTC drivers, where the drivers call
rtc_device_register before initializing the device or platform drvdata.

This frequently results in null pointer dereferences when the
rtc_device_register immediately makes use of the rtc device, calling
rtc_read_alarm.

The solution is to ensure the drvdata is initialized prior to registering
the rtc device.

CC: Wolfram Sang <w.sang@pengutronix.de>
CC: Alessandro Zummo <a.zummo@towertech.it>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: rtc-linux@googlegroups.com
Signed-off-by: John Stultz <john.stultz@linaro.org>
drivers/rtc/rtc-ds1286.c